@@ -792,6 +792,12 @@ static efi_status_t qcuefi_query_variable_info(u32 attr, u64 *storage_space, u64
return status;
}
+static const struct efivar_operations qcom_efivars_ro_ops = {
+ .get_variable = qcuefi_get_variable,
+ .get_next_variable = qcuefi_get_next_variable,
+ .query_variable_info = qcuefi_query_variable_info,
+};
+
static const struct efivar_operations qcom_efivar_ops = {
.get_variable = qcuefi_get_variable,
.set_variable = qcuefi_set_variable,
@@ -804,7 +810,9 @@ static const struct efivar_operations qcom_efivar_ops = {
static int qcom_uefisecapp_probe(struct auxiliary_device *aux_dev,
const struct auxiliary_device_id *aux_dev_id)
{
+ unsigned long *quirks = aux_dev->dev.platform_data;
struct qcom_tzmem_pool_config pool_config;
+ const struct efivar_operations *ops;
struct qcuefi_client *qcuefi;
int status;
@@ -829,7 +837,15 @@ static int qcom_uefisecapp_probe(struct auxiliary_device *aux_dev,
if (status)
return status;
- status = efivars_register(&qcuefi->efivars, &qcom_efivar_ops);
+ if (quirks &&
+ *quirks & QCOM_QSEECOM_QUIRK_RO_UEFIVARS) {
+ dev_dbg(&aux_dev->dev, "R/O UEFI vars implementation\n");
+ ops = &qcom_efivars_ro_ops;
+ } else {
+ ops = &qcom_efivar_ops;
+ }
+
+ status = efivars_register(&qcuefi->efivars, ops);
if (status)
qcuefi_set_reference(NULL);
@@ -51,4 +51,6 @@ static inline int qcom_qseecom_app_send(struct qseecom_client *client,
return qcom_scm_qseecom_app_send(client->app_id, req, req_size, rsp, rsp_size);
}
+#define QCOM_QSEECOM_QUIRK_RO_UEFIVARS BIT(0)
+
#endif /* __QCOM_QSEECOM_H */
For some platforms (e.g. Lenovo Yoga C630) we don't yet know a way to update variables in the permanent storage. However being able to read the vars is still useful as it allows us to get e.g. RTC offset. Add a quirk for QSEECOM specifying that UEFI variables for this platform should be registered in read-only mode. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> --- drivers/firmware/qcom/qcom_qseecom_uefisecapp.c | 18 +++++++++++++++++- include/linux/firmware/qcom/qcom_qseecom.h | 2 ++ 2 files changed, 19 insertions(+), 1 deletion(-)