From patchwork Mon Jan 14 10:21:11 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Kucheria X-Patchwork-Id: 155431 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp3489814jaa; Mon, 14 Jan 2019 02:22:15 -0800 (PST) X-Google-Smtp-Source: ALg8bN7fOupXqgfgm2T3ZMI+qqjYeD0Mp+ArU8EBQbX1bBgFRo1L93k6bswu9rFDOugh41R5ODFY X-Received: by 2002:a17:902:4081:: with SMTP id c1mr14048545pld.87.1547461335797; Mon, 14 Jan 2019 02:22:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547461335; cv=none; d=google.com; s=arc-20160816; b=rz81Dzwp42IZV/MbqeHOuh2ZKaFsdF1eDzokF2miln01+pSxSGHRqgn5jGQ1mTFQWq i+7O6I09rpctsGNY/z1pV9l9/VL3YXyzafXzxf7o0SrRAgM/ELURKvrQ2iu2arUvYefz T7EjpBUsmAcl3e9/h4/Da5fIduCAuvuVF3rSvBvKJiwWadsbFcs2qXgCB/OkEENMr1oL L6IoqGZiGoHc6/0ZlYP7zX8Cq4PsndGlR862S77RevPmHymOi6SnSeOryydhJ6RvmH8I crsckpBZPTxEXP4m/s53dYXbLQSYUnKyxPzDO0mxwZ7D0mQJASj7rpM/vKd+2Tt6s7AQ gSIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=Wu/tmpT7BDXo4oTQUwIjofVpVoXKP/NrUVRomzzYDk8=; b=aWsopyqlDXvEN6gv69zgehs1WOAWawzQpAVAIriG4hple1x1C3b86cHTGVLd9U2lXR wT528QPDDEbeTzf7pOtVQEQkzbt29BZiwjWbrrBHlOzRq/IwdMSFf8831EJwMfDgAX2T sBPRad8SatFehNx3ONIDln9RVh/68wcfgBVZD3K0tcS6F3ZafHVQJF6FS8RvFX9XNgIE bH1erhcFopT88Lf//s5OuoFXHg6BIY9YMgR4E/04ZJHcexBrVGYLK/Oe+1TVvuFOCnW+ wwIH5shtVwJLBED5H9FSzi/36F0fmaxvJytsPRRAkdr0Izp7aHQCKEh5p+cQiyD/+Lp6 VzNg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Z1N08G6o; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h10si11496743pgi.562.2019.01.14.02.22.15; Mon, 14 Jan 2019 02:22:15 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Z1N08G6o; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726885AbfANKWO (ORCPT + 15 others); Mon, 14 Jan 2019 05:22:14 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:40426 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726876AbfANKWO (ORCPT ); Mon, 14 Jan 2019 05:22:14 -0500 Received: by mail-wm1-f68.google.com with SMTP id f188so8212156wmf.5 for ; Mon, 14 Jan 2019 02:22:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=Wu/tmpT7BDXo4oTQUwIjofVpVoXKP/NrUVRomzzYDk8=; b=Z1N08G6opSL2YIWhjPthqe3mvAA4GZbBv2gowuWMVignQnnwPM4OtQrPGFKjt4ykXb E/LzT9mAttHZw2pS7F1UL4raKcuvwlI7KsrllyKU55Twem4025TdkuTL3C8P46o2jfNP hj8Jd88FQRY8AOg3H71Ro7UAKEaY73RUPWxaQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=Wu/tmpT7BDXo4oTQUwIjofVpVoXKP/NrUVRomzzYDk8=; b=FC/DPonIog9b7QoWJoFFwhpzB0impzz2gaDp6eZCnnk4nOvBBk6saBGwWQuut1sp6v sCskrxS0JAbtdqBnVTgAV35yxDK377mMRPBf21d8awOqEOH/kSEGAKxZMual8nztyxYF yipm6YZiY/xDnRX+KUIGDslfQaP8755YnGbj0SS5p+3Y/LuxbKlJvQ6t8ZgqTbAaH0y0 JiYZckqvbRKbNELFESOIcbB+ZISuiPM87/RC4S8VeZUMiVaYWENdTzaYeebJPTzo2s0A wA2vmp7joRgwJbs8EG5nvCSt04GKjrm3LXCQ8PCldUoxTfr5cf4qiWDeMbBcDvf/U+k2 r7RA== X-Gm-Message-State: AJcUukenBvh/v4qv7C9QgXq3l4gufn+GlNJIz4MpAwSe8mx/sYpQZCSf HTitRW0OYMROXsNWjTl+a+IlEw== X-Received: by 2002:a7b:c34c:: with SMTP id l12mr11046788wmj.147.1547461332650; Mon, 14 Jan 2019 02:22:12 -0800 (PST) Received: from localhost ([49.248.81.155]) by smtp.gmail.com with ESMTPSA id k15sm105513691wru.8.2019.01.14.02.22.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 14 Jan 2019 02:22:11 -0800 (PST) From: Amit Kucheria To: linux-kernel@vger.kernel.org Cc: linux-arm-msm@vger.kernel.org, bjorn.andersson@linaro.org, viresh.kumar@linaro.org, edubezval@gmail.com, andy.gross@linaro.org, tdas@codeaurora.org, swboyd@chromium.org, dianders@chromium.org, mka@chromium.org, Javi Merino , Zhang Rui , Daniel Lezcano , linux-pm@vger.kernel.org (open list:THERMAL/CPU_COOLING) Subject: [PATCH v2 9/9] thermal: cpu_cooling: Clarify error message Date: Mon, 14 Jan 2019 15:51:11 +0530 Message-Id: <2de2d178380525191d99d6c3619ad8c45efdbab4.1547458732.git.amit.kucheria@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Make it clear that it is a failure if the cpufreq driver was unable to register as a cooling device. Makes it easier to find in logs and grepping for words like fail, err, warn. Signed-off-by: Amit Kucheria --- drivers/thermal/cpu_cooling.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1 Acked-by: Viresh Kumar diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c index dfd23245f778..6fff16113628 100644 --- a/drivers/thermal/cpu_cooling.c +++ b/drivers/thermal/cpu_cooling.c @@ -774,7 +774,7 @@ of_cpufreq_cooling_register(struct cpufreq_policy *policy) cdev = __cpufreq_cooling_register(np, policy, capacitance); if (IS_ERR(cdev)) { - pr_err("cpu_cooling: cpu%d is not running as cooling device: %ld\n", + pr_err("cpu_cooling: cpu%d failed to register as cooling device: %ld\n", policy->cpu, PTR_ERR(cdev)); cdev = NULL; }