From patchwork Tue Jan 27 07:15:34 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 43814 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wi0-f199.google.com (mail-wi0-f199.google.com [209.85.212.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 36C082409D for ; Tue, 27 Jan 2015 07:15:46 +0000 (UTC) Received: by mail-wi0-f199.google.com with SMTP id r20sf1430077wiv.2 for ; Mon, 26 Jan 2015 23:15:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:message-id:date:from:user-agent :mime-version:to:cc:subject:references:in-reply-to:content-type :content-transfer-encoding:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=xRoTwwYIekii2B3JtnYO6E7xBD362k6OSuHnoS9raLM=; b=m0zeTWr6w+VwFYzFwAlDnBtD1hpvLzZFRMzcXZ0oWXReiPOnEXxu0dDONVnIQpXG7P jbTRCfILuUzKhqrga6IWcXL0z2I2KflPDMys9pStUoY6hLrXRWNk0/QDd3A3HNmIjtGK NpqqDz0KcVW5hinTvm0UiUYmDR5pvWJMEoOPNfeyAWCdq57i/I3W/vLHwhFjSny/qAMA N959JreCPELFtj/liyCZyZkyAewp1yPD0SpOD5RZQ5bf1goyO4ltUsF/u6pD98DvkHwZ fq2rx/Y3xGONKoIEqzh8KyzyHhBYbDy1FfBR0Gcv/1rRqDfQPP4R9Qj74uBeieUIILgp Vv5Q== X-Gm-Message-State: ALoCoQkFRLYTnsPCYx4DKCk/8V4jjFNOX+NniyYdfQECvxomzgAZ8wgPEyZ1pPHahu2ewClttuLg X-Received: by 10.112.64.171 with SMTP id p11mr251961lbs.12.1422342945440; Mon, 26 Jan 2015 23:15:45 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.8.115 with SMTP id q19ls565446laa.55.gmail; Mon, 26 Jan 2015 23:15:45 -0800 (PST) X-Received: by 10.152.43.103 with SMTP id v7mr2324665lal.29.1422342945214; Mon, 26 Jan 2015 23:15:45 -0800 (PST) Received: from mail-lb0-f173.google.com (mail-lb0-f173.google.com. [209.85.217.173]) by mx.google.com with ESMTPS id tz3si366256lbb.66.2015.01.26.23.15.45 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 26 Jan 2015 23:15:45 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.173 as permitted sender) client-ip=209.85.217.173; Received: by mail-lb0-f173.google.com with SMTP id p9so11588101lbv.4 for ; Mon, 26 Jan 2015 23:15:45 -0800 (PST) X-Received: by 10.112.170.36 with SMTP id aj4mr2322252lbc.3.1422342945077; Mon, 26 Jan 2015 23:15:45 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.35.133 with SMTP id h5csp1008328lbj; Mon, 26 Jan 2015 23:15:44 -0800 (PST) X-Received: by 10.66.222.227 with SMTP id qp3mr41468846pac.47.1422342939890; Mon, 26 Jan 2015 23:15:39 -0800 (PST) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id no12si342219pdb.214.2015.01.26.23.15.39; Mon, 26 Jan 2015 23:15:39 -0800 (PST) Received-SPF: none (google.com: linux-arm-msm-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753280AbbA0HPi (ORCPT + 6 others); Tue, 27 Jan 2015 02:15:38 -0500 Received: from mail-wi0-f171.google.com ([209.85.212.171]:41509 "EHLO mail-wi0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751673AbbA0HPh (ORCPT ); Tue, 27 Jan 2015 02:15:37 -0500 Received: by mail-wi0-f171.google.com with SMTP id l15so2604479wiw.4 for ; Mon, 26 Jan 2015 23:15:36 -0800 (PST) X-Received: by 10.194.201.103 with SMTP id jz7mr53583273wjc.14.1422342936348; Mon, 26 Jan 2015 23:15:36 -0800 (PST) Received: from [192.168.1.11] (host-2-98-216-248.as13285.net. [2.98.216.248]) by mx.google.com with ESMTPSA id b1sm923199wiz.6.2015.01.26.23.15.34 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Jan 2015 23:15:35 -0800 (PST) Message-ID: <54C73B16.2030506@linaro.org> Date: Tue, 27 Jan 2015 07:15:34 +0000 From: Srinivas Kandagatla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Narendran Rajan , Zhang Rui , Eduardo Valentin CC: Linux ARM MSM , Linux PM Subject: Re: [PATCH] dt-bindings: document qcom tsens thermal References: <1422331687-19535-1-git-send-email-nrajan@codeaurora.org> In-Reply-To: <1422331687-19535-1-git-send-email-nrajan@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: srinivas.kandagatla@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.173 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Hi Narendran, What a coincidence.. I was just in the middle of forward porting the same driver from 3.4 kernel :-) You look fast... :-) On 27/01/15 04:08, Narendran Rajan wrote: > Add binding documentation for the QCOM tsens device tree node > --- > .../devicetree/bindings/thermal/qcom-thermal.txt | 58 ++++++++++++++++++++++ > 1 file changed, 58 insertions(+) > create mode 100644 Documentation/devicetree/bindings/thermal/qcom-thermal.txt > > diff --git a/Documentation/devicetree/bindings/thermal/qcom-thermal.txt b/Documentation/devicetree/bindings/thermal/qcom-thermal.txt > new file mode 100644 > index 0000000..d2e99d6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/thermal/qcom-thermal.txt > @@ -0,0 +1,58 @@ > +* QCOM SoC Temperature Sensor (TSENS) > + > +Required properties: > +- compatible : "qcom,ipq806x-tsens" I think this should be something like qcom,msm8960-tsens as that is the first part where this tsens appeared. > +- interrupts : The interrupt number to the cpu. The interrupt specifier format > + depends on the interrupt controller. > +- qcom,imem : Must contain phandle to imem syscon node Doing this way would work but not great, We should try to do this in an abstracted way so that all the drivers who are in need of qfprom would not add the same code all the time. I did send some WIP patches on msm mailing list. > +- qcom,tsens-base : Must contain phandle to clock controller node This is not correct, you dont need this property. AFAIK for APQ8064 Tsens should be a child of gcc as some of the registers are in already mapped by gcc. You should probably use this patch + do a base = dev_get_regmap(dev->parent, NULL); ------------------>cut<----------------------------- From 87b71df272048fb3aaa89b77524e4b6426e5ddc5 Mon Sep 17 00:00:00 2001 From: Srinivas Kandagatla Date: Thu, 22 Jan 2015 14:03:53 +0000 Subject: [PATCH] clk: qcom: gcc-msm8960: add child devices support. This patch adds support to add child devices to gcc as some of the registers mapped by gcc are used by things like thermal sensors. Signed-off-by: Srinivas Kandagatla --- drivers/clk/qcom/gcc-msm8960.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) static int gcc_msm8960_remove(struct platform_device *pdev) diff --git a/drivers/clk/qcom/gcc-msm8960.c b/drivers/clk/qcom/gcc-msm8960.c index 0b61e8a..8307db3 100644 --- a/drivers/clk/qcom/gcc-msm8960.c +++ b/drivers/clk/qcom/gcc-msm8960.c @@ -15,6 +15,7 @@ #include #include #include +#include #include #include #include @@ -3666,7 +3667,8 @@ static int gcc_msm8960_probe(struct platform_device *pdev) hfpll_l2.d = &hfpll_l2_8064_data; } - return qcom_cc_probe(pdev, match->data); + qcom_cc_probe(pdev, match->data); + return of_platform_populate(pdev->dev.of_node, NULL, NULL, &pdev->dev); }