From patchwork Fri Sep 20 21:52:19 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Kucheria X-Patchwork-Id: 174159 Delivered-To: patch@linaro.org Received: by 2002:a92:7e96:0:0:0:0:0 with SMTP id q22csp3031701ill; Fri, 20 Sep 2019 14:52:53 -0700 (PDT) X-Google-Smtp-Source: APXvYqzmGDRrwq9M4DR5YHsLBxKmFrLVgUd9a6ydg8365Nxq0tqQ9kaV91npZdAwbxVP44X6xkyi X-Received: by 2002:a05:6402:2cb:: with SMTP id b11mr24647788edx.285.1569016372895; Fri, 20 Sep 2019 14:52:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569016372; cv=none; d=google.com; s=arc-20160816; b=giSNKRboYWbtgUaC9yzJeEHcywsuq/9xsmtyfettttXUM/GHR/CnD1pw2B9PesBEAt 8ki77B36rXZosgzUNqOyGc3hhs4CIUoK4UOGr+IBm2eTuqdeNZ4OcxisDxIEXOt3iSKg V8FrX6+oFEajhWUqBg9PpNoDMjQhbF+dmroPpG0XJiinX/jH8ihySXddh9fVzPCYRICl yzJeKtoM7oO+YISDVhoXEb+pQTbW4/jfxc6eb+QqQC4R7ntU0jFTWA9+AV2wmXWE05hq UVf86PBumhX/GJZglVpjy9Xu/hdwQEBruzV3nRrOZ/TVL3j9sMWohKWSySQqiWe9FoKT zWBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=GhiEdPc2a74wJTsECxjn5PPZJWIyvNu4x7DC2dya90E=; b=luTq3KPV4Tm/bpLTqg1XhsCA2u8Eh5H0ca/6fcfIZIyC/NYR00cCnLFlImgjDE1Vbc dP2xB6Hu1rLAkW0Nm/dRkM/bYNpTTRcpcUelcM6j4OUm3OSOMPEjRNCuSxroWvjwlWuE bvPTB+q3+Hg0aBPyAydIP+gm7TNaaT9WgJtf71+zpQEE+elUAmCHOK13Px/XFFVGtBuh hY8VpJprRGIqEdxZyDXJlMls1CzoNkGRw+zLiUcPqq5ZNGVEounzsiGowN6QEcBqOUfF snYWzs6A4be+g77df8bEYzWUXEIWptX7yOO73bkahRFTETD/b8v0zBcu17V2LdiAmzAD C71g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=UKLkJ3WY; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d17si2225527eda.213.2019.09.20.14.52.52; Fri, 20 Sep 2019 14:52:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=UKLkJ3WY; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727684AbfITVwu (ORCPT + 15 others); Fri, 20 Sep 2019 17:52:50 -0400 Received: from mail-pl1-f194.google.com ([209.85.214.194]:44112 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727538AbfITVwu (ORCPT ); Fri, 20 Sep 2019 17:52:50 -0400 Received: by mail-pl1-f194.google.com with SMTP id q15so3783939pll.11 for ; Fri, 20 Sep 2019 14:52:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=GhiEdPc2a74wJTsECxjn5PPZJWIyvNu4x7DC2dya90E=; b=UKLkJ3WYsXhAlSM108Xru6zTxfGn7hTvCIUzDAgh9Vc2t6Sfma/G9QNdG/ssvEUVA4 nlVvBgGkIp9r+CwA4dwuCr3MK9B2sstK3BISpG/gc09UFkQX4QS0WE2N5rYW4OHOEpq+ fDjkVg7qEIEBPJ1ehuugfxHmSs4wZJ7tAo/k3xjwZpKP4VsXZau+9Kxlh/FEnSOuaH8p wCcJ5FdkDG3MMpDo9eItxPHELRp9Bjxw1Ag0VBaAeuCVDHgWLtlqngL0uPIhPeqFeaLy TL1QL+ZTM1eAYUwRTo+nP8zzFtCoFMjJmihxaPtGm+/q824Q4hxc5coYL3nCrEnOBMv8 IbqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=GhiEdPc2a74wJTsECxjn5PPZJWIyvNu4x7DC2dya90E=; b=KuFiH+RaqHrKYMCT8GrO2Kh8pNeg0lJpS/oCnujvVc7tUFle31TgMbE5hP9hSEqQGL TNAaEm5YTvSg8H1s1Lud+W6gvphb8oe+TXyAtaNhtU1OwCnW952/WVDzn8o1oXOMo5Mb PL+7Op16kdiTDSzrH09zNuR3AZU4fFGepZ3QR0/Jut1/9cCcmQgoCC2uRFePn5f2KY+1 U6wdnqw+QYQ+efGPj61ZsC/6HFGo1mP4Nf3exliKiHPhUzdJ42UU/1bhqJYqjf30SLml FL22snZio3167vm9UYV4rkUbWX8D9VVrdJYTGNcWEpUk6Fd0ZENNChz/3q8x4CF15NjZ YCjw== X-Gm-Message-State: APjAAAVFpuQi8TiLKTWWwJfcFD+8duHnnvtj/mGfJh9EPkxUeLCez4EI Li48Kx6YAQwMuN4w5ms2rQuIEg== X-Received: by 2002:a17:902:820f:: with SMTP id x15mr19893535pln.130.1569016369090; Fri, 20 Sep 2019 14:52:49 -0700 (PDT) Received: from localhost (wsip-98-175-107-49.sd.sd.cox.net. [98.175.107.49]) by smtp.gmail.com with ESMTPSA id r23sm2893785pjo.22.2019.09.20.14.52.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 20 Sep 2019 14:52:48 -0700 (PDT) From: Amit Kucheria To: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, bjorn.andersson@linaro.org, edubezval@gmail.com, agross@kernel.org, masneyb@onstation.org, swboyd@chromium.org, Daniel Lezcano , Mark Rutland , Rob Herring , Zhang Rui Cc: linux-pm@vger.kernel.org Subject: [PATCH v4 04/15] drivers: thermal: tsens: Add debugfs support Date: Fri, 20 Sep 2019 14:52:19 -0700 Message-Id: X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Dump some basic version info and sensor details into debugfs. Example from qcs404 below: --(/sys/kernel/debug) $ ls tsens/ 4a9000.thermal-sensor version --(/sys/kernel/debug) $ cat tsens/version 1.4.0 --(/sys/kernel/debug) $ cat tsens/4a9000.thermal-sensor/sensors max: 11 num: 10 id slope offset ------------------------ 0 3200 404000 1 3200 404000 2 3200 404000 3 3200 404000 4 3200 404000 5 3200 404000 6 3200 404000 7 3200 404000 8 3200 404000 9 3200 404000 Signed-off-by: Amit Kucheria Reviewed-by: Stephen Boyd --- drivers/thermal/qcom/tsens-common.c | 83 +++++++++++++++++++++++++++++ drivers/thermal/qcom/tsens.c | 2 + drivers/thermal/qcom/tsens.h | 6 +++ 3 files changed, 91 insertions(+) -- 2.17.1 diff --git a/drivers/thermal/qcom/tsens-common.c b/drivers/thermal/qcom/tsens-common.c index 7437bfe196e5..ea2c46cc6a66 100644 --- a/drivers/thermal/qcom/tsens-common.c +++ b/drivers/thermal/qcom/tsens-common.c @@ -3,6 +3,7 @@ * Copyright (c) 2015, The Linux Foundation. All rights reserved. */ +#include #include #include #include @@ -139,6 +140,77 @@ int get_temp_common(struct tsens_sensor *s, int *temp) return 0; } +#ifdef CONFIG_DEBUG_FS +static int dbg_sensors_show(struct seq_file *s, void *data) +{ + struct platform_device *pdev = s->private; + struct tsens_priv *priv = platform_get_drvdata(pdev); + int i; + + seq_printf(s, "max: %2d\nnum: %2d\n\n", + priv->feat->max_sensors, priv->num_sensors); + + seq_puts(s, " id slope offset\n--------------------------\n"); + for (i = 0; i < priv->num_sensors; i++) { + seq_printf(s, "%8d %8d %8d\n", priv->sensor[i].hw_id, + priv->sensor[i].slope, priv->sensor[i].offset); + } + + return 0; +} + +static int dbg_version_show(struct seq_file *s, void *data) +{ + struct platform_device *pdev = s->private; + struct tsens_priv *priv = platform_get_drvdata(pdev); + u32 maj_ver, min_ver, step_ver; + int ret; + + if (tsens_ver(priv) > VER_0_1) { + ret = regmap_field_read(priv->rf[VER_MAJOR], &maj_ver); + if (ret) + return ret; + ret = regmap_field_read(priv->rf[VER_MINOR], &min_ver); + if (ret) + return ret; + ret = regmap_field_read(priv->rf[VER_STEP], &step_ver); + if (ret) + return ret; + seq_printf(s, "%d.%d.%d\n", maj_ver, min_ver, step_ver); + } else { + seq_puts(s, "0.1.0\n"); + } + + return 0; +} + +DEFINE_SHOW_ATTRIBUTE(dbg_version); +DEFINE_SHOW_ATTRIBUTE(dbg_sensors); + +static void tsens_debug_init(struct platform_device *pdev) +{ + struct tsens_priv *priv = platform_get_drvdata(pdev); + struct dentry *root, *file; + + root = debugfs_lookup("tsens", NULL); + if (!root) + priv->debug_root = debugfs_create_dir("tsens", NULL); + else + priv->debug_root = root; + + file = debugfs_lookup("version", priv->debug_root); + if (!file) + debugfs_create_file("version", 0444, priv->debug_root, + pdev, &dbg_version_fops); + + /* A directory for each instance of the TSENS IP */ + priv->debug = debugfs_create_dir(dev_name(&pdev->dev), priv->debug_root); + debugfs_create_file("sensors", 0444, priv->debug, pdev, &dbg_sensors_fops); +} +#else +static inline void tsens_debug_init(struct platform_device *pdev) {} +#endif + static const struct regmap_config tsens_config = { .name = "tm", .reg_bits = 32, @@ -199,6 +271,15 @@ int __init init_common(struct tsens_priv *priv) goto err_put_device; } + if (tsens_ver(priv) > VER_0_1) { + for (i = VER_MAJOR; i <= VER_STEP; i++) { + priv->rf[i] = devm_regmap_field_alloc(dev, priv->srot_map, + priv->fields[i]); + if (IS_ERR(priv->rf[i])) + return PTR_ERR(priv->rf[i]); + } + } + priv->rf[TSENS_EN] = devm_regmap_field_alloc(dev, priv->srot_map, priv->fields[TSENS_EN]); if (IS_ERR(priv->rf[TSENS_EN])) { @@ -238,6 +319,8 @@ int __init init_common(struct tsens_priv *priv) } } + tsens_debug_init(op); + return 0; err_put_device: diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c index 06c6bbd69a1a..772aa76b50e1 100644 --- a/drivers/thermal/qcom/tsens.c +++ b/drivers/thermal/qcom/tsens.c @@ -3,6 +3,7 @@ * Copyright (c) 2015, The Linux Foundation. All rights reserved. */ +#include #include #include #include @@ -176,6 +177,7 @@ static int tsens_remove(struct platform_device *pdev) { struct tsens_priv *priv = platform_get_drvdata(pdev); + debugfs_remove_recursive(priv->debug_root); if (priv->ops->disable) priv->ops->disable(priv); diff --git a/drivers/thermal/qcom/tsens.h b/drivers/thermal/qcom/tsens.h index d022e726d074..e1d6af71b2b9 100644 --- a/drivers/thermal/qcom/tsens.h +++ b/drivers/thermal/qcom/tsens.h @@ -292,6 +292,8 @@ struct tsens_context { * @feat: features of the IP * @fields: bitfield locations * @ops: pointer to list of callbacks supported by this device + * @debug_root: pointer to debugfs dentry for all tsens + * @debug: pointer to debugfs dentry for tsens controller * @sensor: list of sensors attached to this device */ struct tsens_priv { @@ -305,6 +307,10 @@ struct tsens_priv { const struct tsens_features *feat; const struct reg_field *fields; const struct tsens_ops *ops; + + struct dentry *debug_root; + struct dentry *debug; + struct tsens_sensor sensor[0]; };