| Message ID | 20230207052829.3996-1-steev@kali.org |
|---|---|
| Headers | show |
| Series | Add WCN6855 Bluetooth support | expand |
On 07/02/2023 06:28, Steev Klimaszewski wrote: > Add bindings for the QTI WCN6855 chipset. > > Signed-off-by: Steev Klimaszewski <steev@kali.org> > --- > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 7.02.2023 06:28, Steev Klimaszewski wrote: > From: Bjorn Andersson <bjorn.andersson@linaro.org> > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> > Signed-off-by: Steev Klimaszewski <steev@kali.org> > Reviewed-by: Brian Masney <bmasney@redhat.com> > > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > > Changes since v3: > * Fix commit message changelog > > Changes since v2: > * No changes since v2 > > Changes since v1: > * change subject line, move node, and add my s-o-b > --- > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > index fa2d0d7d1367..eab54aab3b76 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > @@ -1207,6 +1207,20 @@ spi2: spi@988000 { > status = "disabled"; > }; > > + uart2: serial@988000 { > + compatible = "qcom,geni-uart"; > + reg = <0 0x00988000 0 0x4000>; > + clocks = <&gcc GCC_QUPV3_WRAP0_S2_CLK>; > + clock-names = "se"; > + interrupts = <GIC_SPI 603 IRQ_TYPE_LEVEL_HIGH>; > + operating-points-v2 = <&qup_opp_table_100mhz>; > + power-domains = <&rpmhpd SC8280XP_CX>; > + interconnects = <&clk_virt MASTER_QUP_CORE_0 0 &clk_virt SLAVE_QUP_CORE_0 0>, > + <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_QUP_0 0>; > + interconnect-names = "qup-core", "qup-config"; > + status = "disabled"; > + }; > + > i2c3: i2c@98c000 { > compatible = "qcom,geni-i2c"; > reg = <0 0x0098c000 0 0x4000>;
This is the 4th version of the patchset, which started out as a bit of an RFC/RFT but has actually worked so, I think this 4th revision is in a pretty decent spot, at least in terms of the code itself... that said... First things first, I do not have access to the specs nor the schematics, so a lot of this was done via guess work, looking at the acpi tables, and looking at how a similar device (wcn6750) was added. This 4th revision does have the regulators added, which were pulled from the bsrc_bt.bin file from the Windows partition. The end result is that we do have a working device, but not entirely reliable. Hopefully by getting this out there, people who do have access to the specs or schematics can see where the improvements or fixes need to come. There are a few things that I am not sure why they happen, and don't have the knowledge level to figure out why they happen or debugging it. Bluetooth: hci0: setting up wcn6855 Bluetooth: hci0: Frame reassembly failed (-84) Bluetooth: hci0: QCA Product ID :0x00000013 Bluetooth: hci0: QCA SOC Version :0x400c0210 Bluetooth: hci0: QCA ROM Version :0x00000201 Bluetooth: hci0: QCA Patch Version:0x000038e6 Bluetooth: hci0: QCA controller version 0x02100201 Bluetooth: hci0: unexpected event for opcode 0xfc48 Bluetooth: hci0: Sending QCA Patch config failed (-110) Bluetooth: hci0: QCA Downloading qca/hpbtfw21.tlv Bluetooth: hci0: QCA Downloading qca/hpnv21g.bin Bluetooth: hci0: QCA setup on UART is completed I do not know why the Frame assembly failed, nor the unexpected event. Likewise, I'm not entirely sure why it says the patch config send times out, and *then* seems to send it? The BD Address also seems to be incorrect, and I'm not sure what is going on there either. Testing was done by connecting a Razer Orochi bluetooth mouse, and using it, as well as connecting to and using an H2GO bluetooth speaker and playing audio out via canberra-gtk-play as well as a couple of YouTube videos in a browser. The mouse only seems to work when < 2 ft. from the laptop, and for the speaker, only "A2DP Sink, codec SBC" would provide audio output, and while I could see that data was being sent to the speaker, it wasn't always outputting, and going > 4ft. away, would often disconnect. steev@wintermute:~$ hciconfig -a hci0: Type: Primary Bus: UART BD Address: 00:00:00:00:5A:AD ACL MTU: 1024:8 SCO MTU: 240:4 UP RUNNING PSCAN RX bytes:1492 acl:0 sco:0 events:126 errors:0 TX bytes:128743 acl:0 sco:0 commands:597 errors:0 Features: 0xff 0xfe 0x8f 0xfe 0xd8 0x3f 0x5b 0x87 Packet type: DM1 DM3 DM5 DH1 DH3 DH5 HV1 HV2 HV3 Link policy: RSWITCH HOLD SNIFF Link mode: PERIPHERAL ACCEPT Name: 'wintermute' Class: 0x0c010c Service Classes: Rendering, Capturing Device Class: Computer, Laptop HCI Version: (0xc) Revision: 0x0 LMP Version: (0xc) Subversion: 0x46f7 Manufacturer: Qualcomm (29) steev@wintermute:~$ dmesg | grep Razer [ 3089.235440] input: Razer Orochi as /devices/virtual/misc/uhid/0005:1532:0056.0003/input/input11 [ 3089.238580] hid-generic 0005:1532:0056.0003: input,hidraw2: BLUETOOTH HID v0.01 Mouse [Razer Orochi] on 00:00:00:00:5a:ad steev@wintermute:~$ dmesg | grep H2GO [ 3140.959947] input: H2GO Speaker (AVRCP) as /devices/virtual/input/input12 Bjorn Andersson (1): arm64: dts: qcom: sc8280xp: Define uart2 Steev Klimaszewski (3): dt-bindings: net: Add WCN6855 Bluetooth Bluetooth: hci_qca: Add support for QTI Bluetooth chip wcn6855 arm64: dts: qcom: thinkpad-x13s: Add bluetooth .../net/bluetooth/qualcomm-bluetooth.yaml | 17 +++++ .../qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 76 +++++++++++++++++++ arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 14 ++++ drivers/bluetooth/btqca.c | 24 +++++- drivers/bluetooth/btqca.h | 10 +++ drivers/bluetooth/hci_qca.c | 56 ++++++++++---- 6 files changed, 182 insertions(+), 15 deletions(-) base-commit: 4fafd96910add124586b549ad005dcd179de8a18