| Message ID | 20230807110224.6024-1-silviu.barbulescu@nxp.com |
|---|---|
| Headers | show |
| Series | Configure BASE using separate structure | expand |
Hi Silviu, On Mon, Aug 7, 2023 at 4:11 AM Silviu Florian Barbulescu <silviu.barbulescu@nxp.com> wrote: > > Use preset configuration in capabilities. > Configure BASE using separate structure. Im not really sure why we want to switch to use BASE over Capabilities, up until now Capabilities is sort of mandatory and is already profile specific in case you are wondering how can someone detect what is the format used in Capabilities that is based on the UUID already. > Claudia Draghicescu (2): > client/player: Use preset configuration in capabilities. Configure > BASE using separate structure > bap: Use the BASE structure received from upper layer > > client/player.c | 24 +++++++++++++++++------- > profiles/audio/bap.c | 13 ++++++++++--- > 2 files changed, 27 insertions(+), 10 deletions(-) > > > base-commit: 80107630396d3d3a3984c599e0cb9b015be0499c > -- > 2.34.1 >
>From: Luiz Augusto von Dentz <luiz.dentz@gmail.com> >Sent: Monday, August 7, 2023 8:23 PM >To: Silviu Florian Barbulescu <silviu.barbulescu@nxp.com> >Cc: linux-bluetooth@vger.kernel.org; Claudia Cristina Draghicescu <claudia.rosu@nxp.com>; Mihai-Octavian Urzica <mihai-octavian.urzica@nxp.com>; Vlad Pruteanu <vlad.pruteanu@nxp.com>; Andrei Istodorescu <andrei.istodorescu@nxp.com>; Iulia Tanasescu <iulia.tanasescu@nxp.com> >Subject: [EXT] Re: [PATCH v2 0/2] Configure BASE using separate structure > >Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'Report this email' button > > >Hi Silviu, > >On Mon, Aug 7, 2023 at 4:11 AM Silviu Florian Barbulescu <silviu.barbulescu@nxp.com> wrote: >> >> Use preset configuration in capabilities. >> Configure BASE using separate structure. > >Im not really sure why we want to switch to use BASE over Capabilities, up until now Capabilities is sort of mandatory and is already profile specific in case you are wondering how can someone detect what is the format used in Capabilities that is based on the UUID already. Hi Luiz, we don't intend to switch use BASE over Capabilities, we just want to use both for broadcast. Capabilities for codec capabilities from preset that will be used in transport configuration. BASE is used for the over-the-air payload in Periodic Adv Data which is conformant to Table 3.15: Format of BASE used in Basic Audio Announcements from BAP Specification, also it is used for PTS testing that ask to modify the BASE structure. And we will copy the capabilities preset to the base structure to be sure we have the same codec capabilities in both of them. > >> Claudia Draghicescu (2): >> client/player: Use preset configuration in capabilities. Configure >> BASE using separate structure >> bap: Use the BASE structure received from upper layer >> >> client/player.c | 24 +++++++++++++++++------- >> profiles/audio/bap.c | 13 ++++++++++--- >> 2 files changed, 27 insertions(+), 10 deletions(-) >> >> >> base-commit: 80107630396d3d3a3984c599e0cb9b015be0499c >> -- >> 2.34.1 >> > > >-- >Luiz Augusto von Dentz
Hi Silviu, On Wed, Aug 9, 2023 at 2:46 AM Silviu Florian Barbulescu <silviu.barbulescu@nxp.com> wrote: > > >From: Luiz Augusto von Dentz <luiz.dentz@gmail.com> > >Sent: Monday, August 7, 2023 8:23 PM > >To: Silviu Florian Barbulescu <silviu.barbulescu@nxp.com> > >Cc: linux-bluetooth@vger.kernel.org; Claudia Cristina Draghicescu <claudia.rosu@nxp.com>; Mihai-Octavian Urzica <mihai-octavian.urzica@nxp.com>; Vlad Pruteanu <vlad.pruteanu@nxp.com>; Andrei Istodorescu <andrei.istodorescu@nxp.com>; Iulia Tanasescu <iulia.tanasescu@nxp.com> > >Subject: [EXT] Re: [PATCH v2 0/2] Configure BASE using separate structure > > > >Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'Report this email' button > > > > > >Hi Silviu, > > > >On Mon, Aug 7, 2023 at 4:11 AM Silviu Florian Barbulescu <silviu.barbulescu@nxp.com> wrote: > >> > >> Use preset configuration in capabilities. > >> Configure BASE using separate structure. > > > >Im not really sure why we want to switch to use BASE over Capabilities, up until now Capabilities is sort of mandatory and is already profile specific in case you are wondering how can someone detect what is the format used in Capabilities that is based on the UUID already. > > Hi Luiz, we don't intend to switch use BASE over Capabilities, we just want to use both for broadcast. Capabilities for codec capabilities from preset that will be used in transport configuration. BASE is used for the over-the-air payload in Periodic Adv Data which is conformant to Table 3.15: Format of BASE used in Basic Audio Announcements from BAP Specification, also it is used for PTS testing that ask to modify the BASE structure. And we will copy the capabilities preset to the base structure to be sure we have the same codec capabilities in both of them. Not really following you here, if the Capabilities does contain the codec settings what does the BASE would have, having the same information twice sounds like a bad idea if this is where you are heading because it can cause inconsistencies and I'd like to maintain some symmetry with the unicast so the application have an easier time to set it up, even though we need to have some work on it for adapting to BASE format, but this should simplify for example use cases where the streaming goes from broadcast->unicast and vice-versa. Btw, we intend to have a release soon, so I hope we can pick up the pace here, so let me know if you want to sync-up offline. > > > > >> Claudia Draghicescu (2): > >> client/player: Use preset configuration in capabilities. Configure > >> BASE using separate structure > >> bap: Use the BASE structure received from upper layer > >> > >> client/player.c | 24 +++++++++++++++++------- > >> profiles/audio/bap.c | 13 ++++++++++--- > >> 2 files changed, 27 insertions(+), 10 deletions(-) > >> > >> > >> base-commit: 80107630396d3d3a3984c599e0cb9b015be0499c > >> -- > >> 2.34.1 > >> > > > > > >-- > >Luiz Augusto von Dentz
Use preset configuration in capabilities. Configure BASE using separate structure. Claudia Draghicescu (2): client/player: Use preset configuration in capabilities. Configure BASE using separate structure bap: Use the BASE structure received from upper layer client/player.c | 24 +++++++++++++++++------- profiles/audio/bap.c | 13 ++++++++++--- 2 files changed, 27 insertions(+), 10 deletions(-) base-commit: 80107630396d3d3a3984c599e0cb9b015be0499c