| Message ID | 20240408132241.750792-1-neeraj.sanjaykale@nxp.com |
|---|---|
| Headers | show |
| Series | Bluetooth: btnxpuart: Update firmware names | expand |
On 08/04/2024 15:22, Neeraj Sanjay Kale wrote: > This adds a new optional device tree property called firware-name. > > Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com> BTW, there is no such device as btnxpuart. Bindings are for hardware. With corrected subject: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > v2: Add maxItems, simplify description, remove "nxp/". (Krzysztof) > --- > .../devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml > index f01a3988538c..6774cc4d6a9e 100644 > --- a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml > +++ b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml > @@ -31,6 +31,11 @@ properties: > This property depends on the module vendor's > configuration. > > + firmware-name: > + maxItems: 1 > + description: > + Specify firmware file name. Drop description, redundant. You did not say anything different than property is saying already. Best regards, Krzysztof
Hi Krzysztof, Thank you for the review. I have made the changes you requested and sent out the v3 patch. Thanks, Neeraj > > On 08/04/2024 15:22, Neeraj Sanjay Kale wrote: > > This adds a new optional device tree property called firware-name. > > > > Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com> > > BTW, there is no such device as btnxpuart. Bindings are for hardware. > With corrected subject: > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > --- > > v2: Add maxItems, simplify description, remove "nxp/". (Krzysztof) > > --- > > .../devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git > > a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml > > b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml > > index f01a3988538c..6774cc4d6a9e 100644 > > --- > > a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml > > +++ b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.y > > +++ aml > > @@ -31,6 +31,11 @@ properties: > > This property depends on the module vendor's > > configuration. > > > > + firmware-name: > > + maxItems: 1 > > + description: > > + Specify firmware file name. > > Drop description, redundant. You did not say anything different than property > is saying already.
This patch series updates the BT firmware file names in BTNXPUART driver, and adds a new optional firmware-name device tree property to override the firmware file names hardcoded in the driver. This will allow user to continue using the older firmware files. This change is necessary as newer firmware releases will have standardized naming convention aligned across all newer and legacy chipsets. Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com> Neeraj Sanjay Kale (2): dt-bindings: net: bluetooth: btnxpuart: Add firmware-name property Bluetooth: btnxpuart: Update firmware names .../net/bluetooth/nxp,88w8987-bt.yaml | 6 ++++ drivers/bluetooth/btnxpuart.c | 28 +++++++++++-------- 2 files changed, 23 insertions(+), 11 deletions(-)