mbox series

[BlueZ,00/15] Fix a number of static analysis issues #2

Message ID 20240516090340.61417-1-hadess@hadess.net
Headers show
Series Fix a number of static analysis issues #2 | expand

Message

Bastien Nocera May 16, 2024, 9:03 a.m. UTC
"main: Simplify variable assignment" makes a come back, moving out the
single special-case out of the function.

For "shared/gatt-client: Fix uninitialised variable usage", please verify
that this default value is correct.

Happy to iterate on any patches you feel are suboptimal. Note that the
only patches that received any sort of real-world testing are the one
mentioned above and the gdbus one.

Cheers

Bastien Nocera (15):
  main: Simplify variable assignment
  shared/ecc: Fix uninitialised variable usage
  shared/gatt-client: Fix uninitialised variable usage
  tools/mesh-cfgclient: Fix uninitialised variable usage
  test-runner: Remove unused envp
  test-runner: Fix uninitialised variable usage
  test-runner: Fix uninitialised variable usage
  shared/bap: Fix possible use-after-free
  isotest: Fix bad free
  test-runner: Fix fd leak on failure
  isotest: Fix string size expectations
  mgmt-tester: Fix non-nul-terminated string
  gdbus: Check sprintf retval
  shared/bap: Fix memory leak in error path
  android/handsfree: Check sprintf retval

 android/handsfree.c      | 14 +++++++++---
 gdbus/watch.c            | 46 +++++++++++++++++++++++++++++-----------
 src/main.c               | 19 +++++++++--------
 src/shared/bap.c         | 19 ++++++++++++-----
 src/shared/ecc.c         |  2 ++
 src/shared/gatt-client.c |  2 +-
 tools/isotest.c          | 20 +++++++++++++----
 tools/mesh-cfgclient.c   |  3 +--
 tools/mgmt-tester.c      |  8 +++++--
 tools/test-runner.c      | 15 +++++++++----
 10 files changed, 106 insertions(+), 42 deletions(-)

Comments

patchwork-bot+bluetooth@kernel.org May 16, 2024, 8:50 p.m. UTC | #1
Hello:

This series was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Thu, 16 May 2024 11:03:04 +0200 you wrote:
> "main: Simplify variable assignment" makes a come back, moving out the
> single special-case out of the function.
> 
> For "shared/gatt-client: Fix uninitialised variable usage", please verify
> that this default value is correct.
> 
> Happy to iterate on any patches you feel are suboptimal. Note that the
> only patches that received any sort of real-world testing are the one
> mentioned above and the gdbus one.
> 
> [...]

Here is the summary with links:
  - [BlueZ,01/15] main: Simplify variable assignment
    (no matching commit)
  - [BlueZ,02/15] shared/ecc: Fix uninitialised variable usage
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=0a1159dc1055
  - [BlueZ,03/15] shared/gatt-client: Fix uninitialised variable usage
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=75eda690c4af
  - [BlueZ,04/15] tools/mesh-cfgclient: Fix uninitialised variable usage
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=c63b7b0d732e
  - [BlueZ,05/15] test-runner: Remove unused envp
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=9f4b2d0287ef
  - [BlueZ,06/15] test-runner: Fix uninitialised variable usage
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=0640d99ebfae
  - [BlueZ,07/15] test-runner: Fix uninitialised variable usage
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=9672cf410f8b
  - [BlueZ,08/15] shared/bap: Fix possible use-after-free
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=52336ad64548
  - [BlueZ,09/15] isotest: Fix bad free
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=7a6385570494
  - [BlueZ,10/15] test-runner: Fix fd leak on failure
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=566af9c2f5ef
  - [BlueZ,11/15] isotest: Fix string size expectations
    (no matching commit)
  - [BlueZ,12/15] mgmt-tester: Fix non-nul-terminated string
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=49d06560692f
  - [BlueZ,13/15] gdbus: Check sprintf retval
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=20a0255b9e5f
  - [BlueZ,14/15] shared/bap: Fix memory leak in error path
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=377f2ec0721f
  - [BlueZ,15/15] android/handsfree: Check sprintf retval
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=c9fe888793e5

You are awesome, thank you!
Bastien Nocera May 27, 2024, 8:23 a.m. UTC | #2
On Thu, 2024-05-16 at 20:50 +0000, patchwork-bot+bluetooth@kernel.org
wrote:
> Hello:
> 
> This series was applied to bluetooth/bluez.git (master)
> by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:
> 
> On Thu, 16 May 2024 11:03:04 +0200 you wrote:
> > "main: Simplify variable assignment" makes a come back, moving out
> > the
> > single special-case out of the function.
> > 
> > For "shared/gatt-client: Fix uninitialised variable usage", please
> > verify
> > that this default value is correct.
> > 
> > Happy to iterate on any patches you feel are suboptimal. Note that
> > the
> > only patches that received any sort of real-world testing are the
> > one
> > mentioned above and the gdbus one.
> > 
> > [...]
> 
> Here is the summary with links:
>   - [BlueZ,01/15] main: Simplify variable assignment
>     (no matching commit)

This one wasn't applied. I'll resubmit it separately with a better
commit message.

>   - [BlueZ,02/15] shared/ecc: Fix uninitialised variable usage
>    
> https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=0a1159dc1055
>   - [BlueZ,03/15] shared/gatt-client: Fix uninitialised variable
> usage
>    
> https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=75eda690c4af
>   - [BlueZ,04/15] tools/mesh-cfgclient: Fix uninitialised variable
> usage
>    
> https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=c63b7b0d732e
>   - [BlueZ,05/15] test-runner: Remove unused envp
>    
> https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=9f4b2d0287ef
>   - [BlueZ,06/15] test-runner: Fix uninitialised variable usage
>    
> https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=0640d99ebfae
>   - [BlueZ,07/15] test-runner: Fix uninitialised variable usage
>    
> https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=9672cf410f8b
>   - [BlueZ,08/15] shared/bap: Fix possible use-after-free
>    
> https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=52336ad64548
>   - [BlueZ,09/15] isotest: Fix bad free
>    
> https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=7a6385570494
>   - [BlueZ,10/15] test-runner: Fix fd leak on failure
>    
> https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=566af9c2f5ef
>   - [BlueZ,11/15] isotest: Fix string size expectations
>     (no matching commit)

Committed as:
https://git.kernel.org/pub/scm/bluetooth/bluez.git/commit/?id=f05e448cf81b6ff0a8c7fc1e3accdb4f436a46e0

>   - [BlueZ,12/15] mgmt-tester: Fix non-nul-terminated string
>    
> https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=49d06560692f
>   - [BlueZ,13/15] gdbus: Check sprintf retval
>    
> https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=20a0255b9e5f
>   - [BlueZ,14/15] shared/bap: Fix memory leak in error path
>    
> https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=377f2ec0721f
>   - [BlueZ,15/15] android/handsfree: Check sprintf retval
>    
> https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=c9fe888793e5
> 
> You are awesome, thank you!