Message ID | 20241127115107.11549-1-quic_janathot@quicinc.com |
---|---|
Headers | show |
Series | Enable Bluetooth on qcs6490-rb3gen2 board | expand |
On 27/11/2024 12:51, Janaki Ramaiah Thota wrote: > Add a PMU node for the WCN6750 module present on the qcs6490-rb3gen board > and use the power sequencer for the same. > > Signed-off-by: Janaki Ramaiah Thota <quic_janathot@quicinc.com> > --- > arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 174 ++++++++++++++++++- > drivers/bluetooth/hci_qca.c | 2 +- > drivers/power/sequencing/pwrseq-qcom-wcn.c | 22 +++ > 3 files changed, 196 insertions(+), 2 deletions(-) DTS is always separate and cannot go via the same (driver) tree, Missing bindings. Missing changelog, it's v4 so what happened here? Best regards, Krzysztof
On 11/27/2024 6:38 PM, Bartosz Golaszewski wrote: > On Wed, Nov 27, 2024 at 2:05 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: >> >> On 27/11/2024 12:51, Janaki Ramaiah Thota wrote: >>> Add a PMU node for the WCN6750 module present on the qcs6490-rb3gen board >>> and use the power sequencer for the same. >>> >>> Signed-off-by: Janaki Ramaiah Thota <quic_janathot@quicinc.com> >>> --- >>> arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 174 ++++++++++++++++++- >>> drivers/bluetooth/hci_qca.c | 2 +- >>> drivers/power/sequencing/pwrseq-qcom-wcn.c | 22 +++ >>> 3 files changed, 196 insertions(+), 2 deletions(-) >> >> DTS is always separate and cannot go via the same (driver) tree, >> >> Missing bindings. >> >> Missing changelog, it's v4 so what happened here? >> >> Best regards, >> Krzysztof > > Ah, so this is where the driver change is at. > > Janaki: the DT binding lives under the "regulator" namespace so it's > Mark Brown who typically takes changes to it via his tree. I pick up > driver changes into the pwrseq tree. Bjorn takes the DTS changes. Luiz > and Marcel are responsible for Bluetooth changes so you will have to > split all these changes into separate commits. > > Bart Thanks Bartosz, will split the patches and update. Regards, Janakiram
On Wed, Nov 27, 2024 at 05:21:07PM +0530, Janaki Ramaiah Thota wrote: > Add description of the PMU node for the WCN6750 module. > > Signed-off-by: Janaki Ramaiah Thota <quic_janathot@quicinc.com> > --- > .../bindings/regulator/qcom,qca6390-pmu.yaml | 27 +++++++++++++++++++ > 1 file changed, 27 insertions(+) Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- <form letter> This is an automated instruction, just in case, because many review tags are being ignored. If you know the process, you can skip it (please do not feel offended by me posting it here - no bad intentions intended). If you do not know the process, here is a short explanation: Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions, under or above your Signed-off-by tag. Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply. https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 </form letter> Best regards, Krzysztof