diff mbox series

[1/4] build: Always define confdir and statedir

Message ID 20220126113638.1706785-1-hadess@hadess.net
State New
Headers show
Series [1/4] build: Always define confdir and statedir | expand

Commit Message

Bastien Nocera Jan. 26, 2022, 11:36 a.m. UTC
As we will need those paths to lock down on them.
---
 Makefile.am | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Luiz Augusto von Dentz Jan. 31, 2022, 6:45 p.m. UTC | #1
Hi Bastien,

On Wed, Jan 26, 2022 at 1:28 PM <bluez.test.bot@gmail.com> wrote:
>
> This is automated email and please do not reply to this email!
>
> Dear submitter,
>
> Thank you for submitting the patches to the linux bluetooth mailing list.
> This is a CI test results with your patch series:
> PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=608628
>
> ---Test result---
>
> Test Summary:
> CheckPatch                    PASS      5.68 seconds
> GitLint                       PASS      3.84 seconds
> Prep - Setup ELL              PASS      41.84 seconds
> Build - Prep                  PASS      0.71 seconds
> Build - Configure             PASS      8.38 seconds
> Build - Make                  PASS      1292.67 seconds
> Make Check                    PASS      11.33 seconds
> Make Check w/Valgrind         PASS      448.95 seconds
> Make Distcheck                PASS      231.67 seconds
> Build w/ext ELL - Configure   PASS      8.74 seconds
> Build w/ext ELL - Make        PASS      1305.94 seconds
> Incremental Build with patchesPASS      5303.63 seconds
>
>
>
> ---
> Regards,
> Linux Bluetooth

Applied, thanks.
Bastien Nocera Feb. 1, 2022, 9:32 a.m. UTC | #2
On Wed, 2022-01-26 at 14:45 +0100, Bastien Nocera wrote:
> This change specifically? Check the next patches in the series, and
> you'll see pretty quickly.
> 
> For the rest of the patchset, check this man page for details on each
> of the directives:
> https://www.freedesktop.org/software/systemd/man/systemd.exec.html#Security
> 
> There's a fair amount of other directives we could use on top of
> those
> ones, but we can add them iteratively (and it makes bisecting easier,
> in case we forget about a particular use case).

Did you have any more questions about this patchset?
Luiz Augusto von Dentz April 12, 2022, 7:48 p.m. UTC | #3
Hi Bastien,

On Wed, Feb 2, 2022 at 5:55 AM Bastien Nocera <hadess@hadess.net> wrote:
>
> On Wed, 2022-01-26 at 14:45 +0100, Bastien Nocera wrote:
> > This change specifically? Check the next patches in the series, and
> > you'll see pretty quickly.
> >
> > For the rest of the patchset, check this man page for details on each
> > of the directives:
> > https://www.freedesktop.org/software/systemd/man/systemd.exec.html#Security
> >
> > There's a fair amount of other directives we could use on top of
> > those
> > ones, but we can add them iteratively (and it makes bisecting easier,
> > in case we forget about a particular use case).
>
> Did you have any more questions about this patchset?

Looks like we have some problems with these changes:

https://github.com/bluez/bluez/issues/329
diff mbox series

Patch

diff --git a/Makefile.am b/Makefile.am
index e391d7ae8..2ba25e687 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -28,14 +28,14 @@  AM_CFLAGS = $(MISC_CFLAGS) $(WARNING_CFLAGS) $(UDEV_CFLAGS) $(LIBEBOOK_CFLAGS) \
 				$(LIBEDATASERVER_CFLAGS) $(ell_cflags)
 AM_LDFLAGS = $(MISC_LDFLAGS)
 
+confdir = $(sysconfdir)/bluetooth
+statedir = $(localstatedir)/lib/bluetooth
+
 if DATAFILES
 dbusdir = $(DBUS_CONFDIR)/dbus-1/system.d
 dbus_DATA = src/bluetooth.conf
 
-confdir = $(sysconfdir)/bluetooth
 conf_DATA =
-
-statedir = $(localstatedir)/lib/bluetooth
 state_DATA =
 endif