From patchwork Fri Jun 7 14:12:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexey Romanov X-Patchwork-Id: 802410 Received: from mx1.sberdevices.ru (mx1.sberdevices.ru [37.18.73.165]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CA8C197538; Fri, 7 Jun 2024 14:19:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=37.18.73.165 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717769962; cv=none; b=l4YlKD0XAWMMXLokDGp3VprZnkGSAFn19gumzwWjWTiW0cXiqbBTC7Nz0IXzS527YEYJbrRGCxWo4dBPngPWDWiHeS1tpH6FBf4HZYPMgBL51Sin1Ljpso1YTRDEb4+QmpBRj1cdvfDCASjIoVeVf56cOlNe5pSfevYwGPvmtw8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717769962; c=relaxed/simple; bh=3nY2Cy4UVCe/UcpCHEJiNmU9ZT6ru7yq9enjSUnXRMk=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=ljy6K42KAKzmRylUiDaFgy9pC31elLPOB4xZr69bUnTHnfEnoPF+5rvMDpFzKsFZhmlcjkZPyjxm2QEZn0hIHCyM/T4Q8TlNwGPH9g5RSzGZXxpSstCCfm7v7haEkLXeOCsjo+8c1+qZkADfuTRKCyLMAq3PHZw50rpLqbBKzt4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=salutedevices.com; spf=pass smtp.mailfrom=salutedevices.com; dkim=pass (2048-bit key) header.d=salutedevices.com header.i=@salutedevices.com header.b=r4XFfguM; arc=none smtp.client-ip=37.18.73.165 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=salutedevices.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=salutedevices.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=salutedevices.com header.i=@salutedevices.com header.b="r4XFfguM" Received: from p-infra-ksmg-sc-msk01.sberdevices.ru (localhost [127.0.0.1]) by mx1.sberdevices.ru (Postfix) with ESMTP id A84E010002B; Fri, 7 Jun 2024 17:12:53 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.sberdevices.ru A84E010002B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=salutedevices.com; s=mail; t=1717769573; bh=PkYmcS94uxrfRhHcwPTkOdXtWdchfhhIykYruS9qLTc=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type:From; b=r4XFfguMKik82YFSKzRljj6Suoaa7CsmwKlUqphx34JF1s7XboSFmnjNfVx0Ok/OP rQXrzSfwMbHtCZpnzyfH2mkR9v5Ex/2DHCLcnbcnzEBscOwY+o8rtVJyIqU3g6wC1c r2EGSvNE0RY9kiQ6CHr1jv3EkH2EeGqJK6lHT1L3MxwEp3GXINuQIqbc5cb8r+V0Oh vla9G58QBP5Pi8Z0phlSTbo74ZPZGesbctiDDY1wr26siUWLck4KKOslmqQdKlpdAb 37Pz7UM28qCCFX2SMapsa34lYDfaY5y1rzYXzjErPUiwimFdBPTDtJ1OKUIgjhWSCc XhVFH7Tya54eA== Received: from smtp.sberdevices.ru (p-i-exch-sc-m02.sberdevices.ru [172.16.192.103]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.sberdevices.ru (Postfix) with ESMTPS; Fri, 7 Jun 2024 17:12:53 +0300 (MSK) Received: from user-A520M-DS3H.sberdevices.ru (100.64.160.123) by p-i-exch-sc-m02.sberdevices.ru (172.16.192.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Fri, 7 Jun 2024 17:12:52 +0300 From: Alexey Romanov To: , , , , , , , , , , CC: , , , , , , Alexey Romanov Subject: [PATCH v8 00/23] Support more Amlogic SoC families in crypto driver Date: Fri, 7 Jun 2024 17:12:19 +0300 Message-ID: <20240607141242.2616580-1-avromanov@salutedevices.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) To p-i-exch-sc-m02.sberdevices.ru (172.16.192.103) X-KSMG-Rule-ID: 10 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Lua-Profiles: 185803 [Jun 07 2024] X-KSMG-AntiSpam-Version: 6.1.0.4 X-KSMG-AntiSpam-Envelope-From: avromanov@salutedevices.com X-KSMG-AntiSpam-Rate: 0 X-KSMG-AntiSpam-Status: not_detected X-KSMG-AntiSpam-Method: none X-KSMG-AntiSpam-Auth: dkim=none X-KSMG-AntiSpam-Info: LuaCore: 20 0.3.20 743589a8af6ec90b529f2124c2bbfc3ce1d2f20f, {Tracking_uf_ne_domains}, {Tracking_from_domain_doesnt_match_to}, lore.kernel.org:7.1.1; 127.0.0.199:7.1.2; d41d8cd98f00b204e9800998ecf8427e.com:7.1.1; salutedevices.com:7.1.1; gist.github.com:7.1.1; smtp.sberdevices.ru:5.0.1,7.1.1; 100.64.160.123:7.1.2, FromAlignment: s, ApMailHostAddress: 100.64.160.123 X-MS-Exchange-Organization-SCL: -1 X-KSMG-AntiSpam-Interceptor-Info: scan successful X-KSMG-AntiPhishing: Clean, bases: 2024/06/07 13:43:00 X-KSMG-LinksScanning: Clean, bases: 2024/06/07 13:43:00 X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 2.0.1.6960, bases: 2024/06/07 12:12:00 #25491508 X-KSMG-AntiVirus-Status: Clean, skipped Hello! This patchset expand the funcionality of the Amlogic crypto driver by adding support for more SoC families: AXG, G12A, G12B, SM1, A1, S4. Also specify and enable crypto node in device tree for reference Amlogic devices. Tested on GXL, AXG, G12A/B, SM1, A1 and S4 devices via custom tests [1] and tcrypt module. --- Changes V1 -> V2 [2]: - Rebased over linux-next. - Adjusted device tree bindings description. - A1 and S4 dts use their own compatible, which is a G12 fallback. Changes V2 -> V3 [3]: - Fix errors in dt-bindings and device tree. - Add new field in platform data, which determines whether clock controller should be used for crypto IP. - Place back MODULE_DEVICE_TABLE. - Correct commit messages. Changes V3 -> V4 [4]: - Update dt-bindings as per Krzysztof Kozlowski comments. - Fix bisection: get rid of compiler errors in some patches. Changes V4 -> V5 [5]: - Tested on GXL board: 1. Fix panic detected by Corentin Labbe [6]. 2. Disable hasher backend for GXL: in its current realization is doesn't work. And there are no examples or docs in the vendor SDK. - Fix AES-CTR realization: legacy boards (gxl, g12, axg) requires inversion of the keyiv at keys setup stage. - A1 now uses its own compatible string. - S4 uses A1 compatible as fallback. - Code fixes based on comments Neil Atrmstrong and Rob Herring. - Style fixes (set correct indentations) Changes V5 -> V6 [7]: - Fix DMA sync warning reported by Corentin Labbe [8]. - Remove CLK input from driver. Remove clk definition and second interrput line from crypto node inside GXL dtsi. Changes V6 -> V7 [9]: - Fix dt-schema: power domain now required only for A1. - Use crypto_skcipher_ctx_dma() helper for cipher instead of ____cacheline_aligned. - Add import/export functions for hasher. - Fix commit message for patch 17, acorrding to discussion [10]. Changes V7 -> V8 [11]: - Test patchset with CONFIG_CRYPTO_MANAGER_EXTRA_TESTS: fix some bugs in hasher logic. - Use crypto crypto_ahash_ctx_dma in hasher code. - Correct clock definition: clk81 is required for all SoC's. - Add fixed-clock (clk81) definition for A1/S4. - Add information (in commit messages) why different compatibles are used. Links: - [1] https://gist.github.com/mRrvz/3fb8943a7487ab7b943ec140706995e7 - [2] https://lore.kernel.org/all/20240110201216.18016-1-avromanov@salutedevices.com/ - [3] https://lore.kernel.org/all/20240123165831.970023-1-avromanov@salutedevices.com/ - [4] https://lore.kernel.org/all/20240205155521.1795552-1-avromanov@salutedevices.com/ - [5] https://lore.kernel.org/all/20240212135108.549755-1-avromanov@salutedevices.com/ - [6] https://lore.kernel.org/all/ZcsYaPIUrBSg8iXu@Red/ - [7] https://lore.kernel.org/all/20240301132936.621238-1-avromanov@salutedevices.com/ - [8] https://lore.kernel.org/all/Zf1BAlYtiwPOG-Os@Red/ - [9] https://lore.kernel.org/all/20240326153219.2915080-1-avromanov@salutedevices.com/ - [10] https://lore.kernel.org/all/20240329-dotted-illusive-9f0593805a05@wendy/ - [11] https://lore.kernel.org/all/20240411133832.2896463-1-avromanov@salutedevices.com/ Alexey Romanov (23): drivers: crypto: meson: don't hardcode IRQ count drviers: crypto: meson: add platform data drivers: crypto: meson: remove clock input drivers: crypto: meson: add MMIO helpers drivers: crypto: meson: move get_engine_number() drivers: crypto: meson: drop status field from meson_flow drivers: crypto: meson: move algs definition and cipher API to cipher.c drivers: crypto: meson: cleanup defines drivers: crypto: meson: process more than MAXDESCS descriptors drivers: crypto: meson: avoid kzalloc in engine thread drivers: crypto: meson: introduce hasher drivers: crypto: meson: add support for AES-CTR drivers: crypto: meson: use fallback for 192-bit keys drivers: crypto: meson: add support for G12-series drivers: crypto: meson: add support for AXG-series drivers: crypto: meson: add support for A1-series dt-bindings: crypto: meson: correct clk and remove second interrupt line arch: arm64: dts: meson: gxl: correct crypto node definition dt-bindings: crypto: meson: support new SoC's arch: arm64: dts: meson: a1: add crypto node arch: arm64: dts: meson: s4: add crypto node arch: arm64: dts: meson: g12: add crypto node arch: arm64: dts: meson: axg: add crypto node .../bindings/crypto/amlogic,gxl-crypto.yaml | 33 +- arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 15 + arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 8 + .../boot/dts/amlogic/meson-g12-common.dtsi | 8 + arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 7 +- arch/arm64/boot/dts/amlogic/meson-s4.dtsi | 14 + drivers/crypto/amlogic/Makefile | 2 +- drivers/crypto/amlogic/amlogic-gxl-cipher.c | 632 ++++++++++++------ drivers/crypto/amlogic/amlogic-gxl-core.c | 292 ++++---- drivers/crypto/amlogic/amlogic-gxl-hasher.c | 507 ++++++++++++++ drivers/crypto/amlogic/amlogic-gxl.h | 118 +++- 11 files changed, 1277 insertions(+), 359 deletions(-) create mode 100644 drivers/crypto/amlogic/amlogic-gxl-hasher.c