| Message ID | cover.1625983602.git.christophe.jaillet@wanadoo.fr |
|---|---|
| Headers | show |
| Series | crypto: qat - Fixes and clean-ups | expand |
On Sun, Jul 11, 2021 at 08:13:18AM +0200, Christophe JAILLET wrote: > The wrappers in include/linux/pci-dma-compat.h should go away. > > Replace 'pci_set_dma_mask/pci_set_consistent_dma_mask' by an equivalent > and less verbose 'dma_set_mask_and_coherent()' call. > If needed, see post from Christoph Hellwig on the kernel-janitors ML: > https://marc.info/?l=kernel-janitors&m=158745678307186&w=4 See his another (recent) mail here: https://www.spinics.net/lists/kernel/msg3967232.html... > + if (dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64))) { > + if ((dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)))) { ...and drop this part from all entries completely. > + if (dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64))) { > + if ((dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)))) { > + if (dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64))) { > + if ((dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)))) { > + if (dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64))) { > + if ((dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)))) { > + if (dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64))) { > + if ((dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)))) { > + if (dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64))) { > + if ((dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)))) { > + if (dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64))) { > + if ((dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)))) { -- With Best Regards, Andy Shevchenko
On Sun, Jul 11, 2021 at 08:12:57AM +0200, Christophe JAILLET wrote: > The only link between these 3 patches are that they are all related to > 'drivers/crypto/qat'. Entire series looks good after addressing comment against patch 1. Feel free to add Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Christophe JAILLET (3): > crypto: qat - Simplify code and axe the use of a deprecated API > crypto: qat - Disable AER if an error occurs in probe functions > crypto: qat - Fix a typo in a comment > > drivers/crypto/qat/qat_4xxx/adf_drv.c | 8 ++------ > drivers/crypto/qat/qat_c3xxx/adf_drv.c | 15 ++++++--------- > drivers/crypto/qat/qat_c3xxxvf/adf_drv.c | 9 ++------- > drivers/crypto/qat/qat_c62x/adf_drv.c | 15 ++++++--------- > drivers/crypto/qat/qat_c62xvf/adf_drv.c | 9 ++------- > drivers/crypto/qat/qat_common/adf_aer.c | 2 +- > drivers/crypto/qat/qat_dh895xcc/adf_drv.c | 15 ++++++--------- > drivers/crypto/qat/qat_dh895xccvf/adf_drv.c | 9 ++------- > 8 files changed, 27 insertions(+), 55 deletions(-) > > -- > 2.30.2 > -- With Best Regards, Andy Shevchenko