From patchwork Thu Feb 4 11:09:44 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 376244 Delivered-To: patch@linaro.org Received: by 2002:a17:906:48d2:0:0:0:0 with SMTP id d18csp1188951ejt; Thu, 4 Feb 2021 03:12:26 -0800 (PST) X-Google-Smtp-Source: ABdhPJztHEYyZAnXhgfzHXQHarnEKrGjutBYd/re6aAXOmiRXLoUXIHJ5kJ53URq+gFd22S1ctZX X-Received: by 2002:aa7:dd49:: with SMTP id o9mr7356418edw.14.1612437146492; Thu, 04 Feb 2021 03:12:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612437146; cv=none; d=google.com; s=arc-20160816; b=NJhandpinwE3t8S9sfV8k99FBdzZGxpqz9+GNVJ8dmjanFRHZYMoc4vDpW0W0avSpb G6e9wbIkvHHhu2X1Y/Qlv14p5H7te6MiA3L8PMotzQ7x/j6drISuzxygIHNnlkPlK5G9 cQzXo7ZvGzP2+jP46TIOfHSXM4QZUSAS7V+/YCkaWYLxlyi7eUZ7F4BBHc3OTD1J6Jmh p6iLty9gl6Vd58z0bPg5H+Mbzb4W5YazI/CQt87+uImM4i0Jl7ZF+2LT9Dzq7NQ0DtNi GoEvI0TLToqhUKw+KIbw2unXBXQuF+Dsp66iYGAMb4II9WC7HrFWVol+exXnGVbuAqPz NcQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=UuJJvnBY1RT5AmJ5CEhkK6udrJuyZm280OjEkcYs/fQ=; b=JAty6SW3sL1TLv3n6br73Kxhz6/bKfoF7tRVoTbRr6RZA8ZnmER2M3ScsNu5pDwMGk +dRbrZbvOL+weDrRUj4X/S0uFLbwEV3spIV4jum6zFSnxTSFClVV46wQ6rHyps2r8/9o qXsIkmLZkABJ3n5q67cV05bVtJNGCeoG34x7ZPWgBCfy005mRrXiqHRPPN0rV/mH2DaG a1efu4PivLu2y1EW0Bjiz1bcXCdYswc/P/aT+NmRwC8yB981FwJ8QTCLXA/mtt691l1N WSXw+AEbDj6s43/xOVHj1f0Ll0uNUhvL6MpCatZTVES/CUO/UBOsuZ4gUygOAb8sRblr OkUg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=HCGu7dsD; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y25si3349293ejb.546.2021.02.04.03.12.26; Thu, 04 Feb 2021 03:12:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=HCGu7dsD; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235666AbhBDLLi (ORCPT + 2 others); Thu, 4 Feb 2021 06:11:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235623AbhBDLLe (ORCPT ); Thu, 4 Feb 2021 06:11:34 -0500 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD77DC061794 for ; Thu, 4 Feb 2021 03:10:09 -0800 (PST) Received: by mail-wr1-x432.google.com with SMTP id d16so2953732wro.11 for ; Thu, 04 Feb 2021 03:10:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=UuJJvnBY1RT5AmJ5CEhkK6udrJuyZm280OjEkcYs/fQ=; b=HCGu7dsDqG4pkWy8ockT5UO+pq22sAnePsOuQg+uVYtRaK/OQphQlcxTjFJIKCHuir SpaoujMIk8FfAnv860dMGKAMiz0SMmR2yvVwDsC2bDsUxkESYR3eHXOdw5nZ0imM/tqA 7CRrZkRe0JtqTUdogu7T5Rv0Xq1l+VGdsQ/oc4EuB+y3/wUbyZtxGwDrBRj8R6hzcWs2 BAa0cQt4IQpXG4rs7bdLaZqfVrp2l5TdHxqHkDRd7enoxlJgCDUh+PKWyAdZs186elSe yPaRNmsEb4r9Ihw3d6B9HW3+COwQVnGBWPb3eA+bXfKhYyLhDXGCWnTuhjxNnY8JUmlE w5ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=UuJJvnBY1RT5AmJ5CEhkK6udrJuyZm280OjEkcYs/fQ=; b=KSFoPBWkwByf8ZH68z4+R1e+FkeG80CgX9UGJ7AHaRiEzW/IgIrfPnVlcomaeCH3wT g34myTlaFN7YqhuPwWdGmwD+/8zXaPYNn02gPSrYhX3bhh4cXtbpACYzQ0CnNFSHmByW htWjYoU1E4BvuBxVb+lUXSRztZ3WoSA8j7GXVOYj5VMWoEW/AXvEpM+vdgfRyDr504m4 btwGxlANpQ48j6v0ORNbspRusmf+XYFrLec+OLtBuUk5kOz6Pq1rqrlEFpR00ktT1+DX PAbDxrMHK8Wm1yPTOn2mLl3ob2p/uxMiaWTNI0OkqXMmcooJYpnwYv5cCrctztLd4tTs J4HA== X-Gm-Message-State: AOAM530JdMjE39vgXxMYrDkRrcOFWlF8T5uKvogfQVGKoLVOBc4B2Bbz UVPRhJIfEOdDLLfOt/jVzietz9R7n8ryTQ== X-Received: by 2002:a05:6000:12c8:: with SMTP id l8mr8537957wrx.81.1612437008481; Thu, 04 Feb 2021 03:10:08 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id y18sm7696218wrt.19.2021.02.04.03.10.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Feb 2021 03:10:07 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Herbert Xu , "David S. Miller" , Shujuan Chen , Joakim Bech , Berne Hebark , Niklas Hernaeus , Andreas Westin , linux-crypto@vger.kernel.org Subject: [PATCH 04/20] crypto: ux500: hash: hash_core: Fix worthy kernel-doc headers and remove others Date: Thu, 4 Feb 2021 11:09:44 +0000 Message-Id: <20210204111000.2800436-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210204111000.2800436-1-lee.jones@linaro.org> References: <20210204111000.2800436-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org The ones remove here not only fail to conform to kernel-doc, but also provide no value, so let's remove them completely in this case. Fixes the following W=1 kernel build warning(s): drivers/crypto/ux500/hash/hash_core.c:368: warning: Function parameter or member 'ctx' not described in 'hash_get_device_data' drivers/crypto/ux500/hash/hash_core.c:368: warning: Excess function parameter 'hash_ctx' description in 'hash_get_device_data' drivers/crypto/ux500/hash/hash_core.c:551: warning: expecting prototype for hash_init(). Prototype was for ux500_hash_init() instead drivers/crypto/ux500/hash/hash_core.c:592: warning: Function parameter or member 'length' not described in 'hash_processblock' drivers/crypto/ux500/hash/hash_core.c:1302: warning: expecting prototype for hash_update(). Prototype was for ahash_update() instead drivers/crypto/ux500/hash/hash_core.c:1322: warning: expecting prototype for hash_final(). Prototype was for ahash_final() instead drivers/crypto/ux500/hash/hash_core.c:1622: warning: Function parameter or member 'device_data' not described in 'ahash_algs_register_all' drivers/crypto/ux500/hash/hash_core.c:1622: warning: expecting prototype for hash_algs_register_all(). Prototype was for ahash_algs_register_all() instead drivers/crypto/ux500/hash/hash_core.c:1647: warning: Function parameter or member 'device_data' not described in 'ahash_algs_unregister_all' drivers/crypto/ux500/hash/hash_core.c:1647: warning: expecting prototype for hash_algs_unregister_all(). Prototype was for ahash_algs_unregister_all() instead Cc: Herbert Xu Cc: "David S. Miller" Cc: Shujuan Chen Cc: Joakim Bech Cc: Berne Hebark Cc: Niklas Hernaeus Cc: Andreas Westin Cc: linux-crypto@vger.kernel.org Signed-off-by: Lee Jones --- drivers/crypto/ux500/hash/hash_core.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) -- 2.25.1 diff --git a/drivers/crypto/ux500/hash/hash_core.c b/drivers/crypto/ux500/hash/hash_core.c index da284b0ea1b26..bcaf6ba3e9235 100644 --- a/drivers/crypto/ux500/hash/hash_core.c +++ b/drivers/crypto/ux500/hash/hash_core.c @@ -356,7 +356,7 @@ static int hash_enable_power(struct hash_device_data *device_data, /** * hash_get_device_data - Checks for an available hash device and return it. - * @hash_ctx: Structure for the hash context. + * @ctx: Structure for the hash context. * @device_data: Structure for the hash device. * * This function check for an available hash device and return it to @@ -542,7 +542,7 @@ static bool hash_dma_valid_data(struct scatterlist *sg, int datasize) } /** - * hash_init - Common hash init function for SHA1/SHA2 (SHA256). + * ux500_hash_init - Common hash init function for SHA1/SHA2 (SHA256). * @req: The hash request for the job. * * Initialize structures. @@ -585,6 +585,7 @@ static int ux500_hash_init(struct ahash_request *req) * @device_data: Structure for the hash device. * @message: Block (512 bits) of message to be written to * the HASH hardware. + * @length: Message length * */ static void hash_processblock(struct hash_device_data *device_data, @@ -1295,7 +1296,7 @@ void hash_get_digest(struct hash_device_data *device_data, } /** - * hash_update - The hash update function for SHA1/SHA2 (SHA256). + * ahash_update - The hash update function for SHA1/SHA2 (SHA256). * @req: The hash request for the job. */ static int ahash_update(struct ahash_request *req) @@ -1315,7 +1316,7 @@ static int ahash_update(struct ahash_request *req) } /** - * hash_final - The hash final function for SHA1/SHA2 (SHA256). + * ahash_final - The hash final function for SHA1/SHA2 (SHA256). * @req: The hash request for the job. */ static int ahash_final(struct ahash_request *req) @@ -1615,9 +1616,6 @@ static struct hash_algo_template hash_algs[] = { } }; -/** - * hash_algs_register_all - - */ static int ahash_algs_register_all(struct hash_device_data *device_data) { int ret; @@ -1640,9 +1638,6 @@ static int ahash_algs_register_all(struct hash_device_data *device_data) return ret; } -/** - * hash_algs_unregister_all - - */ static void ahash_algs_unregister_all(struct hash_device_data *device_data) { int i;