| Message ID | 20250527071552.1424997-4-john.ernberg@actia.se |
|---|---|
| State | New |
| Headers | show |
| Series | crypto: caam - iMX8QXP support (and related fixes) | expand |
Hi Krzysztof, On Tue, May 27, 2025 at 09:19:22AM +0200, Krzysztof Kozlowski wrote: > On 27/05/2025 09:16, John Ernberg wrote: > > > > diff --git a/Documentation/devicetree/bindings/crypto/fsl,sec-v4.0.yaml b/Documentation/devicetree/bindings/crypto/fsl,sec-v4.0.yaml > > index 75afa441e019..a3c938eb553e 100644 > > --- a/Documentation/devicetree/bindings/crypto/fsl,sec-v4.0.yaml > > +++ b/Documentation/devicetree/bindings/crypto/fsl,sec-v4.0.yaml > > @@ -48,6 +48,9 @@ properties: > > - fsl,imx6ul-caam > > - fsl,sec-v5.0 > > - const: fsl,sec-v4.0 > > + - items: > > + - const: fsl,imx8qm-caam > > That's part of previous enum, no? > > > + - const: fsl,sec-v4.0 > > - const: fsl,sec-v4.0 > > > > reg: > > @@ -77,6 +80,9 @@ properties: > > interrupts: > > maxItems: 1 > > > > + power-domains: > > + maxItems: 1 > > + > > fsl,sec-era: > > description: Defines the 'ERA' of the SEC device. > > $ref: /schemas/types.yaml#/definitions/uint32 > > @@ -108,6 +114,9 @@ patternProperties: > > - items: > > - const: fsl,sec-v5.0-job-ring > > - const: fsl,sec-v4.0-job-ring > > + - items: > > + - const: fsl,imx8qm-job-ring > > Combine with previous entry into enum. > I think I managed to confuse myself around how compatible enums work first time around, thanks for prompting me to look again, I hopefully understand better now. Will take care of this for V3. Thanks! // John Ernberg
diff --git a/Documentation/devicetree/bindings/crypto/fsl,sec-v4.0.yaml b/Documentation/devicetree/bindings/crypto/fsl,sec-v4.0.yaml index 75afa441e019..a3c938eb553e 100644 --- a/Documentation/devicetree/bindings/crypto/fsl,sec-v4.0.yaml +++ b/Documentation/devicetree/bindings/crypto/fsl,sec-v4.0.yaml @@ -48,6 +48,9 @@ properties: - fsl,imx6ul-caam - fsl,sec-v5.0 - const: fsl,sec-v4.0 + - items: + - const: fsl,imx8qm-caam + - const: fsl,sec-v4.0 - const: fsl,sec-v4.0 reg: @@ -77,6 +80,9 @@ properties: interrupts: maxItems: 1 + power-domains: + maxItems: 1 + fsl,sec-era: description: Defines the 'ERA' of the SEC device. $ref: /schemas/types.yaml#/definitions/uint32 @@ -108,6 +114,9 @@ patternProperties: - items: - const: fsl,sec-v5.0-job-ring - const: fsl,sec-v4.0-job-ring + - items: + - const: fsl,imx8qm-job-ring + - const: fsl,sec-v4.0-job-ring - const: fsl,sec-v4.0-job-ring reg: @@ -116,6 +125,9 @@ patternProperties: interrupts: maxItems: 1 + power-domains: + maxItems: 1 + fsl,liodn: description: Specifies the LIODN to be used in conjunction with the ppid-to-liodn @@ -126,6 +138,18 @@ patternProperties: items: - maximum: 0xfff + if: + properties: + compatible: + contains: + const: fsl,imx8qm-job-ring + then: + required: + - power-domains + else: + properties: + power-domains: false + '^rtic@[0-9a-f]+$': type: object additionalProperties: false @@ -212,6 +236,18 @@ required: - reg - ranges +if: + properties: + compatible: + contains: + const: fsl,imx8qm-caam +then: + required: + - power-domains +else: + properties: + power-domains: false + additionalProperties: false examples:
NXP SoCs like the iMX8QM, iMX8QXP or iMX8DXP use power domains for resource management. Allow specifying them for such SoCs. Signed-off-by: John Ernberg <john.ernberg@actia.se> --- v2: - Adjust commit message (Frank Li) - Only allow power-domains when compatible with imx8qm (Frank Li) --- .../bindings/crypto/fsl,sec-v4.0.yaml | 36 +++++++++++++++++++ 1 file changed, 36 insertions(+)