| Message ID | 20250609045110.1786634-6-h.jain@amd.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add Versal TRNG driver | expand |
On 09/06/2025 06:51, Harsh Jain wrote: > Add goto to clean up allocated cipher on reseed failure. > > Reported-by: kernel test robot <lkp@intel.com> > Reported-by: Dan Carpenter <dan.carpenter@linaro.org> > Closes: https://lore.kernel.org/r/202505311325.22fIOcCt-lkp@intel.com/ Please stop adding bugs and fixing them afterwards. Fix your patch first. Best regards, Krzysztof
[AMD Official Use Only - AMD Internal Distribution Only] > -----Original Message----- > From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: Tuesday, June 10, 2025 11:48 AM > To: Jain, Harsh (AECG-SSW) <h.jain@amd.com>; herbert@gondor.apana.org.au; > davem@davemloft.net; linux-crypto@vger.kernel.org; devicetree@vger.kernel.org; > Botcha, Mounika <Mounika.Botcha@amd.com>; Savitala, Sarat Chand > <sarat.chand.savitala@amd.com>; Dhanawade, Mohan > <mohan.dhanawade@amd.com>; Simek, Michal <michal.simek@amd.com> > Cc: kernel test robot <lkp@intel.com>; Dan Carpenter <dan.carpenter@linaro.org> > Subject: Re: [PATCH v2 5/6] crypto: xilinx: Fix missing goto in probe > > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > On 09/06/2025 06:51, Harsh Jain wrote: > > Add goto to clean up allocated cipher on reseed failure. > > > > Reported-by: kernel test robot <lkp@intel.com> > > Reported-by: Dan Carpenter <dan.carpenter@linaro.org> > > Closes: https://lore.kernel.org/r/202505311325.22fIOcCt-lkp@intel.com/ > > Please stop adding bugs and fixing them afterwards. Fix your patch first. Hi Kozlowski, After squashing this fix, Do I need to add "Reported-by, Closes" tag in original patch? Thanks > > > > Best regards, > Krzysztof
On Tue, Jun 10, 2025 at 06:28:22AM +0000, Jain, Harsh (AECG-SSW) wrote: > [AMD Official Use Only - AMD Internal Distribution Only] > > > -----Original Message----- > > From: Krzysztof Kozlowski <krzk@kernel.org> > > Sent: Tuesday, June 10, 2025 11:48 AM > > To: Jain, Harsh (AECG-SSW) <h.jain@amd.com>; herbert@gondor.apana.org.au; > > davem@davemloft.net; linux-crypto@vger.kernel.org; devicetree@vger.kernel.org; > > Botcha, Mounika <Mounika.Botcha@amd.com>; Savitala, Sarat Chand > > <sarat.chand.savitala@amd.com>; Dhanawade, Mohan > > <mohan.dhanawade@amd.com>; Simek, Michal <michal.simek@amd.com> > > Cc: kernel test robot <lkp@intel.com>; Dan Carpenter <dan.carpenter@linaro.org> > > Subject: Re: [PATCH v2 5/6] crypto: xilinx: Fix missing goto in probe > > > > Caution: This message originated from an External Source. Use proper caution > > when opening attachments, clicking links, or responding. > > > > > > On 09/06/2025 06:51, Harsh Jain wrote: > > > Add goto to clean up allocated cipher on reseed failure. > > > > > > Reported-by: kernel test robot <lkp@intel.com> > > > Reported-by: Dan Carpenter <dan.carpenter@linaro.org> > > > Closes: https://lore.kernel.org/r/202505311325.22fIOcCt-lkp@intel.com/ > > > > Please stop adding bugs and fixing them afterwards. Fix your patch first. > > Hi Kozlowski, > > After squashing this fix, Do I need to add "Reported-by, Closes" tag in original patch? > Nope. regards, dan carpenter
diff --git a/drivers/crypto/xilinx/xilinx-trng.c b/drivers/crypto/xilinx/xilinx-trng.c index adaf69c58647..8ec0f83b53f1 100644 --- a/drivers/crypto/xilinx/xilinx-trng.c +++ b/drivers/crypto/xilinx/xilinx-trng.c @@ -365,7 +365,7 @@ static int xtrng_probe(struct platform_device *pdev) ret = xtrng_reseed_internal(rng); if (ret) { dev_err(&pdev->dev, "TRNG Seed fail\n"); - return ret; + goto cipher_cleanup; } xilinx_rng_dev = rng;
Add goto to clean up allocated cipher on reseed failure. Reported-by: kernel test robot <lkp@intel.com> Reported-by: Dan Carpenter <dan.carpenter@linaro.org> Closes: https://lore.kernel.org/r/202505311325.22fIOcCt-lkp@intel.com/ Signed-off-by: Harsh Jain <h.jain@amd.com> --- drivers/crypto/xilinx/xilinx-trng.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)