[v2,0/3] support gce on mt8192 platform

Change since v1:
- move out shit jump patch
- rmove usless patch

Yongqiang Niu (3):
  dt-binding: gce: add gce header file for mt8192
  arm64: dts: mt8192: add gce node
  mailbox: cmdq: add mt8192 support

 .../devicetree/bindings/mailbox/mtk-gce.txt        |   7 +-
 arch/arm64/boot/dts/mediatek/mt8192.dtsi           |  10 +
 drivers/mailbox/mtk-cmdq-mailbox.c                 |   1 +
 include/dt-bindings/gce/mt8192-gce.h               | 419 +++++++++++++++++++++
 4 files changed, 434 insertions(+), 3 deletions(-)
 create mode 100644 include/dt-bindings/gce/mt8192-gce.h

Hi, Yongqiang:

Yongqiang Niu <yongqiang.niu@mediatek.com> 於 2020年12月24日 週四 上午8:55寫道：
>
> add mt8192 support
>
> Signed-off-by: Yongqiang Niu <yongqiang.niu@mediatek.com>
> ---
>  drivers/mailbox/mtk-cmdq-mailbox.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c
> index 75378e3..7f243e1 100644
> --- a/drivers/mailbox/mtk-cmdq-mailbox.c
> +++ b/drivers/mailbox/mtk-cmdq-mailbox.c
> @@ -607,6 +607,7 @@ static int cmdq_probe(struct platform_device *pdev)
>         {.compatible = "mediatek,mt8173-gce", .data = (void *)&gce_plat_v2},
>         {.compatible = "mediatek,mt8183-gce", .data = (void *)&gce_plat_v3},
>         {.compatible = "mediatek,mt6779-gce", .data = (void *)&gce_plat_v4},
> +       {.compatible = "mediatek,mt8192-gce", .data = (void *)&gce_plat_v4},

In the view of hardware function, is mt8192-gce identical to
mt6779-gce? If these two are identical, you need not to modify driver,
and the compatible should be

compatible = "mediatek,mt8192-gce", "mediatek,mt6779-gce";

If they are not identical, what's the different?

Regards,
Chun-Kuang.

>         {}
>  };
>
> --
> 1.8.1.1.dirty
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek

On Thu, 2020-12-24 at 22:28 +0800, Chun-Kuang Hu wrote:
> Hi, Yongqiang:

> 

> Yongqiang Niu <yongqiang.niu@mediatek.com> 於 2020年12月24日 週四 上午8:55寫道：

> >

> > add mt8192 support

> >

> > Signed-off-by: Yongqiang Niu <yongqiang.niu@mediatek.com>

> > ---

> >  drivers/mailbox/mtk-cmdq-mailbox.c | 1 +

> >  1 file changed, 1 insertion(+)

> >

> > diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c

> > index 75378e3..7f243e1 100644

> > --- a/drivers/mailbox/mtk-cmdq-mailbox.c

> > +++ b/drivers/mailbox/mtk-cmdq-mailbox.c

> > @@ -607,6 +607,7 @@ static int cmdq_probe(struct platform_device *pdev)

> >         {.compatible = "mediatek,mt8173-gce", .data = (void *)&gce_plat_v2},

> >         {.compatible = "mediatek,mt8183-gce", .data = (void *)&gce_plat_v3},

> >         {.compatible = "mediatek,mt6779-gce", .data = (void *)&gce_plat_v4},

> > +       {.compatible = "mediatek,mt8192-gce", .data = (void *)&gce_plat_v4},

> 

> In the view of hardware function, is mt8192-gce identical to

> mt6779-gce? If these two are identical, you need not to modify driver,

> and the compatible should be

> 

> compatible = "mediatek,mt8192-gce", "mediatek,mt6779-gce";

> 

> If they are not identical, what's the different?

> 

> Regards,

> Chun-Kuang.


irq id is different 
mt8192 dts
https://patchwork.kernel.org/project/linux-mediatek/patch/1608770889-9403-3-git-send-email-yongqiang.niu@mediatek.com/

mt6779 dts
https://patchwork.kernel.org/project/linux-mediatek/patch/1574327552-11806-6-git-send-email-dennis-yc.hsieh@mediatek.com/

and gce event id also different
https://patchwork.kernel.org/project/linux-mediatek/patch/1608770889-9403-2-git-send-email-yongqiang.niu@mediatek.com/

https://patchwork.kernel.org/project/linux-mediatek/patch/1574327552-11806-2-git-send-email-dennis-yc.hsieh@mediatek.com/


> 

> >         {}

> >  };

> >

> > --

> > 1.8.1.1.dirty

> > _______________________________________________

> > Linux-mediatek mailing list

> > Linux-mediatek@lists.infradead.org

> > http://lists.infradead.org/mailman/listinfo/linux-mediatek

On Thu, 24 Dec 2020 08:48:07 +0800, Yongqiang Niu wrote:
> Add documentation for the mt8192 gce.
> 
> Add gce header file defined the gce hardware event,
> subsys number and constant for mt8192.
> 
> Signed-off-by: Yongqiang Niu <yongqiang.niu@mediatek.com>
> ---
>  .../devicetree/bindings/mailbox/mtk-gce.txt        |   7 +-
>  include/dt-bindings/gce/mt8192-gce.h               | 419 +++++++++++++++++++++
>  2 files changed, 423 insertions(+), 3 deletions(-)
>  create mode 100644 include/dt-bindings/gce/mt8192-gce.h
> 

Reviewed-by: Rob Herring <robh@kernel.org>