| Message ID | 1620197726-23802-1-git-send-email-skakit@codeaurora.org |
|---|---|
| Headers | show |
| Series | Add PMIC DT files for sc7280 | expand |
On Wed, May 05, 2021 at 12:25:20PM +0530, satya priya wrote: > Add thermal-zones node for SC7280 SoC. > > Signed-off-by: satya priya <skakit@codeaurora.org> The patch won't be needed after 'arm64: dts: qcom: SC7280: Add thermal zone support' (https://patchwork.kernel.org/project/linux-arm-msm/patch/1619778592-8112-4-git-send-email-rkambl@codeaurora.org/) lands, but looks good for now. Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
On Wed, May 05, 2021 at 12:25:25PM +0530, satya priya wrote: > Subject: arm64: dts: qcom: sc7280: Add channel nodes for sc7280-idp nit: just 'channel nodes' is a bit vague. In case you respin maybe change it to something like 'Add ADC channel nodes for PMIC temperatures to sc7280-idp' In any case it doesn't seem worth to respin just for this. > > Add channel nodes for the on die temperatures of PMICS > pmk8350, pm8350, pmr735a and pmr735b. > > Signed-off-by: satya priya <skakit@codeaurora.org> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
On 2021-05-05 20:27, Matthias Kaehlcke wrote: > On Wed, May 05, 2021 at 12:25:26PM +0530, satya priya wrote: >> The sc7280-idp has four PMICs, include their .dtsi files. >> >> Signed-off-by: satya priya <skakit@codeaurora.org> >> --- >> arch/arm64/boot/dts/qcom/sc7280-idp.dts | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dts >> b/arch/arm64/boot/dts/qcom/sc7280-idp.dts >> index 02a14fc..704fb9a 100644 >> --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dts >> +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dts >> @@ -12,6 +12,10 @@ >> #include <dt-bindings/iio/qcom,spmi-adc7-pm8350.h> >> #include <dt-bindings/iio/qcom,spmi-adc7-pmk8350.h> >> #include "sc7280.dtsi" >> +#include "pm7325.dtsi" >> +#include "pmr735a.dtsi" >> +#include "pm8350c.dtsi" >> +#include "pmk8350.dtsi" > > Patch '[7/8] arm64: dts: qcom: sc7280: Add channel nodes for > sc7280-idp' > of this series makes use of the label 'pmk8350_vadc', which doesn't > exist > at that point. > > A series should be organized in a way that applying only a > subset of the series (in order, starting with patch 1) doesn't > cause any build or runtime issues. To achieve this patch [7/8] > and [8/8] of this series need to be swapped. Okay, I will re-arrange the series and resend v4. Thanks, Satya Priya
Changes in V2: - As per Matthias comments: - I've Split the patch into per-PMIC patches and one sc7280 patch - Removed 2nd critical point, thermal-governer property - s/pm8325_tz/pm7325_temp_alarm and s/pm7325_temp_alarm/pm7325_thermal - Fixed few other minor errors. - As per Bjorn's comments, replaced '_' with '-' in node names and moved DT files inclusion to board dts. Changes in V3: - As per Matthias comments, changed commit text, modified critical interrupt node name like <name>-crit for all pmics. - Moved pmk8350_vadc channel nodes to idp dts, as it is not guaranteed that a board with the pmk8350 will always have the other 3 PMICs Changes in V4: - PMR735A and PM8350C PMICS are used in sm8350 SoC. Added thermal_zones label for thermal-zones node to avoid compilation error while using the phandle in pmic dt files. - As per Matthias comments: - Changed commit text for pmk8350 pmic patch - Moved the header files inclusion for the on die tempertures of PMICs from pmk8350 dt file to sc7280-idp dts - Changed commit text and made a dedicated patch to include pmic dt files for sc7280-idp - Made separate patches for on die temp channel nodes and for adding thermal- zones node in sc7280 SoC dtsi satya priya (8): arm64: dts: qcom: sm8350: Add label for thermal-zones node arm64: dts: qcom: sc7280: Add thermal-zones node arm64: dts: qcom: pm7325: Add pm7325 base dts file arm64: dts: qcom: pm8350c: Add temp-alarm support arm64: dts: qcom: pmr735a: Add temp-alarm support arm64: dts: qcom: pmk8350: Add peripherals for pmk8350 arm64: dts: qcom: sc7280: Add channel nodes for sc7280-idp arm64: dts: qcom: sc7280: Include PMIC DT files for sc7280-idp arch/arm64/boot/dts/qcom/pm7325.dtsi | 53 +++++++++++++++++++++++++++++++++ arch/arm64/boot/dts/qcom/pm8350c.dtsi | 32 +++++++++++++++++++- arch/arm64/boot/dts/qcom/pmk8350.dtsi | 51 ++++++++++++++++++++++++++++++- arch/arm64/boot/dts/qcom/pmr735a.dtsi | 32 +++++++++++++++++++- arch/arm64/boot/dts/qcom/sc7280-idp.dts | 34 +++++++++++++++++++++ arch/arm64/boot/dts/qcom/sc7280.dtsi | 3 ++ arch/arm64/boot/dts/qcom/sm8350.dtsi | 2 +- 7 files changed, 203 insertions(+), 4 deletions(-) create mode 100644 arch/arm64/boot/dts/qcom/pm7325.dtsi