mbox series

[v8,0/4] Add SPMI support for Mediatek MT6873/8192 SoC IC

Message ID 1622025344-31888-1-git-send-email-hsin-hsiung.wang@mediatek.com
Headers show
Series Add SPMI support for Mediatek MT6873/8192 SoC IC | expand

Message

Hsin-Hsiung Wang May 26, 2021, 10:35 a.m. UTC 
This series adds support for new SoC MT6873/8192 to the spmi driver.
This series is based on Chun-Jie's patches[1].

[1] https://patchwork.kernel.org/project/linux-mediatek/list/?series=488239

changes since v7:
- rebase to Linux 5.13.

Hsin-Hsiung Wang (4):
  dt-bindings: spmi: modify the constraint 'maxItems' to 'minItems'
  dt-bindings: spmi: document binding for the Mediatek SPMI controller
  spmi: mediatek: Add support for MT6873/8192
  arm64: dts: mt8192: add spmi node

 .../bindings/spmi/mtk,spmi-mtk-pmif.yaml           |  74 ++++
 Documentation/devicetree/bindings/spmi/spmi.yaml   |   2 +-
 arch/arm64/boot/dts/mediatek/mt8192.dtsi           |  17 +
 drivers/spmi/Kconfig                               |  10 +
 drivers/spmi/Makefile                              |   2 +
 drivers/spmi/spmi-mtk-pmif.c                       | 465 +++++++++++++++++++++
 6 files changed, 569 insertions(+), 1 deletion(-)
 create mode 100644 Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.yaml
 create mode 100644 drivers/spmi/spmi-mtk-pmif.c

Comments

Rob Herring (Arm) May 26, 2021, 12:56 p.m. UTC | #1 
On Wed, 26 May 2021 18:35:42 +0800, Hsin-Hsiung Wang wrote:
> This adds documentation for the SPMI controller found on Mediatek SoCs.
> 
> Signed-off-by: Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com>
> ---
> changes since v7:
> - no change.
> ---
>  .../bindings/spmi/mtk,spmi-mtk-pmif.yaml           | 74 ++++++++++++++++++++++
>  1 file changed, 74 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.example.dts:19:18: fatal error: dt-bindings/clock/mt8192-clk.h: No such file or directory
   19 |         #include <dt-bindings/clock/mt8192-clk.h>
      |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[1]: *** [scripts/Makefile.lib:380: Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.example.dt.yaml] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1416: dt_binding_check] Error 2

See https://patchwork.ozlabs.org/patch/1483989

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.
Hsin-Hsiung Wang May 27, 2021, 1:29 a.m. UTC | #2 
Hi,

On Wed, 2021-05-26 at 07:56 -0500, Rob Herring wrote:
> On Wed, 26 May 2021 18:35:42 +0800, Hsin-Hsiung Wang wrote:

> > This adds documentation for the SPMI controller found on Mediatek SoCs.

> > 

> > Signed-off-by: Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com>

> > ---

> > changes since v7:

> > - no change.

> > ---

> >  .../bindings/spmi/mtk,spmi-mtk-pmif.yaml           | 74 ++++++++++++++++++++++

> >  1 file changed, 74 insertions(+)

> >  create mode 100644 Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.yaml

> > 

> 

> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'

> on your patch (DT_CHECKER_FLAGS is new in v5.13):

> 

> yamllint warnings/errors:

> 

> dtschema/dtc warnings/errors:

> Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.example.dts:19:18: fatal error: dt-bindings/clock/mt8192-clk.h: No such file or directory

>    19 |         #include <dt-bindings/clock/mt8192-clk.h>

>       |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

> compilation terminated.

> make[1]: *** [scripts/Makefile.lib:380: Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.example.dt.yaml] Error 1

> make[1]: *** Waiting for unfinished jobs....

> make: *** [Makefile:1416: dt_binding_check] Error 2

> 

> See https://patchwork.ozlabs.org/patch/1483989

> 

> This check can fail if there are any dependencies. The base for a patch

> series is generally the most recent rc1.

> 

> If you already ran 'make dt_binding_check' and didn't see the above

> error(s), then make sure 'yamllint' is installed and dt-schema is up to

> date:

> 

> pip3 install dtschema --upgrade

> 

> Please check and re-submit.

> 


Thanks. for the review.
This series is based on Chun-Jie's patches[1].

[1]
https://patchwork.kernel.org/project/linux-mediatek/list/?series=488239