mbox series

[V2,0/2] Add Vol+ support for sc7280-idp

Message ID 1630574106-3394-1-git-send-email-skakit@codeaurora.org
Headers show
Series Add Vol+ support for sc7280-idp | expand

Message

Satya Priya Sept. 2, 2021, 9:15 a.m. UTC 
David Collins (1):
  pinctrl: qcom: spmi-gpio: correct parent irqspec translation

satya priya (1):
  arm64: dts: sc7280: Add volume up support for sc7280-idp

 arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 31 ++++++++++++++++++++++++++
 drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 37 +++++++++++++++++++++++++++++---
 2 files changed, 65 insertions(+), 3 deletions(-)

Comments

Stephen Boyd Sept. 3, 2021, 6:12 p.m. UTC | #1 
Quoting satya priya (2021-09-02 02:15:06)
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> index 371a2a9..52bcbbc 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> @@ -199,6 +199,37 @@
>         modem-init;
>  };
>
> +&soc {

's' comes after 'p' so this is in the wrong place.

> +       gpio_keys {
> +               compatible = "gpio-keys";
> +               label = "gpio-keys";
> +
> +               pinctrl-names = "default";
> +               pinctrl-0 = <&key_vol_up_default>;
> +
> +               vol_up {
> +                       label = "volume_up";
> +                       gpios = <&pm7325_gpios 6 GPIO_ACTIVE_LOW>;
> +                       linux,input-type = <1>;
> +                       linux,code = <KEY_VOLUMEUP>;
> +                       gpio-key,wakeup;
> +                       debounce-interval = <15>;
> +                       linux,can-disable;
> +               };
> +       };
> +};
> +
> +&pm7325_gpios {
> +       key_vol_up_default: key_vol_up_default {

Please move this to the "PINCTRL - additions to nodes defined in
sc7280.dtsi" section and then sort alphabetically on node naem.

> +               pins = "gpio6";
> +               function = "normal";
> +               input-enable;
> +               bias-pull-up;
> +               power-source = <0>;
> +               qcom,drive-strength = <3>;
> +       };
> +};
> +
>  &pmk8350_vadc {
>         pmk8350_die_temp {
>                 reg = <PMK8350_ADC7_DIE_TEMP>;
Satya Priya Sept. 6, 2021, 10:58 a.m. UTC | #2 
On 2021-09-03 23:42, Stephen Boyd wrote:
> Quoting satya priya (2021-09-02 02:15:06)

>> diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi 

>> b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi

>> index 371a2a9..52bcbbc 100644

>> --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi

>> +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi

>> @@ -199,6 +199,37 @@

>>         modem-init;

>>  };

>> 

>> +&soc {

> 

> 's' comes after 'p' so this is in the wrong place.

> 


Okay will move it accordingly.

>> +       gpio_keys {

>> +               compatible = "gpio-keys";

>> +               label = "gpio-keys";

>> +

>> +               pinctrl-names = "default";

>> +               pinctrl-0 = <&key_vol_up_default>;

>> +

>> +               vol_up {

>> +                       label = "volume_up";

>> +                       gpios = <&pm7325_gpios 6 GPIO_ACTIVE_LOW>;

>> +                       linux,input-type = <1>;

>> +                       linux,code = <KEY_VOLUMEUP>;

>> +                       gpio-key,wakeup;

>> +                       debounce-interval = <15>;

>> +                       linux,can-disable;

>> +               };

>> +       };

>> +};

>> +

>> +&pm7325_gpios {

>> +       key_vol_up_default: key_vol_up_default {

> 

> Please move this to the "PINCTRL - additions to nodes defined in

> sc7280.dtsi" section and then sort alphabetically on node naem.

> 


Okay.

>> +               pins = "gpio6";

>> +               function = "normal";

>> +               input-enable;

>> +               bias-pull-up;

>> +               power-source = <0>;

>> +               qcom,drive-strength = <3>;

>> +       };

>> +};

>> +

>>  &pmk8350_vadc {

>>         pmk8350_die_temp {

>>                 reg = <PMK8350_ADC7_DIE_TEMP>;