mbox series

[v3,0/6] Add DW PCIe support for Exynos5433 SoCs

Message ID 20201029134017.27400-1-m.szyprowski@samsung.com
Headers show
Series Add DW PCIe support for Exynos5433 SoCs | expand

Message

Marek Szyprowski Oct. 29, 2020, 1:40 p.m. UTC 
Dear All,

This patchset is a resurrection of the DW PCIe support for the Exynos5433
SoCs posted long time ago here: https://lkml.org/lkml/2016/12/26/6 and
later here: https://lkml.org/lkml/2017/12/21/296 .

In meantime the support for the Exynos5440 SoCs has been completely
dropped from mainline kernel, as those SoCs never reached the market. The
PCIe driver for Exynos5440 variant however has not been removed yet. This
patchset simply reworks it to support the Exynos5433 variant. The lack of
the need to support both variants significantly simplifies the driver
code.

This patchset is based on the following branch:
git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git pci-more-dwc-cleanup

Best regards,
Marek Szyprowski


Changelog:

v3:
- rebased onto "[00/13] PCI: dwc: Another round of clean-ups" patchset:
  https://patchwork.kernel.org/project/linux-samsung-soc/cover/20201028204646.356535-1-robh@kernel.org/
- fixed issues pointed by Rob in the driver logic:
  * removed DBI_RO_WR_EN register poking
  * made driver a standard module
- fixed section mismatch issue
- added "num-viewport = <3>" property to dts and bindings to fix warning

v2: https://lore.kernel.org/linux-samsung-soc/20201023075744.26200-1-m.szyprowski@samsung.com/
- fixed issues in dt-bindings pointed by Krzysztof and Rob

v1: https://lore.kernel.org/linux-samsung-soc/20201019094715.15343-1-m.szyprowski@samsung.com/
- initial version of this resurrected patchset


Patch summary:

Jaehoon Chung (3):
  phy: samsung: phy-exynos-pcie: rework driver to support Exynos5433
    PCIe PHY
  pci: dwc: pci-exynos: rework the driver to support Exynos5433 variant
  arm64: dts: exynos: add the WiFi/PCIe support to TM2(e) boards

Marek Szyprowski (3):
  dt-bindings: pci: drop samsung,exynos5440-pcie binding
  dt-bindings: pci: add the samsung,exynos-pcie binding
  dt-bindings: phy: add the samsung,exynos-pcie-phy binding

 .../bindings/pci/samsung,exynos-pcie.yaml     | 119 ++++++
 .../bindings/pci/samsung,exynos5440-pcie.txt  |  58 ---
 .../bindings/phy/samsung,exynos-pcie-phy.yaml |  51 +++
 .../boot/dts/exynos/exynos5433-pinctrl.dtsi   |   2 +-
 .../dts/exynos/exynos5433-tm2-common.dtsi     |  24 +-
 arch/arm64/boot/dts/exynos/exynos5433.dtsi    |  36 ++
 drivers/pci/controller/dwc/Kconfig            |  10 +-
 drivers/pci/controller/dwc/pci-exynos.c       | 353 +++++++-----------
 drivers/pci/quirks.c                          |   1 +
 drivers/phy/samsung/phy-exynos-pcie.c         | 304 ++++++---------
 10 files changed, 489 insertions(+), 469 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/pci/samsung,exynos-pcie.yaml
 delete mode 100644 Documentation/devicetree/bindings/pci/samsung,exynos5440-pcie.txt
 create mode 100644 Documentation/devicetree/bindings/phy/samsung,exynos-pcie-phy.yaml

Comments

Han Jingoo Oct. 29, 2020, 9:59 p.m. UTC | #1 
On 10/29/20, 9:41 AM, Marek Szyprowski wrote:
> 
> From: Jaehoon Chung <jh80.chung@samsung.com>
>
> Exynos5440 SoC support has been dropped since commit 8c83315da1cf ("ARM:
> dts: exynos: Remove Exynos5440"). Rework this driver to support DWC PCIe
> variant found in the Exynos5433 SoCs.
>
> The main difference in Exynos5433 variant is lack of the MSI support
> (the MSI interrupt is not even routed to the CPU).
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> [mszyprow: reworked the driver to support only Exynos5433 variant,
>	   simplified code, rebased onto current kernel code, added
>	   regulator support, converted to the regular platform driver,
>	   removed MSI related code, rewrote commit message, added help]
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Acked-by: Krzysztof Kozlowski <krzk@kernel.org>

Acked-by: Jingoo Han <jingoohan1@gmail.com>

Best regards,
Jingoo Han

> ---
>  drivers/pci/controller/dwc/Kconfig      |  10 +-
>  drivers/pci/controller/dwc/pci-exynos.c | 353 ++++++++++--------------
>  drivers/pci/quirks.c                    |   1 +
>  3 files changed, 147 insertions(+), 217 deletions(-)

[...]
Bjorn Helgaas Nov. 3, 2020, 10:44 p.m. UTC | #2 
On Thu, Oct 29, 2020 at 02:40:11PM +0100, Marek Szyprowski wrote:
> Dear All,
> 
> This patchset is a resurrection of the DW PCIe support for the Exynos5433
> SoCs posted long time ago here: https://lkml.org/lkml/2016/12/26/6 and
> later here: https://lkml.org/lkml/2017/12/21/296 .
> 
> In meantime the support for the Exynos5440 SoCs has been completely
> dropped from mainline kernel, as those SoCs never reached the market. The
> PCIe driver for Exynos5440 variant however has not been removed yet. This
> patchset simply reworks it to support the Exynos5433 variant. The lack of
> the need to support both variants significantly simplifies the driver
> code.
> 
> This patchset is based on the following branch:
> git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git pci-more-dwc-cleanup
> 
> Best regards,
> Marek Szyprowski
> 
> 
> Changelog:
> 
> v3:
> - rebased onto "[00/13] PCI: dwc: Another round of clean-ups" patchset:
>   https://patchwork.kernel.org/project/linux-samsung-soc/cover/20201028204646.356535-1-robh@kernel.org/
> - fixed issues pointed by Rob in the driver logic:
>   * removed DBI_RO_WR_EN register poking
>   * made driver a standard module
> - fixed section mismatch issue
> - added "num-viewport = <3>" property to dts and bindings to fix warning
> 
> v2: https://lore.kernel.org/linux-samsung-soc/20201023075744.26200-1-m.szyprowski@samsung.com/
> - fixed issues in dt-bindings pointed by Krzysztof and Rob
> 
> v1: https://lore.kernel.org/linux-samsung-soc/20201019094715.15343-1-m.szyprowski@samsung.com/
> - initial version of this resurrected patchset
> 
> 
> Patch summary:

Please follow the subject line convention:

  PCI: exynos: Rework to support Exynos5433 variant
  arm64: dts: exynos: Add WiFi/PCIe support to TM2(e) boards
  dt-bindings: PCI: exynos: Drop samsung,exynos5440-pcie binding
  dt-bindings: PCI: exynos: Add samsung,exynos-pcie binding
  dt-bindings: phy: exynos: Add samsung,exynos-pcie-phy binding

You can save this trouble by running "git log --oneline" on the file
(or directory, for new files) and copying the style.

> Jaehoon Chung (3):
>   phy: samsung: phy-exynos-pcie: rework driver to support Exynos5433
>     PCIe PHY
>   pci: dwc: pci-exynos: rework the driver to support Exynos5433 variant
>   arm64: dts: exynos: add the WiFi/PCIe support to TM2(e) boards
> 
> Marek Szyprowski (3):
>   dt-bindings: pci: drop samsung,exynos5440-pcie binding
>   dt-bindings: pci: add the samsung,exynos-pcie binding
>   dt-bindings: phy: add the samsung,exynos-pcie-phy binding
> 
>  .../bindings/pci/samsung,exynos-pcie.yaml     | 119 ++++++
>  .../bindings/pci/samsung,exynos5440-pcie.txt  |  58 ---
>  .../bindings/phy/samsung,exynos-pcie-phy.yaml |  51 +++
>  .../boot/dts/exynos/exynos5433-pinctrl.dtsi   |   2 +-
>  .../dts/exynos/exynos5433-tm2-common.dtsi     |  24 +-
>  arch/arm64/boot/dts/exynos/exynos5433.dtsi    |  36 ++
>  drivers/pci/controller/dwc/Kconfig            |  10 +-
>  drivers/pci/controller/dwc/pci-exynos.c       | 353 +++++++-----------
>  drivers/pci/quirks.c                          |   1 +
>  drivers/phy/samsung/phy-exynos-pcie.c         | 304 ++++++---------
>  10 files changed, 489 insertions(+), 469 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/pci/samsung,exynos-pcie.yaml
>  delete mode 100644 Documentation/devicetree/bindings/pci/samsung,exynos5440-pcie.txt
>  create mode 100644 Documentation/devicetree/bindings/phy/samsung,exynos-pcie-phy.yaml
> 
> -- 
> 2.17.1
>