mbox series

[v2,0/6] Add Ethernet interface description for Odroid boards

Message ID 20201103184412.18874-1-l.stelmach@samsung.com
Headers show
Series Add Ethernet interface description for Odroid boards | expand

Message

Lukasz Stelmach Nov. 3, 2020, 6:44 p.m. UTC 
Add devicetree description of Ethernet devices on Odroid boards. These
descriptions enable setting MAC addresses with a bootloader.

Changes in v2:
  - fixed compatible for hub@1 on X/X2 (: -> ,)
  - split the patch for Odroid XU3 into two
  - explained the purpose of aliases in commit messages

Łukasz Stelmach (6):
  ARM: dts: exynos: Fix Ethernet interface description for Odroid XU3
  ARM: dts: exynos: Add an alias for the Ethernet interface on Odroid XU3
  ARM: dts: exynos: Add Ethernet interface description for Odroid XU3 Lite
  ARM: dts: exynos: Add Ethernet interface description for Odroid XU
  ARM: dts: exynos: Add Ethernet interface description for Odroid U3
  ARM: dts: exynos: Add Ethernet interface description for Odroid X/X2

 arch/arm/boot/dts/exynos4412-odroidu3.dts     | 12 ++++++++
 arch/arm/boot/dts/exynos4412-odroidx.dts      | 28 +++++++++++++++++++
 arch/arm/boot/dts/exynos5410-odroidxu.dts     | 15 ++++++++++
 .../boot/dts/exynos5422-odroidxu3-lite.dts    | 22 +++++++++++++++
 arch/arm/boot/dts/exynos5422-odroidxu3.dts    |  8 ++++--
 5 files changed, 83 insertions(+), 2 deletions(-)

Comments

Krzysztof Kozlowski Nov. 5, 2020, 7:22 p.m. UTC | #1 
On Tue, Nov 03, 2020 at 07:44:07PM +0100, Łukasz Stelmach wrote:
> Assign appropriate compatible properties.
> 
> Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>

This and #2 will have to wait till I figure out what happened my
previous pull request. I'll keep it in my queue.

Best regards,
Krzysztof
Krzysztof Kozlowski Nov. 5, 2020, 7:23 p.m. UTC | #2 
On Tue, Nov 03, 2020 at 07:44:09PM +0100, Łukasz Stelmach wrote:
> Add Ethernet interface description for Odroid XU3 Lite.
> 
> Add an alias to enable bootloaders to find the Ethernet
> interface and assign a MAC address.
> 
> Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
> ---
>  .../boot/dts/exynos5422-odroidxu3-lite.dts    | 22 +++++++++++++++++++

Thanks, applied.

Best regards,
Krzysztof
Krzysztof Kozlowski Nov. 5, 2020, 7:30 p.m. UTC | #3 
On Tue, Nov 03, 2020 at 07:44:12PM +0100, Łukasz Stelmach wrote:
> Add Ethernet interface description for Odroid X/X2.

> 

> Add an alias to enable bootloaders to find the Ethernet

> interface and assign a MAC address.

> 

> Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>

> ---

>  arch/arm/boot/dts/exynos4412-odroidx.dts | 28 ++++++++++++++++++++++++

>  1 file changed, 28 insertions(+)

> 

> diff --git a/arch/arm/boot/dts/exynos4412-odroidx.dts b/arch/arm/boot/dts/exynos4412-odroidx.dts

> index 3ea2a0101e80..2da220102883 100644

> --- a/arch/arm/boot/dts/exynos4412-odroidx.dts

> +++ b/arch/arm/boot/dts/exynos4412-odroidx.dts

> @@ -15,6 +15,10 @@ / {

>  	model = "Hardkernel ODROID-X board based on Exynos4412";

>  	compatible = "hardkernel,odroid-x", "samsung,exynos4412", "samsung,exynos4";

>  

> +	aliases {

> +		ethernet = &ethernet;

> +	};

> +

>  	memory@40000000 {

>  		device_type = "memory";

>  		reg = <0x40000000 0x3FF00000>;

> @@ -72,8 +76,32 @@ &buck8_reg {

>  };

>  

>  &ehci {

> +	#address-cells = <1>;

> +	#size-cells = <0>;

>  	phys = <&exynos_usbphy 2>;

>  	phy-names = "hsic0";

> +

> +	hub@2 {

> +		compatible = "usb0424,3503";

> +		reg = <2>;

> +		#address-cells = <1>;

> +		#size-cells = <0>;

> +

> +		hub@1 {

> +			compatible = "usb0424,9514";

> +			reg = <1>;

> +			#address-cells = <1>;

> +			#size-cells = <0>;

> +

> +			ethernet: usbether@1 {

> +				compatible = "usb0424,ec00";

> +				reg = <1>;

> +				local-mac-address = [00 00 00 00 00 00]; /* Filled in by a bootloader */

> +			};

> +		};

> +	};

> +

> +


Thanks, applied with space fixup.

Best regards,
Krzysztof