mbox series

[v3,0/4] gpio: visconti: Add Toshiba Visconti GPIO support

Message ID 20201201181406.2371881-1-nobuhiro1.iwamatsu@toshiba.co.jp
Headers show
Series gpio: visconti: Add Toshiba Visconti GPIO support | expand

Message

Nobuhiro Iwamatsu Dec. 1, 2020, 6:14 p.m. UTC
Hi,

This series is the GPIO driver for Toshiba's ARM SoC, Visconti[0].
This provides DT binding documentation, device driver, MAINTAINER files, and updates to DT files.

Update:

  dt-bindings: gpio: Add bindings for Toshiba Visconti GPIO Controller:
    v2 -> v3: Fix dtschema/dtc warnings.
      dtschema/dtc warnings/errors:
        Documentation/devicetree/bindings/gpio/toshiba,gpio-visconti.example.dt.yaml: gpio@28020000: interrupts: [[0, 24, 4], [0, 25, 4], [0, 26, 4], [0, 27, 4], [0, 28, 4], [0, 29, 4], [0, 30, 4], [0, 31, 4], [0, 32, 4], [0, 33, 4], [0, 34, 4], [0, 35, 4], [0, 36, 4], [0, 37, 4], [0, 38, 4], [0, 39, 4]] is too short
	  From schema: Documentation/devicetree/bindings/gpio/toshiba,gpio-visconti.yaml
    v1 -> v2: Fix typo.

  gpio: visoconti: Add Toshiba Visconti GPIO support:
    v2 -> v3: Add select GPIO_GENERIC
              Use genric MMIO GPIO library
              Use bgpio_init() as initialized the generic helpers.
              Use irqchip template instead of gpiochip_irqchip_add().
    v1 -> v2: No update

  MAINTAINERS: Add entries for Toshiba Visconti GPIO controller:
    v2 -> v3: No update
    v1 -> v2: No update

  arm: dts: visconti: Add DT support for Toshiba Visconti5 GPIO driver:
    v2 -> v3: Fix compatible string.
    v1 -> v2: No update

Best regards,
  Nobuhiro

[0]: https://toshiba.semicon-storage.com/ap-en/semiconductor/product/image-recognition-processors-visconti.html

Nobuhiro Iwamatsu (4):
  dt-bindings: gpio: Add bindings for Toshiba Visconti GPIO Controller
  gpio: visconti: Add Toshiba Visconti GPIO support
  MAINTAINERS: Add entries for Toshiba Visconti GPIO controller
  arm: dts: visconti: Add DT support for Toshiba Visconti5 GPIO driver

 .../bindings/gpio/toshiba,gpio-visconti.yaml  |  85 +++++++
 MAINTAINERS                                   |   2 +
 .../boot/dts/toshiba/tmpv7708-rm-mbrc.dts     |   4 +
 arch/arm64/boot/dts/toshiba/tmpv7708.dtsi     |  27 ++
 drivers/gpio/Kconfig                          |   9 +
 drivers/gpio/Makefile                         |   1 +
 drivers/gpio/gpio-visconti.c                  | 232 ++++++++++++++++++
 drivers/pinctrl/visconti/pinctrl-common.c     |  23 ++
 8 files changed, 383 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/gpio/toshiba,gpio-visconti.yaml
 create mode 100644 drivers/gpio/gpio-visconti.c

Comments

Bartosz Golaszewski Jan. 6, 2021, 10:33 a.m. UTC | #1
On Tue, Dec 1, 2020 at 10:16 AM Nobuhiro Iwamatsu
<nobuhiro1.iwamatsu@toshiba.co.jp> wrote:
>
> Hi,
>
> This series is the GPIO driver for Toshiba's ARM SoC, Visconti[0].
> This provides DT binding documentation, device driver, MAINTAINER files, and updates to DT files.
>
> Update:
>
>   dt-bindings: gpio: Add bindings for Toshiba Visconti GPIO Controller:
>     v2 -> v3: Fix dtschema/dtc warnings.
>       dtschema/dtc warnings/errors:
>         Documentation/devicetree/bindings/gpio/toshiba,gpio-visconti.example.dt.yaml: gpio@28020000: interrupts: [[0, 24, 4], [0, 25, 4], [0, 26, 4], [0, 27, 4], [0, 28, 4], [0, 29, 4], [0, 30, 4], [0, 31, 4], [0, 32, 4], [0, 33, 4], [0, 34, 4], [0, 35, 4], [0, 36, 4], [0, 37, 4], [0, 38, 4], [0, 39, 4]] is too short
>           From schema: Documentation/devicetree/bindings/gpio/toshiba,gpio-visconti.yaml
>     v1 -> v2: Fix typo.
>
>   gpio: visoconti: Add Toshiba Visconti GPIO support:
>     v2 -> v3: Add select GPIO_GENERIC
>               Use genric MMIO GPIO library
>               Use bgpio_init() as initialized the generic helpers.
>               Use irqchip template instead of gpiochip_irqchip_add().
>     v1 -> v2: No update
>
>   MAINTAINERS: Add entries for Toshiba Visconti GPIO controller:
>     v2 -> v3: No update
>     v1 -> v2: No update
>
>   arm: dts: visconti: Add DT support for Toshiba Visconti5 GPIO driver:
>     v2 -> v3: Fix compatible string.
>     v1 -> v2: No update
>
> Best regards,
>   Nobuhiro
>

Nobuhiro,

In the future please use the get_maintainers.pl script - I have never
been Cc'ed on this series and I would have ignored it if Linus W
hadn't brought it to my attention.

Bartosz
Nobuhiro Iwamatsu Jan. 7, 2021, 12:33 a.m. UTC | #2
Hi Bartosz,

On Wed, Jan 06, 2021 at 11:33:49AM +0100, Bartosz Golaszewski wrote:
> On Tue, Dec 1, 2020 at 10:16 AM Nobuhiro Iwamatsu

> <nobuhiro1.iwamatsu@toshiba.co.jp> wrote:

> >

> > Hi,

> >

> > This series is the GPIO driver for Toshiba's ARM SoC, Visconti[0].

> > This provides DT binding documentation, device driver, MAINTAINER files, and updates to DT files.

> >

> > Update:

> >

> >   dt-bindings: gpio: Add bindings for Toshiba Visconti GPIO Controller:

> >     v2 -> v3: Fix dtschema/dtc warnings.

> >       dtschema/dtc warnings/errors:

> >         Documentation/devicetree/bindings/gpio/toshiba,gpio-visconti.example.dt.yaml: gpio@28020000: interrupts: [[0, 24, 4], [0, 25, 4], [0, 26, 4], [0, 27, 4], [0, 28, 4], [0, 29, 4], [0, 30, 4], [0, 31, 4], [0, 32, 4], [0, 33, 4], [0, 34, 4], [0, 35, 4], [0, 36, 4], [0, 37, 4], [0, 38, 4], [0, 39, 4]] is too short

> >           From schema: Documentation/devicetree/bindings/gpio/toshiba,gpio-visconti.yaml

> >     v1 -> v2: Fix typo.

> >

> >   gpio: visoconti: Add Toshiba Visconti GPIO support:

> >     v2 -> v3: Add select GPIO_GENERIC

> >               Use genric MMIO GPIO library

> >               Use bgpio_init() as initialized the generic helpers.

> >               Use irqchip template instead of gpiochip_irqchip_add().

> >     v1 -> v2: No update

> >

> >   MAINTAINERS: Add entries for Toshiba Visconti GPIO controller:

> >     v2 -> v3: No update

> >     v1 -> v2: No update

> >

> >   arm: dts: visconti: Add DT support for Toshiba Visconti5 GPIO driver:

> >     v2 -> v3: Fix compatible string.

> >     v1 -> v2: No update

> >

> > Best regards,

> >   Nobuhiro

> >

> 

> Nobuhiro,

> 

> In the future please use the get_maintainers.pl script - I have never

> been Cc'ed on this series and I would have ignored it if Linus W

> hadn't brought it to my attention.

> 


Sorry, I'll use it next time.

Best regards,
  Nobuhiro