| Message ID | 20210115104047.3460-1-jackp@codeaurora.org |
|---|---|
| Headers | show |
| Series | SM8350 USB and dt-bindings updates | expand |
On 15-01-21, 12:54, Konrad Dybcio wrote: > Hi, > > > I might be wrong but it looks as if you forgot to add a compatible for the "sm8350_usb3_uniphy_cfg" configuration. It seems to be documented in patch 2, ideally we should have the bindings patches first and this as patch 3... > > > Konrad
On Fri, Jan 15, 2021 at 12:54:26PM +0100, Konrad Dybcio wrote: > I might be wrong but it looks as if you forgot to add a compatible for > the "sm8350_usb3_uniphy_cfg" configuration. Not wrong at all! My mistake, will add it in v2. Thanks, Jack
Hi Vinod, On Fri, Jan 15, 2021 at 06:17:36PM +0530, Vinod Koul wrote: > On 15-01-21, 12:54, Konrad Dybcio wrote: > > I might be wrong but it looks as if you forgot to add a compatible > > for the "sm8350_usb3_uniphy_cfg" configuration. I believe Konrad was referring to the driver in which I had neglected to add the compatible to the qcom_qmp_phy_of_match_table. My mistake. > It seems to be documented in patch 2, ideally we should have the > bindings patches first and this as patch 3... Ok. I think driver change would be patch 2 rather, with the bindings in patch 1? Patch 3 and 4 are dt-bindings updates to the SNPS Femto PHY and DWC3 QCOM docs respectively. Will send v2, thanks. Jack
This series adds support for the SM8350 USB PHY to the QMP PHY driver as well as adds the documentation for the QMP, SNPS PHY and DWC3 controller bindings. This also adds the bindings for SM8150 and SM8250 to the same docs which had not been added previously even though they are in use now. Jack Pham (4): phy: qcom-qmp: Add SM8350 USB QMP PHYs dt-bindings: phy: qcom,qmp: Add SM8150, SM8250 and SM8350 USB PHY bindings dt-bindings: phy: qcom,usb-snps-femto-v2: Add SM8250 and SM8350 bindings dt-bindings: usb: qcom,dwc3: Add bindings for SM8150, SM8250, SM8350 .../devicetree/bindings/phy/qcom,qmp-phy.yaml | 67 ++++++ .../bindings/phy/qcom,usb-snps-femto-v2.yaml | 2 + .../devicetree/bindings/usb/qcom,dwc3.yaml | 3 + drivers/phy/qualcomm/phy-qcom-qmp.c | 209 ++++++++++++++++++ drivers/phy/qualcomm/phy-qcom-qmp.h | 100 +++++++++ 5 files changed, 381 insertions(+)