| Message ID | 20210210162954.3955785-1-nobuhiro1.iwamatsu@toshiba.co.jp |
|---|---|
| Headers | show |
| Series | net: stmmac: Add Toshiba Visconti SoCs glue driver | expand |
From: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp> Date: Thu, 11 Feb 2021 01:29:52 +0900 > +static int visconti_eth_init_hw(struct platform_device *pdev, struct plat_stmmacenet_data *plat_dat) > +{ > + struct visconti_eth *dwmac; > + unsigned int reg_val, clk_sel_val; Please use reverse christmas tree ordering for local variable declarations. > +static int visconti_eth_clock_probe(struct platform_device *pdev, > + struct plat_stmmacenet_data *plat_dat) > +{ > + int err; > + struct visconti_eth *dwmac; Likewise. > +static int visconti_eth_clock_remove(struct platform_device *pdev) > +{ > + struct net_device *ndev = platform_get_drvdata(pdev); > + struct stmmac_priv *priv = netdev_priv(ndev); > + struct visconti_eth *dwmac = get_stmmac_bsp_priv(&pdev->dev); Likewise. Thanks.
Hi, Thanks for your comment. On Thu, Feb 11, 2021 at 02:13:07PM -0800, David Miller wrote: > From: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp> > Date: Thu, 11 Feb 2021 01:29:52 +0900 > > > +static int visconti_eth_init_hw(struct platform_device *pdev, struct plat_stmmacenet_data *plat_dat) > > +{ > > + struct visconti_eth *dwmac; > > + unsigned int reg_val, clk_sel_val; > > Please use reverse christmas tree ordering for local variable declarations. > > > +static int visconti_eth_clock_probe(struct platform_device *pdev, > > + struct plat_stmmacenet_data *plat_dat) > > +{ > > + int err; > > + struct visconti_eth *dwmac; > > Likewise. > > > +static int visconti_eth_clock_remove(struct platform_device *pdev) > > +{ > > + struct net_device *ndev = platform_get_drvdata(pdev); > > + struct stmmac_priv *priv = netdev_priv(ndev); > > + struct visconti_eth *dwmac = get_stmmac_bsp_priv(&pdev->dev); > Likewise. > OK, I will fix these. Best regards, Nobuhiro
Hi, This series is the ethernet driver for Toshiba's ARM SoC, Visconti[0]. This provides DT binding documentation, device driver, MAINTAINER files, and updates to DT files. Best regards, Nobuhiro [0]: https://toshiba.semicon-storage.com/ap-en/semiconductor/product/image-recognition-processors-visconti.htmli Nobuhiro Iwamatsu (4): dt-bindings: net: Add DT bindings for Toshiba Visconti TMPV7700 SoC net: stmmac: Add Toshiba Visconti SoCs glue driver MAINTAINERS: Add entries for Toshiba Visconti ethernet controller arm: dts: visconti: Add DT support for Toshiba Visconti5 ethernet controller .../bindings/net/toshiba,visconti-dwmac.yaml | 87 ++++++ MAINTAINERS | 2 + .../boot/dts/toshiba/tmpv7708-rm-mbrc.dts | 18 ++ arch/arm64/boot/dts/toshiba/tmpv7708.dtsi | 24 ++ drivers/net/ethernet/stmicro/stmmac/Kconfig | 8 + drivers/net/ethernet/stmicro/stmmac/Makefile | 1 + .../ethernet/stmicro/stmmac/dwmac-visconti.c | 292 ++++++++++++++++++ 7 files changed, 432 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/toshiba,visconti-dwmac.yaml create mode 100644 drivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c