| Message ID | 20210301080401.22190-1-o.rempel@pengutronix.de |
|---|---|
| Headers | show |
| Series | add support for GPIO or IRQ based event counter | expand |
On Mon, Mar 01, 2021 at 09:04:00AM +0100, Oleksij Rempel wrote: > Add binding for the interrupt counter node > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Acked-by: William Breathitt Gray <vilhelm.gray@gmail.com> > --- > .../bindings/counter/interrupt-counter.yaml | 62 +++++++++++++++++++ > 1 file changed, 62 insertions(+) > create mode 100644 Documentation/devicetree/bindings/counter/interrupt-counter.yaml > > diff --git a/Documentation/devicetree/bindings/counter/interrupt-counter.yaml b/Documentation/devicetree/bindings/counter/interrupt-counter.yaml > new file mode 100644 > index 000000000000..fd075d104631 > --- /dev/null > +++ b/Documentation/devicetree/bindings/counter/interrupt-counter.yaml > @@ -0,0 +1,62 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/counter/interrupt-counter.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Interrupt counter > + > +maintainers: > + - Oleksij Rempel <o.rempel@pengutronix.de> > + > +description: | > + A generic interrupt counter to measure interrupt frequency. It was developed > + and used for agricultural devices to measure rotation speed of wheels or > + other tools. Since the direction of rotation is not important, only one > + signal line is needed. > + Interrupts or gpios are required. If both are defined, the interrupt will > + take precedence for counting interrupts. > + > +properties: > + compatible: > + const: interrupt-counter > + > + interrupts: > + maxItems: 1 > + > + gpios: > + maxItems: 1 > + > +required: > + - compatible > + > +anyOf: > + - required: [ interrupts-extended ] > + - required: [ interrupts ] > + - required: [ gpios ] > + > +additionalProperties: false > + > +examples: > + - | > + > + #include <dt-bindings/interrupt-controller/irq.h> > + #include <dt-bindings/gpio/gpio.h> > + > + counter-0 { > + compatible = "interrupt-counter"; > + interrupts-extended = <&gpio 0 IRQ_TYPE_EDGE_RISING>; > + }; > + > + counter-1 { > + compatible = "interrupt-counter"; > + gpios = <&gpio 2 GPIO_ACTIVE_HIGH>; > + }; > + > + counter-2 { > + compatible = "interrupt-counter"; > + interrupts-extended = <&gpio 2 IRQ_TYPE_EDGE_RISING>; > + gpios = <&gpio 2 GPIO_ACTIVE_HIGH>; > + }; > + > +... > -- > 2.29.2 >
On Mon, 01 Mar 2021 09:04:00 +0100, Oleksij Rempel wrote: > Add binding for the interrupt counter node > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > --- > .../bindings/counter/interrupt-counter.yaml | 62 +++++++++++++++++++ > 1 file changed, 62 insertions(+) > create mode 100644 Documentation/devicetree/bindings/counter/interrupt-counter.yaml > Reviewed-by: Rob Herring <robh@kernel.org>
On Mon, 1 Mar 2021 09:03:59 +0100 Oleksij Rempel <o.rempel@pengutronix.de> wrote: > changes v8: > - use use enum index instead of enum value for the counter function > - register signal unconditionally and return error is signal revel is > read > > changes v7: > - make most of structs dynamically allocatable to assign IRQ based > description to the signal > - assign dev name instead for driver name to the IRQ > > changes v6: > - rename it to interrupt-counter > - driver fixes > - device tree fixes > > changes v5: > - rename it to event counter, since it support different event sources > - make it work with gpio-only or irq-only configuration > - update yaml binding > > changes v4: > - use IRQ_NOAUTOEN to not enable IRQ by default > - rename gpio_ from name pattern and make this driver work any IRQ > source. > > changes v3: > - convert counter to atomic_t > > changes v2: > - add commas > - avoid possible unhandled interrupts in the enable path > - do not use of_ specific gpio functions > > Add support for GPIO based pulse counter. For now it can only count > pulses. With counter char device support, we will be able to attach > timestamps and measure actual pulse frequency. > > Never the less, it is better to mainline this driver now (before chardev > patches go mainline), to provide developers additional use case for the counter > framework with chardev support. > > Oleksij Rempel (2): > dt-bindings: counter: add interrupt-counter binding > counter: add IRQ or GPIO based counter Series applied to the togreg branch of iio.git and pushed out as testing. thanks, Jonathan > > .../bindings/counter/interrupt-counter.yaml | 62 +++++ > MAINTAINERS | 7 + > drivers/counter/Kconfig | 10 + > drivers/counter/Makefile | 1 + > drivers/counter/interrupt-cnt.c | 244 ++++++++++++++++++ > 5 files changed, 324 insertions(+) > create mode 100644 Documentation/devicetree/bindings/counter/interrupt-counter.yaml > create mode 100644 drivers/counter/interrupt-cnt.c >