mbox series

[v4,0/7] phy: qcom-qmp: provide DP phy support for sm8250

Message ID 20210326175809.2923789-1-dmitry.baryshkov@linaro.org
Headers show
Series phy: qcom-qmp: provide DP phy support for sm8250 | expand

Message

Dmitry Baryshkov March 26, 2021, 5:58 p.m. UTC 
Changes since v3:
 - Move qcom,sc7180-qmp-usb3-phy and qcom,sdm845-qmp-usb3-phy from
   qcom,qmp-usb3-dp.yaml to qcom,qmp-phy.yaml
 - Do not touch qcom,sm8250-qmp-usb3-phy compatible

Changes since v2:
 - Drop unused qmp_v4_usb3_rx_tbl

Changes since v1:
 - Provide dt bindings
 - Split register renaming from sm8250-dp-phy patch
 - Add respective changes to sm8250 device tree

Comments

Rob Herring March 27, 2021, 3:17 p.m. UTC | #1 
On Fri, 26 Mar 2021 20:58:03 +0300, Dmitry Baryshkov wrote:
> The commit 724fabf5df13 ("dt-bindings: phy: qcom,qmp-usb3-dp: Add DP phy
> information") has support for DP part of USB3+DP combo PHYs. However
> this change is not backwards compatible, placing additional requirements
> onto qcom,sc7180-qmp-usb3-phy and qcom,sdm845-qmp-usb3-phy device nodes
> (to include separate DP part, etc). However the aforementioned nodes do
> not inclue DP part, they strictly follow the schema defined in the
> qcom,qmp-phy.yaml file. Move those compatibles, leaving
> qcom,qmp-usb3-dp-phy.yaml to describe only real "combo" USB3+DP device nodes.
> 
> Fixes: 724fabf5df13 ("dt-bindings: phy: qcom,qmp-usb3-dp: Add DP phy information")
> Cc: Stephen Boyd <swboyd@chromium.org>
> Cc: Sandeep Maheswaram <sanm@codeaurora.org>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>  Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml         | 2 ++
>  Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml | 2 --
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 

Acked-by: Rob Herring <robh@kernel.org>
Stephen Boyd March 27, 2021, 6:24 p.m. UTC | #2 
Quoting Dmitry Baryshkov (2021-03-26 10:58:03)
> The commit 724fabf5df13 ("dt-bindings: phy: qcom,qmp-usb3-dp: Add DP phy

> information") has support for DP part of USB3+DP combo PHYs. However

> this change is not backwards compatible, placing additional requirements

> onto qcom,sc7180-qmp-usb3-phy and qcom,sdm845-qmp-usb3-phy device nodes

> (to include separate DP part, etc). However the aforementioned nodes do

> not inclue DP part, they strictly follow the schema defined in the

> qcom,qmp-phy.yaml file. Move those compatibles, leaving

> qcom,qmp-usb3-dp-phy.yaml to describe only real "combo" USB3+DP device nodes.

> 

> Fixes: 724fabf5df13 ("dt-bindings: phy: qcom,qmp-usb3-dp: Add DP phy information")

> Cc: Stephen Boyd <swboyd@chromium.org>

> Cc: Sandeep Maheswaram <sanm@codeaurora.org>

> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

> ---

>  Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml         | 2 ++

>  Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml | 2 --

>  2 files changed, 2 insertions(+), 2 deletions(-)

> 

> diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml

> index 626447fee092..0f42b36b0ac5 100644

> --- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml

> +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml

> @@ -25,11 +25,13 @@ properties:

>        - qcom,msm8998-qmp-pcie-phy

>        - qcom,msm8998-qmp-ufs-phy

>        - qcom,msm8998-qmp-usb3-phy

> +      - qcom,sc7180x-qmp-usb3-phy


Drop the x on sc7180?

>        - qcom,sc8180x-qmp-ufs-phy

>        - qcom,sc8180x-qmp-usb3-phy

>        - qcom,sdm845-qhp-pcie-phy

>        - qcom,sdm845-qmp-pcie-phy

>        - qcom,sdm845-qmp-ufs-phy

> +      - qcom,sdm845-qmp-usb3-phy

>        - qcom,sdm845-qmp-usb3-uni-phy

>        - qcom,sm8150-qmp-ufs-phy

>        - qcom,sm8150-qmp-usb3-phy


Otherwise

Reviewed-by: Stephen Boyd <swboyd@chromium.org>