mbox series

[v2,0/2] Enable VBUS current boost on pm8150b platforms

Message ID 20210426221446.1852572-1-bryan.odonoghue@linaro.org
Headers show
Series Enable VBUS current boost on pm8150b platforms | expand

Message

Bryan O'Donoghue April 26, 2021, 10:14 p.m. UTC 
The first version of this patch set the current limit to 3 amps as was done
in downstream. Mark indicated a preference to set this on a per-system
basis instead of blitzing it, as in downstream.

Looking at what was upstream versus what was in my working tree I saw that
in fact the VBUS boost driver had been upstreamed minus accompanying DTS in
pm8150b.

So there's no need for a fixes as this driver doesn't appear to be in use.
A subsequent patchset will enable the VBUS boost for the two relevant
upstream platforms.

First thing though, is the driver + dts change.

- Use regulator_set_current_limit_regmap/regulator_get_current_limit_regmap
  with a relevant current-to-bitmap lookup.

- Add a parallel DTS entry to the pm8150b
  It looks like this was submitted upstream but not followed up on

  I've add regulator-min-microamp/regulator-max-microamp to Wesley's
  original work.

I've made sure to test that its possible to set the current to anything in
the range of 500 mA to 3 A and confirmed the output on a scope.

Once these two patches are in, I'll send out board enablement for the
sm8150-mtp and qrb5165-rb5.

https://lore.kernel.org/linux-arm-msm/8687acdb-75e9-5fc5-dd3e-9a19615676b5@linaro.org/T/#t

Bryan O'Donoghue (1):
  regulator: Add a routine to set the current limit for QCOM PMIC VBUS

Wesley Cheng (1):
  arm64: boot: dts: qcom: pm8150b: Add DTS node for PMIC VBUS booster

 arch/arm64/boot/dts/qcom/pm8150b.dtsi       |  8 ++++++++
 drivers/regulator/qcom_usb_vbus-regulator.c | 12 ++++++++++++
 2 files changed, 20 insertions(+)

-- 
2.30.1

Comments

Mark Brown May 11, 2021, 8:25 a.m. UTC | #1 
On Mon, 26 Apr 2021 23:14:44 +0100, Bryan O'Donoghue wrote:
> The first version of this patch set the current limit to 3 amps as was done

> in downstream. Mark indicated a preference to set this on a per-system

> basis instead of blitzing it, as in downstream.

> 

> Looking at what was upstream versus what was in my working tree I saw that

> in fact the VBUS boost driver had been upstreamed minus accompanying DTS in

> pm8150b.

> 

> [...]


Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/2] regulator: Add a routine to set the current limit for QCOM PMIC VBUS
      commit: 67823d9dadd4dddee4b6bd075f6852b6ade5604a

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark