mbox series

[v4,0/4] pinctrl: qcom/pinctrl-spmi-gpio: Add support for pmic-gpio on SA8155p-adp

Message ID 20210629123407.82561-1-bhupesh.sharma@linaro.org
Headers show
Series pinctrl: qcom/pinctrl-spmi-gpio: Add support for pmic-gpio on SA8155p-adp | expand

Message

Bhupesh Sharma June 29, 2021, 12:34 p.m. UTC
Changes since v3:
-----------------
- v3 series can be found here: https://lore.kernel.org/linux-arm-msm/20210617053432.350486-1-bhupesh.sharma@linaro.org/T/#m2b1bf2d32dfdde3196dc5342722e356ee1f87456 
- Rebased patchset on pinctrl/devel branch.
- Added Reviewed-by from Bjorn for patches 1 to 4 and Ack from Rob for
  patches 1 and 2.

Changes since v2:
-----------------
- v2 series can be found here: https://lore.kernel.org/linux-arm-msm/20210615074543.26700-1-bhupesh.sharma@linaro.org/T/#m8303d27d561b30133992da88198abb78ea833e21 
- Addressed review comments from Bjorn and Mark.
- As per suggestion from Bjorn, separated the patches in different
  patchsets (specific to each subsystem) to ease review and patch application.

Changes since v1:
-----------------
- v1 series can be found here: https://lore.kernel.org/linux-arm-msm/20210607113840.15435-1-bhupesh.sharma@linaro.org/T/#mc524fe82798d4c4fb75dd0333318955e0406ad18
- Addressed review comments from Bjorn and Vinod received on the v1
  series.

This series adds the pmic-gpio support code for SA8155p-adp board
which is based on Qualcomm snapdragon sa8155p SoC which in turn is
simiar to the sm8150 SoC. 

This board supports a new PMIC -> PMM8155AU.

While at it, also make some cosmetic changes to the qcom pinctrl-spmi-gpio
driver and dt-bindings to make sure the compatibles are 
in alphabetical order.

Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>

Bhupesh Sharma (4):
  dt-bindings: pinctrl: qcom,pmic-gpio: Arrange compatibles
    alphabetically
  dt-bindings: pinctrl: qcom,pmic-gpio: Add compatible for SA8155p-adp
  pinctrl: qcom/pinctrl-spmi-gpio: Arrange compatibles alphabetically
  pinctrl: qcom/pinctrl-spmi-gpio: Add compatible for pmic-gpio on
    SA8155p-adp

 .../bindings/pinctrl/qcom,pmic-gpio.txt       | 64 ++++++++++---------
 drivers/pinctrl/qcom/pinctrl-spmi-gpio.c      | 35 +++++-----
 2 files changed, 51 insertions(+), 48 deletions(-)

Comments

Bhupesh Sharma July 14, 2021, 5:40 a.m. UTC | #1
Hi Linus,

On Tue, 29 Jun 2021 at 18:04, Bhupesh Sharma <bhupesh.sharma@linaro.org> wrote:
>
> Changes since v3:
> -----------------
> - v3 series can be found here: https://lore.kernel.org/linux-arm-msm/20210617053432.350486-1-bhupesh.sharma@linaro.org/T/#m2b1bf2d32dfdde3196dc5342722e356ee1f87456
> - Rebased patchset on pinctrl/devel branch.
> - Added Reviewed-by from Bjorn for patches 1 to 4 and Ack from Rob for
>   patches 1 and 2.
>
> Changes since v2:
> -----------------
> - v2 series can be found here: https://lore.kernel.org/linux-arm-msm/20210615074543.26700-1-bhupesh.sharma@linaro.org/T/#m8303d27d561b30133992da88198abb78ea833e21
> - Addressed review comments from Bjorn and Mark.
> - As per suggestion from Bjorn, separated the patches in different
>   patchsets (specific to each subsystem) to ease review and patch application.
>
> Changes since v1:
> -----------------
> - v1 series can be found here: https://lore.kernel.org/linux-arm-msm/20210607113840.15435-1-bhupesh.sharma@linaro.org/T/#mc524fe82798d4c4fb75dd0333318955e0406ad18
> - Addressed review comments from Bjorn and Vinod received on the v1
>   series.
>
> This series adds the pmic-gpio support code for SA8155p-adp board
> which is based on Qualcomm snapdragon sa8155p SoC which in turn is
> simiar to the sm8150 SoC.
>
> This board supports a new PMIC -> PMM8155AU.
>
> While at it, also make some cosmetic changes to the qcom pinctrl-spmi-gpio
> driver and dt-bindings to make sure the compatibles are
> in alphabetical order.
>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
>
> Bhupesh Sharma (4):
>   dt-bindings: pinctrl: qcom,pmic-gpio: Arrange compatibles
>     alphabetically
>   dt-bindings: pinctrl: qcom,pmic-gpio: Add compatible for SA8155p-adp
>   pinctrl: qcom/pinctrl-spmi-gpio: Arrange compatibles alphabetically
>   pinctrl: qcom/pinctrl-spmi-gpio: Add compatible for pmic-gpio on
>     SA8155p-adp
>
>  .../bindings/pinctrl/qcom,pmic-gpio.txt       | 64 ++++++++++---------
>  drivers/pinctrl/qcom/pinctrl-spmi-gpio.c      | 35 +++++-----
>  2 files changed, 51 insertions(+), 48 deletions(-)
>
> --
> 2.31.1

Ping. Any comments on this version?

Thanks,
Bhupesh
Linus Walleij July 23, 2021, 4:21 p.m. UTC | #2
On Tue, Jun 29, 2021 at 2:34 PM Bhupesh Sharma
<bhupesh.sharma@linaro.org> wrote:

> Changes since v3:
> -----------------
> - v3 series can be found here: https://lore.kernel.org/linux-arm-msm/20210617053432.350486-1-bhupesh.sharma@linaro.org/T/#m2b1bf2d32dfdde3196dc5342722e356ee1f87456
> - Rebased patchset on pinctrl/devel branch.
> - Added Reviewed-by from Bjorn for patches 1 to 4 and Ack from Rob for
>   patches 1 and 2.

This v4 patch set applied!

Sorry for taking so long, I had a bit too much to do.

Excellent work on the patches Bhupesh!

Yours,
Linus Walleij
Bhupesh Sharma July 24, 2021, 7:21 a.m. UTC | #3
Hi Linus,

On Fri, 23 Jul 2021 at 21:51, Linus Walleij <linus.walleij@linaro.org> wrote:
>

> On Tue, Jun 29, 2021 at 2:34 PM Bhupesh Sharma

> <bhupesh.sharma@linaro.org> wrote:

>

> > Changes since v3:

> > -----------------

> > - v3 series can be found here: https://lore.kernel.org/linux-arm-msm/20210617053432.350486-1-bhupesh.sharma@linaro.org/T/#m2b1bf2d32dfdde3196dc5342722e356ee1f87456

> > - Rebased patchset on pinctrl/devel branch.

> > - Added Reviewed-by from Bjorn for patches 1 to 4 and Ack from Rob for

> >   patches 1 and 2.

>

> This v4 patch set applied!

>

> Sorry for taking so long, I had a bit too much to do.

>

> Excellent work on the patches Bhupesh!


Thanks for picking the patchset.

Regards,
Bhupesh