mbox series

[v1,0/3] iio: chemical: Add support for Sensirion SCD4x CO2 sensor

Message ID 20210901105911.178646-1-roan@protonic.nl
Headers show
Series iio: chemical: Add support for Sensirion SCD4x CO2 sensor | expand

Message

Roan van Dijk Sept. 1, 2021, 10:59 a.m. UTC
This series adds support for the Sensirion SCD4x sensor.

The driver supports continuous reads of temperature, relative humdity and CO2
concentration. There is an interval of 5 seconds between readings. During
this interval the drivers checks if the sensor has new data available.

The driver is based on the scd30 driver. However, The scd4x has become too
different to just expand the scd30 driver. I made a new driver instead of
expanding the scd30 driver. I hope I made the right choice by doing so?

Changes since v1:
dt-bindings:
  - Separated compatible string for each sensor type
scd4x.c:
  - Changed probe, resume and suspend functions to static
  - Added SIMPLE_DEV_PM_OPS function call for power management
    operations.

Roan van Dijk (3):
  dt-bindings: iio: chemical: sensirion,scd4x: Add yaml description
  MAINTAINERS: Add myself as maintainer of the scd4x driver
  drivers: iio: chemical: Add support for Sensirion SCD4x CO2 sensor

 .../iio/chemical/sensirion,scd4x.yaml         |  46 ++
 MAINTAINERS                                   |   6 +
 drivers/iio/chemical/Kconfig                  |  13 +
 drivers/iio/chemical/Makefile                 |   1 +
 drivers/iio/chemical/scd4x.c                  | 708 ++++++++++++++++++
 5 files changed, 774 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/iio/chemical/sensirion,scd4x.yaml
 create mode 100644 drivers/iio/chemical/scd4x.c

Comments

Rob Herring (Arm) Sept. 3, 2021, 7:51 p.m. UTC | #1
On Wed, 01 Sep 2021 12:59:09 +0200, Roan van Dijk wrote:
> Add documentation for the SCD4x carbon dioxide sensor from Sensirion.

> 

> Signed-off-by: Roan van Dijk <roan@protonic.nl>

> ---

>  .../iio/chemical/sensirion,scd4x.yaml         | 46 +++++++++++++++++++

>  1 file changed, 46 insertions(+)

>  create mode 100644 Documentation/devicetree/bindings/iio/chemical/sensirion,scd4x.yaml

> 


Reviewed-by: Rob Herring <robh@kernel.org>
Roan van Dijk Sept. 7, 2021, 1:13 p.m. UTC | #2
On 03-09-2021 21:51, Rob Herring wrote:
> On Wed, 01 Sep 2021 12:59:09 +0200, Roan van Dijk wrote:

>> Add documentation for the SCD4x carbon dioxide sensor from Sensirion.

>>

>> Signed-off-by: Roan van Dijk <roan@protonic.nl>

>> ---

>>   .../iio/chemical/sensirion,scd4x.yaml         | 46 +++++++++++++++++++

>>   1 file changed, 46 insertions(+)

>>   create mode 100644 Documentation/devicetree/bindings/iio/chemical/sensirion,scd4x.yaml

>>

> Reviewed-by: Rob Herring <robh@kernel.org>

Sorry, I forgot about this. It will be added to the next patch.

Thanks,

Roan