mbox series

[0/2] of: unittest: re-implement overlay tracking

Message ID 20220101033329.1277779-1-frowand.list@gmail.com
Headers show
Series of: unittest: re-implement overlay tracking | expand

Message

Frank Rowand Jan. 1, 2022, 3:33 a.m. UTC 
From: Frank Rowand <frank.rowand@sony.com>

Some overlays are tracked when they are applied.  The tracked overlays
are later removed after the overlay tests are completed.  The old
implementation makes assumptions about the expected values for
overlay changeset id created by the overlay apply which result
in fragile code.  The new code removes the assumptions.

A symptom that exposes a problem with the tracking code is a
warning "UBSAN: shift-out-of-bounds in drivers/of/unittest.c:1933:36",
Kernel Version: 5.15-rc7, PPC-64, Talos II.  This results from variable
"id" value of -1 in the final line of of_unittest_untrack_overlay().

The first patch in the series cleans up the inconsistent use of overlay
changeset id and the obsolete overlay id.  The id is a core concept in
the overlay tracking that is re-implemented in the second patch in
the series.

Frank Rowand (2):
  of: unittest: change references to obsolete overlay id
  of: unittest: re-implement overlay tracking

 drivers/of/unittest.c | 154 +++++++++++++++++++-----------------------
 1 file changed, 71 insertions(+), 83 deletions(-)