| Message ID | 20220411200506.22891-1-quic_amelende@quicinc.com |
|---|---|
| Headers | show |
| Series | Extend pm8941-pwrkey driver | expand |
On 4/14/2022 8:34 AM, Rob Herring wrote: > On Mon, Apr 11, 2022 at 01:05:03PM -0700, Anjelique Melendez wrote: >> From: David Collins <quic_collinsd@quicinc.com> >> >> Update the description of "reg" property to add the PON_PBS base >> address along with PON_HLOS base address. Also add "reg-names" >> property description. >> >> Signed-off-by: David Collins <quic_collinsd@quicinc.com> >> Signed-off-by: Anjelique Melendez <quic_amelende@quicinc.com> >> --- >> .../bindings/power/reset/qcom,pon.yaml | 20 +++++++++++++++++++- >> 1 file changed, 19 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml >> index 353f155d..542200b2 100644 >> --- a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml >> +++ b/Documentation/bindings/power/reset/qcom,pon.yaml >> @@ -26,7 +26,25 @@ properties: >> - qcom,pm8998-pon >> >> reg: >> - maxItems: 1 >> + description: | >> + Specifies the SPMI base address for the PON (power-on) peripheral. For >> + PMICs that have the PON peripheral (GEN3) split into PON_HLOS and PON_PBS >> + (e.g. PMK8350), this can hold addresses of both PON_HLOS and PON_PBS >> + peripherals. In that case, the PON_PBS address needs to be specified to >> + facilitate software debouncing on some PMICs. >> + minItems: 1 >> + maxItems: 2 >> + >> + reg-names: >> + description: | >> + For PON GEN1 and GEN2, it should be "pon". For PON GEN3 it should include >> + "pon_hlos" and optionally "pon_pbs". >> + minItems: 1 >> + maxItems: 2 >> + items: >> + - const: pon_hlos >> + - const: pon_pbs >> + - const: pon > > This says there are 3 entries, but you limited to 2. The schema also > doesn't match what the description says. Entries should be extended by > adding new entries to the end and keeping optional entries last. So like > this: > > minItems: 1 > items: > - const: pon > - const: pon_hlos > - const: pon_pbs > > RobWill update in next patch. Thanks
Changes from v4: - Added new dt-binding patch as 1/5 Changes from v3: - Fixed dereference issue in 2/4 - Added Stephen's reviewed by tag for 2/4 Changes from v2: - Addressed Stephen's comments - Add Stephen's reviewed by tag for 1/4 - Fixed style for 2/4 - Corrected function call to use correct function for 3/4 Changes from v1: - Removed Change-Id from all patches - Updated subject line of cover letter - Addressed Stephen's comments for v1 1/3 - Separated error message fix to own patch (v2 1/4) - Separated PON GEN3 base address changes to own patch (v2 2/4) - Added new variables and functions to make code more readable - Removed v1 3/3 as per Bjorn's comments Anjelique Melendez (2): input: misc: pm8941-pwrkey: fix error message input: misc: pm8941-pwrkey: add support for PON GEN3 base addresses David Collins (3): dt-bindings: power: reset: qcom-pon: update "reg" property details input: misc: pm8941-pwrkey: add software key press debouncing support input: misc: pm8941-pwrkey: simulate missed key press events Documentation/devicetree/bindings/power/reset/qcom,pon.yaml | 20 +++++++++++++++++++- drivers/input/misc/pm8941-pwrkey.c | 124 +++++++++++++++++++++++++---- 2 files changed, 129 insertions(+), 15 deletions(-)