mbox series

[00/11] Start converting MVEBU bindings to YAML

Message ID 20220820194804.3352415-1-andrew@lunn.ch
Headers show
Series Start converting MVEBU bindings to YAML | expand

Message

Andrew Lunn Aug. 20, 2022, 7:47 p.m. UTC
This is the first batch of patches converting the Marvell MVEBU driver
bindings from .txt to .yaml. So far, kirkwood has been used for
testing, but these drivers apply to a range of Marvell SoCs.

In order to reduce the number of warnings from the DT schema checking
tools, a few minor changes have been made to a few DT files. No actual
errors have been found, the changes just make the checker quiet.

Andrew Lunn (11):
  DT: RTC: orion-rtc: Convert to YAML
  DT: thermal: marvell,kirkwood-thermal: Convert to YAML
  DT: pinctrl: Convert marvell,kirkwood-pintctrl to YAML
  DT: USB: Convert ehci-orion to YAML
  DT: watchdog: Convert marvel.txt to YAML
  arm: DT: kirkwood/orion5: Rename watchdog node
  DT: nand-controller: Reflect reality of marvell,orion-nand
  DT: mtd: Convert orion-nand to YAML
  arm: DT: kirkwood.dtsi: Rename nand to nand-controller
  DT: timer: Convert marvell,orion-timer.txt to YAML
  DT: clock: Convert mvebu-gated-clock.txt to YAML

 .../clock/marvell,kirkwood-gating-clock.yaml  | 230 +++++++++++
 .../bindings/clock/mvebu-gated-clock.txt      | 205 ----------
 .../bindings/mtd/marvell,orion-nand.yaml      |  85 +++++
 .../bindings/mtd/nand-controller.yaml         |  17 +-
 .../devicetree/bindings/mtd/orion-nand.txt    |  50 ---
 .../pinctrl/marvell,88f6180-pinctrl.yaml      |  73 ++++
 .../pinctrl/marvell,88f6190-pinctrl.yaml      |  73 ++++
 .../pinctrl/marvell,88f6192-pinctrl.yaml      |  73 ++++
 .../pinctrl/marvell,88f6281-pinctrl.yaml      |  74 ++++
 .../pinctrl/marvell,88f6282-pinctrl.yaml      |  74 ++++
 .../pinctrl/marvell,98dx1135-pinctrl.yaml     |  72 ++++
 .../pinctrl/marvell,98dx4122-pinctrl.yaml     |  71 ++++
 .../bindings/pinctrl/marvell,ac5-pinctrl.yaml |  14 +-
 .../pinctrl/marvell,kirkwood-pinctrl.txt      | 359 ------------------
 .../bindings/rtc/marvell,orion-rtc.yaml       |  48 +++
 .../devicetree/bindings/rtc/orion-rtc.txt     |  18 -
 .../bindings/thermal/kirkwood-thermal.txt     |  15 -
 .../thermal/marvell,kirkwood-thermal.yaml     |  32 ++
 .../bindings/timer/marvell,orion-timer.txt    |  16 -
 .../bindings/timer/marvell,orion-timer.yaml   |  51 +++
 .../devicetree/bindings/usb/ehci-orion.txt    |  22 --
 .../bindings/usb/marvell,orion-ehci.yaml      |  44 +++
 .../devicetree/bindings/watchdog/marvel.txt   |  45 ---
 .../bindings/watchdog/marvell,orion-wdt.yaml  |  83 ++++
 arch/arm/boot/dts/kirkwood.dtsi               |   4 +-
 arch/arm/boot/dts/orion5x.dtsi                |   2 +-
 26 files changed, 1109 insertions(+), 741 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/clock/marvell,kirkwood-gating-clock.yaml
 delete mode 100644 Documentation/devicetree/bindings/clock/mvebu-gated-clock.txt
 create mode 100644 Documentation/devicetree/bindings/mtd/marvell,orion-nand.yaml
 delete mode 100644 Documentation/devicetree/bindings/mtd/orion-nand.txt
 create mode 100644 Documentation/devicetree/bindings/pinctrl/marvell,88f6180-pinctrl.yaml
 create mode 100644 Documentation/devicetree/bindings/pinctrl/marvell,88f6190-pinctrl.yaml
 create mode 100644 Documentation/devicetree/bindings/pinctrl/marvell,88f6192-pinctrl.yaml
 create mode 100644 Documentation/devicetree/bindings/pinctrl/marvell,88f6281-pinctrl.yaml
 create mode 100644 Documentation/devicetree/bindings/pinctrl/marvell,88f6282-pinctrl.yaml
 create mode 100644 Documentation/devicetree/bindings/pinctrl/marvell,98dx1135-pinctrl.yaml
 create mode 100644 Documentation/devicetree/bindings/pinctrl/marvell,98dx4122-pinctrl.yaml
 delete mode 100644 Documentation/devicetree/bindings/pinctrl/marvell,kirkwood-pinctrl.txt
 create mode 100644 Documentation/devicetree/bindings/rtc/marvell,orion-rtc.yaml
 delete mode 100644 Documentation/devicetree/bindings/rtc/orion-rtc.txt
 delete mode 100644 Documentation/devicetree/bindings/thermal/kirkwood-thermal.txt
 create mode 100644 Documentation/devicetree/bindings/thermal/marvell,kirkwood-thermal.yaml
 delete mode 100644 Documentation/devicetree/bindings/timer/marvell,orion-timer.txt
 create mode 100644 Documentation/devicetree/bindings/timer/marvell,orion-timer.yaml
 delete mode 100644 Documentation/devicetree/bindings/usb/ehci-orion.txt
 create mode 100644 Documentation/devicetree/bindings/usb/marvell,orion-ehci.yaml
 delete mode 100644 Documentation/devicetree/bindings/watchdog/marvel.txt
 create mode 100644 Documentation/devicetree/bindings/watchdog/marvell,orion-wdt.yaml

Comments

Rob Herring Aug. 21, 2022, 8:21 p.m. UTC | #1
On Sat, 20 Aug 2022 21:47:57 +0200, Andrew Lunn wrote:
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> ---
>  .../devicetree/bindings/usb/ehci-orion.txt    | 22 ----------
>  .../bindings/usb/marvell,orion-ehci.yaml      | 44 +++++++++++++++++++
>  2 files changed, 44 insertions(+), 22 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/usb/ehci-orion.txt
>  create mode 100644 Documentation/devicetree/bindings/usb/marvell,orion-ehci.yaml
> 

Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.

Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.

Full log is available here: https://patchwork.ozlabs.org/patch/


ehci@50000: '#address-cells', '#size-cells', 'port@1' do not match any of the regexes: 'pinctrl-[0-9]+'
	arch/arm/boot/dts/kirkwood-c200-v1.dtb
	arch/arm/boot/dts/kirkwood-l-50.dtb

usb@50000: 'phy-names' does not match any of the regexes: 'pinctrl-[0-9]+'
	arch/arm/boot/dts/armada-375-db.dtb

usb@58000: 'usb-phy' does not match any of the regexes: 'pinctrl-[0-9]+'
	arch/arm/boot/dts/armada-388-helios4.dtb

usb@58000: 'vcc-supply' does not match any of the regexes: 'pinctrl-[0-9]+'
	arch/arm/boot/dts/armada-388-gp.dtb

usb@5e000: 'marvell,usb-misc-reg', 'phy-names' do not match any of the regexes: 'pinctrl-[0-9]+'
	arch/arm64/boot/dts/marvell/armada-3720-db.dtb
	arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtb
	arch/arm64/boot/dts/marvell/armada-3720-espressobin-emmc.dtb
	arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dtb
	arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dtb
	arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dtb
	arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dtb
	arch/arm64/boot/dts/marvell/armada-3720-uDPU.dtb

usb@a0000: 'dr_mode', 'phy-names' do not match any of the regexes: 'pinctrl-[0-9]+'
	arch/arm64/boot/dts/marvell/ac5-98dx35xx-rd.dtb

usb-host@50000: 'vbus-supply' does not match any of the regexes: 'pinctrl-[0-9]+'
	arch/arm/boot/dts/dove-sbc-a510.dtb
Rob Herring Aug. 30, 2022, 6:58 p.m. UTC | #2
On Mon, Aug 22, 2022 at 9:29 AM Andrew Lunn <andrew@lunn.ch> wrote:
>
> On Mon, Aug 22, 2022 at 08:53:23AM -0500, Rob Herring wrote:
> > On Sat, Aug 20, 2022 at 09:47:53PM +0200, Andrew Lunn wrote:
> > > This is the first batch of patches converting the Marvell MVEBU driver
> > > bindings from .txt to .yaml. So far, kirkwood has been used for
> > > testing, but these drivers apply to a range of Marvell SoCs.
> > >
> > > In order to reduce the number of warnings from the DT schema checking
> > > tools, a few minor changes have been made to a few DT files. No actual
> > > errors have been found, the changes just make the checker quiet.
> > >
> > > Andrew Lunn (11):
> > >   DT: RTC: orion-rtc: Convert to YAML
> > >   DT: thermal: marvell,kirkwood-thermal: Convert to YAML
> > >   DT: pinctrl: Convert marvell,kirkwood-pintctrl to YAML
> > >   DT: USB: Convert ehci-orion to YAML
> > >   DT: watchdog: Convert marvel.txt to YAML
> > >   arm: DT: kirkwood/orion5: Rename watchdog node
> > >   DT: nand-controller: Reflect reality of marvell,orion-nand
> > >   DT: mtd: Convert orion-nand to YAML
> > >   arm: DT: kirkwood.dtsi: Rename nand to nand-controller
> > >   DT: timer: Convert marvell,orion-timer.txt to YAML
> > >   DT: clock: Convert mvebu-gated-clock.txt to YAML
> >
> > Also, there's not any dependency between most of these patches and they
> > all go thru different subsystems, so no need for this to be 1 series.
>
> My intention was for them all to go through mvebu, to arm-soc and in.
> That is how all these .txt files got merged many years ago.

Yes, that did happen some, but the documented path in for bindings is
via subsystem maintainers (with the driver for new bindings). The 2nd
preference is the DT tree as I'm about the only one testing (or
continuously testing) the schemas.

Rob