| Message ID | 20220830164518.1381632-1-biju.das.jz@bp.renesas.com |
|---|---|
| Headers | show |
| Series | Add RZ/N1 CAN support | expand |
Hi Krzysztof Kozlowski, Thanks for the feedback. > Subject: Re: [PATCH v3 1/3] dt-bindings: can: nxp,sja1000: Document > RZ/N1 power-domains support > > On 30/08/2022 19:45, Biju Das wrote: > > Document RZ/N1 power-domains support. Also update the example with > > power-domains property. > > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > --- > > v3: > > * Documented power-domains support. > > You made them required, so it would be nice to see reason in such > change. The commit msg says only what you did, but not why you did it. It is simple. As you see from [1] and [2] power-domains are enabled by default in RZ/N1 SoC. So there is nothing prevent us to document this property for all IP's present in RZ/N1 SoC. [1]https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/clk/renesas/r9a06g032-clocks.c?h=v6.0-rc3&id=aad03a66f902e18bab612870261bde647fdbda2c [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/soc/renesas?h=v6.0-rc3&id=14f11da778ff642142e9be18814815754c82d6c5 Cheers, Biju
On 30.08.2022 17:45:15, Biju Das wrote: > This patch series supports CAN{0,1} populated on RZ/N1D-DB board. > > v2->v3: > * Documented power-domains support. > * Dropped clock-names property from CAN nodes. > * Added power-domains property to the CAN nodes. > v1->v2: > * Added RZ/N1 specific compatible string. > * Added clock-names property. > > This patch series depend upon [1] > [1] https://lore.kernel.org/linux-renesas-soc/20220819084532.ywtziogd7ycuozxx@pengutronix.de/ > > Biju Das (3): > dt-bindings: can: nxp,sja1000: Document RZ/N1 power-domains support > ARM: dts: r9a06g032: Add CAN{0,1} nodes > ARM: dts: r9a06g032-rzn1d400-db: Enable CAN{0,1} Who will take this series (once it's ready)? regards, Marc
Hi Marc, > Subject: Re: [PATCH v3 0/3] Add RZ/N1 CAN support > > On 30.08.2022 17:45:15, Biju Das wrote: > > This patch series supports CAN{0,1} populated on RZ/N1D-DB board. > > > > v2->v3: > > * Documented power-domains support. > > * Dropped clock-names property from CAN nodes. > > * Added power-domains property to the CAN nodes. > > v1->v2: > > * Added RZ/N1 specific compatible string. > > * Added clock-names property. > > > > This patch series depend upon [1] > > [1] https://lore.kernel.org/linux-renesas- > soc/20220819084532.ywtziogd7ycuozxx@pengutronix.de/ > > > > Biju Das (3): > > dt-bindings: can: nxp,sja1000: Document RZ/N1 power-domains support > > ARM: dts: r9a06g032: Add CAN{0,1} nodes > > ARM: dts: r9a06g032-rzn1d400-db: Enable CAN{0,1} > > Who will take this series (once it's ready)? I guess, normally bindings by respective maintainer(ie, by you) and Renesas SoC/board dtsi/dts by Geert. Already SoC dtsi is queued for 6.1[1]. So I guess binding can be applied to respective subsystem tree. [1] https://patchwork.kernel.org/project/linux-renesas-soc/patch/20220830164518.1381632-3-biju.das.jz@bp.renesas.com/ Cheers, Biju
On 05.09.2022 16:13:09, Biju Das wrote: > Hi Marc, > > > Subject: Re: [PATCH v3 0/3] Add RZ/N1 CAN support > > > > On 30.08.2022 17:45:15, Biju Das wrote: > > > This patch series supports CAN{0,1} populated on RZ/N1D-DB board. > > > > > > v2->v3: > > > * Documented power-domains support. > > > * Dropped clock-names property from CAN nodes. > > > * Added power-domains property to the CAN nodes. > > > v1->v2: > > > * Added RZ/N1 specific compatible string. > > > * Added clock-names property. > > > > > > This patch series depend upon [1] > > > [1] https://lore.kernel.org/linux-renesas- > > soc/20220819084532.ywtziogd7ycuozxx@pengutronix.de/ > > > > > > Biju Das (3): > > > dt-bindings: can: nxp,sja1000: Document RZ/N1 power-domains support > > > ARM: dts: r9a06g032: Add CAN{0,1} nodes > > > ARM: dts: r9a06g032-rzn1d400-db: Enable CAN{0,1} > > > > Who will take this series (once it's ready)? > > I guess, normally bindings by respective maintainer(ie, by you) and > Renesas SoC/board dtsi/dts by Geert. Already SoC dtsi is > queued for 6.1[1]. So I guess binding can be applied to respective subsystem > tree. > > [1] https://patchwork.kernel.org/project/linux-renesas-soc/patch/20220830164518.1381632-3-biju.das.jz@bp.renesas.com/ Ok, applied 1/3 to linux-can-next. regards, Marc
This patch series supports CAN{0,1} populated on RZ/N1D-DB board. v2->v3: * Documented power-domains support. * Dropped clock-names property from CAN nodes. * Added power-domains property to the CAN nodes. v1->v2: * Added RZ/N1 specific compatible string. * Added clock-names property. This patch series depend upon [1] [1] https://lore.kernel.org/linux-renesas-soc/20220819084532.ywtziogd7ycuozxx@pengutronix.de/ Biju Das (3): dt-bindings: can: nxp,sja1000: Document RZ/N1 power-domains support ARM: dts: r9a06g032: Add CAN{0,1} nodes ARM: dts: r9a06g032-rzn1d400-db: Enable CAN{0,1} .../bindings/net/can/nxp,sja1000.yaml | 5 ++++ arch/arm/boot/dts/r9a06g032-rzn1d400-db.dts | 26 +++++++++++++++++++ arch/arm/boot/dts/r9a06g032.dtsi | 20 ++++++++++++++ 3 files changed, 51 insertions(+)