| Message ID | 20220908150658.1839520-1-kavyasree.kotagiri@microchip.com |
|---|---|
| Headers | show |
| Series | Add support for lan966x flexcom chip-select configuration | expand |
> > > Convert the Atmel flexcom device tree bindings to json schema. > > > > > > Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com> > > > --- > > > v8 -> v9: > > > - Changed reference provided for spi bindings to atmel,at91rm9200- > > spi.yaml > > > > > > v7 -> v8: > > > - Added back patternProperties for child nodes. > > > > > > v6 -> v7: > > > - Change filename to atmel,sama5d2-flexcom.yaml > > > - Add #address-cells, #size-cells to flexcom node - Fixed warnings. > > > > > > v5 -> v6: > > > - Removed spi node from example as suggested by Rob and > > > also pattern properties(spi dt-bindings conversion to yaml patch is > under > > review). > > > Once that is accepted, I will add back spi example through new patch. > > > > > > v4 -> v5: > > > - Fixed indentations. > > > > > > v3 -> v4: > > > - Corrected format of enum used for compatible string. > > > > > > v2 -> v3: > > > - used enum for compatible string. > > > - changed irq flag to IRQ_TYPE_LEVEL_HIGH in example. > > > - fixed dtschema errors. > > > > > > v1 -> v2: > > > - Fix title. > > > > > > .../bindings/mfd/atmel,sama5d2-flexcom.yaml | 91 > > +++++++++++++++++++ > > > .../devicetree/bindings/mfd/atmel-flexcom.txt | 63 ------------- > > > 2 files changed, 91 insertions(+), 63 deletions(-) > > > create mode 100644 > > Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml > > > delete mode 100644 Documentation/devicetree/bindings/mfd/atmel- > > flexcom.txt > > > > > > > Running 'make dtbs_check' with the schema in this patch gives the > > following warnings. Consider if they are expected or the schema is > > incorrect. These may not be new warnings. > > > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > > This will change in the future. > > > > Full log is available here: https://patchwork.ozlabs.org/patch/ > > > > > > flexcom@e0040000: spi@400: Unevaluated properties are not allowed > > ('dma-names', 'dmas' were unexpected) > > arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-6g-2gs.dtb > > arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-8g.dtb > > arch/arm/boot/dts/lan966x-pcb8291.dtb > > arch/arm/boot/dts/lan966x-pcb8309.dtb > > > > flexcom@e0044000: spi@400: Unevaluated properties are not allowed > > ('dma-names', 'dmas' were unexpected) > > arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-6g-2gs.dtb > > arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-8g.dtb > > arch/arm/boot/dts/lan966x-pcb8291.dtb > > arch/arm/boot/dts/lan966x-pcb8309.dtb > > > > flexcom@e0060000: spi@400: Unevaluated properties are not allowed > > ('dma-names', 'dmas' were unexpected) > > arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-6g-2gs.dtb > > arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-8g.dtb > > arch/arm/boot/dts/lan966x-pcb8291.dtb > > arch/arm/boot/dts/lan966x-pcb8309.dtb > > > > flexcom@e0064000: spi@400: Unevaluated properties are not allowed > > ('dma-names', 'dmas' were unexpected) > > arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-6g-2gs.dtb > > arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-8g.dtb > > arch/arm/boot/dts/lan966x-pcb8291.dtb > > arch/arm/boot/dts/lan966x-pcb8309.dtb > > > > flexcom@e0070000: spi@400: Unevaluated properties are not allowed > > ('dma-names', 'dmas' were unexpected) > > arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-6g-2gs.dtb > > arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-8g.dtb > > arch/arm/boot/dts/lan966x-pcb8291.dtb > > arch/arm/boot/dts/lan966x-pcb8309.dtb > > > > flexcom@e2824000: spi@400: Unevaluated properties are not allowed > > ('dma-names', 'dmas' were unexpected) > > arch/arm/boot/dts/at91-sama7g5ek.dtb > > > > flexcom@f8034000: spi@400: Unevaluated properties are not allowed > > ('dma-names', 'dmas' were unexpected) > > arch/arm/boot/dts/at91-kizbox3-hs.dtb > > arch/arm/boot/dts/at91-sama5d27_som1_ek.dtb > > arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dtb > > arch/arm/boot/dts/at91-sama5d2_icp.dtb > > arch/arm/boot/dts/at91-sama5d2_ptc_ek.dtb > > arch/arm/boot/dts/at91-sama5d2_xplained.dtb > > > > flexcom@f8038000: spi@400: Unevaluated properties are not allowed > > ('dma-names', 'dmas' were unexpected) > > arch/arm/boot/dts/at91-kizbox3-hs.dtb > > arch/arm/boot/dts/at91-sama5d27_som1_ek.dtb > > arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dtb > > arch/arm/boot/dts/at91-sama5d2_icp.dtb > > arch/arm/boot/dts/at91-sama5d2_ptc_ek.dtb > > arch/arm/boot/dts/at91-sama5d2_xplained.dtb > > > > flexcom@fc010000: spi@400: Unevaluated properties are not allowed > ('dma- > > names', 'dmas' were unexpected) > > arch/arm/boot/dts/at91-kizbox3-hs.dtb > > arch/arm/boot/dts/at91-sama5d27_som1_ek.dtb > > arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dtb > > arch/arm/boot/dts/at91-sama5d2_icp.dtb > > arch/arm/boot/dts/at91-sama5d2_ptc_ek.dtb > > arch/arm/boot/dts/at91-sama5d2_xplained.dtb > > > > flexcom@fc014000: spi@400: Unevaluated properties are not allowed > ('dma- > > names', 'dmas' were unexpected) > > arch/arm/boot/dts/at91-kizbox3-hs.dtb > > arch/arm/boot/dts/at91-sama5d27_som1_ek.dtb > > arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dtb > > arch/arm/boot/dts/at91-sama5d2_icp.dtb > > arch/arm/boot/dts/at91-sama5d2_ptc_ek.dtb > > arch/arm/boot/dts/at91-sama5d2_xplained.dtb > > > > flexcom@fc018000: spi@400: Unevaluated properties are not allowed > ('dma- > > names', 'dmas' were unexpected) > > arch/arm/boot/dts/at91-kizbox3-hs.dtb > > arch/arm/boot/dts/at91-sama5d27_som1_ek.dtb > > arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dtb > > arch/arm/boot/dts/at91-sama5d2_icp.dtb > > arch/arm/boot/dts/at91-sama5d2_ptc_ek.dtb > > arch/arm/boot/dts/at91-sama5d2_xplained.dtb > > dma properties for spi node is already being covered by Sergiu in below > patch: > https://lore.kernel.org/lkml/b4625526-8f9b-ada8-f854- > 751a48545576@linaro.org/ > Hi Rob, Please let me know your comments. Thanks, Kavya > > Thanks, > Kavya
On 12/09/2022 10:16, Kavyasree.Kotagiri@microchip.com wrote: >>> flexcom@fc018000: spi@400: Unevaluated properties are not allowed >> ('dma- >>> names', 'dmas' were unexpected) >>> arch/arm/boot/dts/at91-kizbox3-hs.dtb >>> arch/arm/boot/dts/at91-sama5d27_som1_ek.dtb >>> arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dtb >>> arch/arm/boot/dts/at91-sama5d2_icp.dtb >>> arch/arm/boot/dts/at91-sama5d2_ptc_ek.dtb >>> arch/arm/boot/dts/at91-sama5d2_xplained.dtb >> >> dma properties for spi node is already being covered by Sergiu in below >> patch: >> https://lore.kernel.org/lkml/b4625526-8f9b-ada8-f854- >> 751a48545576@linaro.org/ >> > Hi Rob, Please let me know your comments. this means it cannot be currently tested. Are you sure that there are no warnings in all DTBs with your patches? Best regards, Krzysztof
> >>> flexcom@fc018000: spi@400: Unevaluated properties are not allowed > >> ('dma- > >>> names', 'dmas' were unexpected) > >>> arch/arm/boot/dts/at91-kizbox3-hs.dtb > >>> arch/arm/boot/dts/at91-sama5d27_som1_ek.dtb > >>> arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dtb > >>> arch/arm/boot/dts/at91-sama5d2_icp.dtb > >>> arch/arm/boot/dts/at91-sama5d2_ptc_ek.dtb > >>> arch/arm/boot/dts/at91-sama5d2_xplained.dtb > >> > >> dma properties for spi node is already being covered by Sergiu in below > >> patch: > >> https://lore.kernel.org/lkml/b4625526-8f9b-ada8-f854- > >> 751a48545576@linaro.org/ > >> > > Hi Rob, Please let me know your comments. > > this means it cannot be currently tested. Are you sure that there are no > warnings in all DTBs with your patches? > Yes, I ran dtbs_check. I don’t see any warnings. Thanks, Kavya > > Best regards, > Krzysztof
> On 13/09/2022 07:29, Kavyasree.Kotagiri@microchip.com wrote: > >>>>> flexcom@fc018000: spi@400: Unevaluated properties are not allowed > >>>> ('dma- > >>>>> names', 'dmas' were unexpected) > >>>>> arch/arm/boot/dts/at91-kizbox3-hs.dtb > >>>>> arch/arm/boot/dts/at91-sama5d27_som1_ek.dtb > >>>>> arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dtb > >>>>> arch/arm/boot/dts/at91-sama5d2_icp.dtb > >>>>> arch/arm/boot/dts/at91-sama5d2_ptc_ek.dtb > >>>>> arch/arm/boot/dts/at91-sama5d2_xplained.dtb > >>>> > >>>> dma properties for spi node is already being covered by Sergiu in below > >>>> patch: > >>>> https://lore.kernel.org/lkml/b4625526-8f9b-ada8-f854- > >>>> 751a48545576@linaro.org/ > >>>> > >>> Hi Rob, Please let me know your comments. > >> > >> this means it cannot be currently tested. Are you sure that there are no > >> warnings in all DTBs with your patches? > >> > > Yes, I ran dtbs_check. I don’t see any warnings. > > Then the warning could be probably ignored (I assume it is really fixed > when both patchsets land). > Yes. You are right. > > Best regards, > Krzysztof
> > On 13/09/2022 07:29, Kavyasree.Kotagiri@microchip.com wrote: > > >>>>> flexcom@fc018000: spi@400: Unevaluated properties are not > allowed > > >>>> ('dma- > > >>>>> names', 'dmas' were unexpected) > > >>>>> arch/arm/boot/dts/at91-kizbox3-hs.dtb > > >>>>> arch/arm/boot/dts/at91-sama5d27_som1_ek.dtb > > >>>>> arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dtb > > >>>>> arch/arm/boot/dts/at91-sama5d2_icp.dtb > > >>>>> arch/arm/boot/dts/at91-sama5d2_ptc_ek.dtb > > >>>>> arch/arm/boot/dts/at91-sama5d2_xplained.dtb > > >>>> > > >>>> dma properties for spi node is already being covered by Sergiu in > below > > >>>> patch: > > >>>> https://lore.kernel.org/lkml/b4625526-8f9b-ada8-f854- > > >>>> 751a48545576@linaro.org/ > > >>>> > > >>> Hi Rob, Please let me know your comments. > > >> > > >> this means it cannot be currently tested. Are you sure that there are no > > >> warnings in all DTBs with your patches? > > >> > > > Yes, I ran dtbs_check. I don’t see any warnings. > > > > Then the warning could be probably ignored (I assume it is really fixed > > when both patchsets land). > > > Yes. You are right. > Hi All, Please let me know your comments on this patch series. Thanks, Kavya > > > > Best regards, > > Krzysztof
> This patch series converts atmel-flexcom bindings into json-schema format. > Adds support for lan966x flexcom chip-select configurations and its > DT bindings. > > v8 -> v9: Hi All, Please ignore this v9 patch series. I just now found that it is conflicting with https://lore.kernel.org/linux-arm-kernel/20220913142205.162399-6-sergiu.moga@microchip.com/ So, I will re-send my v8 patch series which is already reviewed by Rob Herring and claudiu.beznea Thanks, Kavya > - generated patches on linux-next v6.0.0-rc4 to resend. > - Changed reference provided for spi bindings to atmel,at91rm9200-spi.yaml > > v7 -> v8: > - Added back patternProperties for child nodes. > - Changed compatible string to microchip,lan9668-flexcom. > > v6 -> v7: > - Change filename to atmel,sama5d2-flexcom.yaml > - Add #address-cells, #size-cells to flexcom node - Fixed warnings. > > v5 -> v6: > - Removed spi node from example as suggested by Rob and > also pattern properties(spi dt-bindings conversion to yaml patch is under > review). > https://patchwork.kernel.org/project/linux-arm- > kernel/patch/20220629125804.137099-1-sergiu.moga@microchip.com/ > Once this is accepted, I will add back spi example through new patch. > > v4 -> v5: > - Fix indentations of DT example. > - Fix dt-schema errors - removed minItems, maxItems for allOf:if:then > "reg" property as it is not required. > > v3 -> v4: > - Fix dtschema errors. > - Add a condition to flexcom chip-selects configuration as chip-select > lines are optional. > > v2 -> v3: > - changed IRQ flag in dt-bindings example. > - added reg property specific to lan66x which is missed in v2. > - used goto label for clk_disable in error cases. > > v1 -> v2: > - minor fix in title of dt-bindings. > - Modified new dt properties usage in atmel,flexcom.yaml. > - Used GENMASK and macros for maximum allowed values. > - Use u32 values for flexcom chipselects instead of strings. > - disable clock in case of errors. > > Kavyasree Kotagiri (3): > dt-bindings: mfd: Convert atmel-flexcom to json-schema > dt-bindings: mfd: atmel,sama5d2-flexcom: Add new compatible string for > lan966x > mfd: atmel-flexcom: Add support for lan966x flexcom chip-select > configuration > > .../bindings/mfd/atmel,sama5d2-flexcom.yaml | 154 ++++++++++++++++++ > .../devicetree/bindings/mfd/atmel-flexcom.txt | 63 ------- > drivers/mfd/atmel-flexcom.c | 94 ++++++++++- > 3 files changed, 247 insertions(+), 64 deletions(-) > create mode 100644 > Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml > delete mode 100644 Documentation/devicetree/bindings/mfd/atmel- > flexcom.txt > > -- > 2.25.1
This patch series converts atmel-flexcom bindings into json-schema format. Adds support for lan966x flexcom chip-select configurations and its DT bindings. v8 -> v9: - generated patches on linux-next v6.0.0-rc4 to resend. - Changed reference provided for spi bindings to atmel,at91rm9200-spi.yaml v7 -> v8: - Added back patternProperties for child nodes. - Changed compatible string to microchip,lan9668-flexcom. v6 -> v7: - Change filename to atmel,sama5d2-flexcom.yaml - Add #address-cells, #size-cells to flexcom node - Fixed warnings. v5 -> v6: - Removed spi node from example as suggested by Rob and also pattern properties(spi dt-bindings conversion to yaml patch is under review). https://patchwork.kernel.org/project/linux-arm-kernel/patch/20220629125804.137099-1-sergiu.moga@microchip.com/ Once this is accepted, I will add back spi example through new patch. v4 -> v5: - Fix indentations of DT example. - Fix dt-schema errors - removed minItems, maxItems for allOf:if:then "reg" property as it is not required. v3 -> v4: - Fix dtschema errors. - Add a condition to flexcom chip-selects configuration as chip-select lines are optional. v2 -> v3: - changed IRQ flag in dt-bindings example. - added reg property specific to lan66x which is missed in v2. - used goto label for clk_disable in error cases. v1 -> v2: - minor fix in title of dt-bindings. - Modified new dt properties usage in atmel,flexcom.yaml. - Used GENMASK and macros for maximum allowed values. - Use u32 values for flexcom chipselects instead of strings. - disable clock in case of errors. Kavyasree Kotagiri (3): dt-bindings: mfd: Convert atmel-flexcom to json-schema dt-bindings: mfd: atmel,sama5d2-flexcom: Add new compatible string for lan966x mfd: atmel-flexcom: Add support for lan966x flexcom chip-select configuration .../bindings/mfd/atmel,sama5d2-flexcom.yaml | 154 ++++++++++++++++++ .../devicetree/bindings/mfd/atmel-flexcom.txt | 63 ------- drivers/mfd/atmel-flexcom.c | 94 ++++++++++- 3 files changed, 247 insertions(+), 64 deletions(-) create mode 100644 Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml delete mode 100644 Documentation/devicetree/bindings/mfd/atmel-flexcom.txt