| Message ID | 20221110162126.103437-1-biju.das.jz@bp.renesas.com |
|---|---|
| Headers | show |
| Series | Add SoC identification support for RZ/V2M | expand |
Hi Krzysztof Kozlowski, > -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: 11 November 2022 08:34 > To: Biju Das <biju.das.jz@bp.renesas.com>; Rob Herring <robh+dt@kernel.org>; > Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> > Cc: Phil Edworthy <phil.edworthy@renesas.com>; Geert Uytterhoeven > <geert+renesas@glider.be>; Magnus Damm <magnus.damm@gmail.com>; linux- > renesas-soc@vger.kernel.org; devicetree@vger.kernel.org; Chris Paterson > <Chris.Paterson2@renesas.com>; Fabrizio Castro > <fabrizio.castro.jz@renesas.com> > Subject: Re: [PATCH v2 1/3] dt-bindings: arm: renesas: Document Renesas > RZ/V2M System Configuration > > On 10/11/2022 17:21, Biju Das wrote: > > From: Phil Edworthy <phil.edworthy@renesas.com> > > > > Add DT binding documentation for System Configuration (SYS) found on > > RZ/V2M SoC's. > > > > SYS block contains the SYS_VERSION register which can be used to > > retrieve SoC version information. > > > > Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com> > > [biju: Updated the example ] > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > --- > > v1->v2: > > * Moved the file from arm->soc/renesas > > * Updated the path for binding file > > * Updated the example > > --- > > .../soc/renesas/renesas,rzv2m-sys.yaml | 39 +++++++++++++++++++ > > 1 file changed, 39 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/soc/renesas/renesas,rzv2m-sys.yaml > > > > diff --git > > a/Documentation/devicetree/bindings/soc/renesas/renesas,rzv2m-sys.yaml > > b/Documentation/devicetree/bindings/soc/renesas/renesas,rzv2m-sys.yaml > > new file mode 100644 > > index 000000000000..cc41747798e2 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/soc/renesas/renesas,rzv2m-sys. > > +++ yaml > > Filename should be based on the compatible. Pretty often some common parts of > both are fine (e.g. when file contains multiple compatibles), but this very > different then what I see below. We plan to upstream another similar SoC, RZ/V2MA which has similar IP, so we may need to add generic compatible rzv2m-sys. I am checking with HW people to get more info about RZ/V2MA. > > > @@ -0,0 +1,39 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 > > +--- > > +$id: > " " > > +$schema: > " " > > Drop quotes from both. OK. > > > + > > +title: Renesas RZ/V2M System Configuration (SYS) > > + > > +maintainers: > > + - Geert Uytterhoeven <geert+renesas@glider.be> > > + > > +description: > > + The RZ/V2M System Configuration (SYS) performs system control of > > +the LSI > > + and supports the following functions, > > + - LSI version > > + - 34-bit address space access function > > + - PCIe related settings > > + - WDT stop control > > + - Temperature sensor (TSU) monitor > > + > > +properties: > > + compatible: > > + const: renesas,r9a09g011-sys > > + > > + reg: > > + maxItems: 1 > > + > > +required: > > + - compatible > > + - reg > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + sysc: system-configuration@a3f03000 { > > If I get properly the purpose of the device, usually this is called "system- > controller". Use that as device node. The hardware manual mentions the below. So want to consistent with HW manual. Section 38 System Configuration (SYS) This section describes the functions of the system configuration (SYS). > > > + compatible = "renesas,r9a09g011-sys"; > > + reg = <0xa3f03000 0x400>; > > Use 4 spaces for example indentation. OK, Agreed. Cheers, Biju
On 11/11/2022 10:06, Biju Das wrote: > Hi Krzysztof Kozlowski, > >> -----Original Message----- >> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> Sent: 11 November 2022 08:34 >> To: Biju Das <biju.das.jz@bp.renesas.com>; Rob Herring <robh+dt@kernel.org>; >> Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> >> Cc: Phil Edworthy <phil.edworthy@renesas.com>; Geert Uytterhoeven >> <geert+renesas@glider.be>; Magnus Damm <magnus.damm@gmail.com>; linux- >> renesas-soc@vger.kernel.org; devicetree@vger.kernel.org; Chris Paterson >> <Chris.Paterson2@renesas.com>; Fabrizio Castro >> <fabrizio.castro.jz@renesas.com> >> Subject: Re: [PATCH v2 1/3] dt-bindings: arm: renesas: Document Renesas >> RZ/V2M System Configuration >> >> On 10/11/2022 17:21, Biju Das wrote: >>> From: Phil Edworthy <phil.edworthy@renesas.com> >>> >>> Add DT binding documentation for System Configuration (SYS) found on >>> RZ/V2M SoC's. >>> >>> SYS block contains the SYS_VERSION register which can be used to >>> retrieve SoC version information. >>> >>> Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com> >>> [biju: Updated the example ] >>> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> >>> --- >>> v1->v2: >>> * Moved the file from arm->soc/renesas >>> * Updated the path for binding file >>> * Updated the example >>> --- >>> .../soc/renesas/renesas,rzv2m-sys.yaml | 39 +++++++++++++++++++ >>> 1 file changed, 39 insertions(+) >>> create mode 100644 >>> Documentation/devicetree/bindings/soc/renesas/renesas,rzv2m-sys.yaml >>> >>> diff --git >>> a/Documentation/devicetree/bindings/soc/renesas/renesas,rzv2m-sys.yaml >>> b/Documentation/devicetree/bindings/soc/renesas/renesas,rzv2m-sys.yaml >>> new file mode 100644 >>> index 000000000000..cc41747798e2 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/soc/renesas/renesas,rzv2m-sys. >>> +++ yaml >> >> Filename should be based on the compatible. Pretty often some common parts of >> both are fine (e.g. when file contains multiple compatibles), but this very >> different then what I see below. > > We plan to upstream another similar SoC, RZ/V2MA which has similar IP, so we may > need to add generic compatible rzv2m-sys. I am checking with HW people to get > more info about RZ/V2MA. > >> >>> @@ -0,0 +1,39 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 >>> +--- >>> +$id: >> " > " >>> +$schema: >> " > " >> >> Drop quotes from both. > > OK. > >> >>> + >>> +title: Renesas RZ/V2M System Configuration (SYS) >>> + >>> +maintainers: >>> + - Geert Uytterhoeven <geert+renesas@glider.be> >>> + >>> +description: >>> + The RZ/V2M System Configuration (SYS) performs system control of >>> +the LSI >>> + and supports the following functions, >>> + - LSI version >>> + - 34-bit address space access function >>> + - PCIe related settings >>> + - WDT stop control >>> + - Temperature sensor (TSU) monitor >>> + >>> +properties: >>> + compatible: >>> + const: renesas,r9a09g011-sys >>> + >>> + reg: >>> + maxItems: 1 >>> + >>> +required: >>> + - compatible >>> + - reg >>> + >>> +additionalProperties: false >>> + >>> +examples: >>> + - | >>> + sysc: system-configuration@a3f03000 { >> >> If I get properly the purpose of the device, usually this is called "system- >> controller". Use that as device node. > > The hardware manual mentions the below. So want to consistent with HW manual. If the hardware manual said this is called "foo-whatever-name" or "rz85736dfnx2", you would use it as well? Node names should be generic. https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > > Section 38 System Configuration (SYS) > This section describes the functions of the system configuration (SYS). So NAK. Best regards, Krzysztof
> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: 11 November 2022 10:52 > To: Biju Das <biju.das.jz@bp.renesas.com>; Rob Herring <robh+dt@kernel.org>; > Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> > Cc: Phil Edworthy <phil.edworthy@renesas.com>; Geert Uytterhoeven > <geert+renesas@glider.be>; Magnus Damm <magnus.damm@gmail.com>; linux- > renesas-soc@vger.kernel.org; devicetree@vger.kernel.org; Chris Paterson > <Chris.Paterson2@renesas.com>; Fabrizio Castro > <fabrizio.castro.jz@renesas.com> > Subject: Re: [PATCH v2 1/3] dt-bindings: arm: renesas: Document Renesas > RZ/V2M System Configuration > > On 11/11/2022 10:06, Biju Das wrote: > > Hi Krzysztof Kozlowski, > > > >> -----Original Message----- > >> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > >> Sent: 11 November 2022 08:34 > >> To: Biju Das <biju.das.jz@bp.renesas.com>; Rob Herring > >> <robh+dt@kernel.org>; Krzysztof Kozlowski > >> <krzysztof.kozlowski+dt@linaro.org> > >> Cc: Phil Edworthy <phil.edworthy@renesas.com>; Geert Uytterhoeven > >> <geert+renesas@glider.be>; Magnus Damm <magnus.damm@gmail.com>; > >> linux- renesas-soc@vger.kernel.org; devicetree@vger.kernel.org; Chris > >> Paterson <Chris.Paterson2@renesas.com>; Fabrizio Castro > >> <fabrizio.castro.jz@renesas.com> > >> Subject: Re: [PATCH v2 1/3] dt-bindings: arm: renesas: Document > >> Renesas RZ/V2M System Configuration > >> > >> On 10/11/2022 17:21, Biju Das wrote: > >>> From: Phil Edworthy <phil.edworthy@renesas.com> > >>> > >>> Add DT binding documentation for System Configuration (SYS) found on > >>> RZ/V2M SoC's. > >>> > >>> SYS block contains the SYS_VERSION register which can be used to > >>> retrieve SoC version information. > >>> > >>> Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com> > >>> [biju: Updated the example ] > >>> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > >>> --- > >>> v1->v2: > >>> * Moved the file from arm->soc/renesas > >>> * Updated the path for binding file > >>> * Updated the example > >>> --- > >>> .../soc/renesas/renesas,rzv2m-sys.yaml | 39 +++++++++++++++++++ > >>> 1 file changed, 39 insertions(+) > >>> create mode 100644 > >>> Documentation/devicetree/bindings/soc/renesas/renesas,rzv2m-sys.yaml > >>> > >>> diff --git > >>> a/Documentation/devicetree/bindings/soc/renesas/renesas,rzv2m-sys.ya > >>> ml > >>> b/Documentation/devicetree/bindings/soc/renesas/renesas,rzv2m-sys.ya > >>> ml > >>> new file mode 100644 > >>> index 000000000000..cc41747798e2 > >>> --- /dev/null > >>> +++ b/Documentation/devicetree/bindings/soc/renesas/renesas,rzv2m-sys. > >>> +++ yaml > >> > >> Filename should be based on the compatible. Pretty often some common > >> parts of both are fine (e.g. when file contains multiple > >> compatibles), but this very different then what I see below. > > > > We plan to upstream another similar SoC, RZ/V2MA which has similar IP, > > so we may need to add generic compatible rzv2m-sys. I am checking with > > HW people to get more info about RZ/V2MA. > > > >> > >>> @@ -0,0 +1,39 @@ > >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 > >>> +--- > >>> +$id: > >> " > > " > >>> +$schema: > >> " > > " > >> > >> Drop quotes from both. > > > > OK. > > > >> > >>> + > >>> +title: Renesas RZ/V2M System Configuration (SYS) > >>> + > >>> +maintainers: > >>> + - Geert Uytterhoeven <geert+renesas@glider.be> > >>> + > >>> +description: > >>> + The RZ/V2M System Configuration (SYS) performs system control of > >>> +the LSI > >>> + and supports the following functions, > >>> + - LSI version > >>> + - 34-bit address space access function > >>> + - PCIe related settings > >>> + - WDT stop control > >>> + - Temperature sensor (TSU) monitor > >>> + > >>> +properties: > >>> + compatible: > >>> + const: renesas,r9a09g011-sys > >>> + > >>> + reg: > >>> + maxItems: 1 > >>> + > >>> +required: > >>> + - compatible > >>> + - reg > >>> + > >>> +additionalProperties: false > >>> + > >>> +examples: > >>> + - | > >>> + sysc: system-configuration@a3f03000 { > >> > >> If I get properly the purpose of the device, usually this is called > >> "system- controller". Use that as device node. > > > > The hardware manual mentions the below. So want to consistent with HW > manual. > > If the hardware manual said this is called "foo-whatever-name" or > "rz85736dfnx2", you would use it as well? > > Node names should be generic. What about system-configuration-controller to make it generic or You still prefer system-controller like [1] [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/renesas/r9a07g054.dtsi?h=v6.1-rc4#n635 Cheers, Biju
This patch series aims to add SoC identification support for RZ/V2M. v1->v2: * Moved the binding file from arm->soc/renesas * Updated the binding example * Removed config from patch#2 as it is already present * Removed extra space before 'else if' statement Ref: [1] https://patchwork.kernel.org/project/linux-renesas-soc/patch/20220321154232.56315-3-phil.edworthy@renesas.com/ [2] https://patchwork.kernel.org/project/linux-renesas-soc/patch/20220321154232.56315-8-phil.edworthy@renesas.com/ logs: root@rzv2m:~# dmesg | grep "Renesas RZ/V2M" [ 0.119196] Detected Renesas RZ/V2M r9a09g011 1.1 root@rzv2m:~# for i in machine family soc_id revision; do echo -n "$i: ";cat /sys/devices/soc0/$i; done machine: RZ/V2M Evaluation Kit 2.0 family: RZ/V2M soc_id: r9a09g011 revision: 1.1 Biju Das (1): arm64: dts: renesas: r9a09g011: Add system configuration node Phil Edworthy (2): dt-bindings: arm: renesas: Document Renesas RZ/V2M System Configuration soc: renesas: Identify RZ/V2M SoC .../soc/renesas/renesas,rzv2m-sys.yaml | 39 +++++++++++++++++++ arch/arm64/boot/dts/renesas/r9a09g011.dtsi | 6 +++ drivers/soc/renesas/renesas-soc.c | 22 +++++++++++ 3 files changed, 67 insertions(+) create mode 100644 Documentation/devicetree/bindings/soc/renesas/renesas,rzv2m-sys.yaml