mbox series

[v7,0/5] hwmon: (pmbus/acbel-fsg032) Add Acbel power supply

Message ID 20230413132627.3444119-1-lakshmiy@us.ibm.com
Headers show
Series hwmon: (pmbus/acbel-fsg032) Add Acbel power supply | expand

Message

Lakshmi Yadlapati April 13, 2023, 1:26 p.m. UTC 
Adding new acbel,fsg032 driver and documentation updates.

Changes since V6:
Remove ccin changes in V6.

Lakshmi Yadlapati (5):
  dt-bindings: vendor-prefixes: Add prefix for acbel
  dt-bindings: trivial-devices: Add acbel,fsg032
  hwmon: (pmbus/acbel-fsg032) Add Acbel power supply
  docs: hwmon: Add documentaion for acbel-fsg032 PSU
  ARM: dts: aspeed: p10bmc: Change power supply info

 .../devicetree/bindings/trivial-devices.yaml  |  2 +
 .../devicetree/bindings/vendor-prefixes.yaml  |  2 +
 Documentation/hwmon/acbel-fsg032.rst          | 80 +++++++++++++++++
 Documentation/hwmon/index.rst                 |  1 +
 arch/arm/boot/dts/aspeed-bmc-ibm-bonnell.dts  | 12 +--
 drivers/hwmon/pmbus/Kconfig                   |  9 ++
 drivers/hwmon/pmbus/Makefile                  |  1 +
 drivers/hwmon/pmbus/acbel-fsg032.c            | 85 +++++++++++++++++++
 8 files changed, 186 insertions(+), 6 deletions(-)
 create mode 100644 Documentation/hwmon/acbel-fsg032.rst
 create mode 100644 drivers/hwmon/pmbus/acbel-fsg032.c

Comments

Guenter Roeck April 16, 2023, 2:41 p.m. UTC | #1 
On Thu, Apr 13, 2023 at 08:26:24AM -0500, Lakshmi Yadlapati wrote:
> Add new Acbel FSG032 power supply to trivial devices.
> 
> Signed-off-by: Lakshmi Yadlapati <lakshmiy@us.ibm.com>
> Acked-by: Rob Herring <robh@kernel.org>

Applied.

Thanks,
Guenter
Guenter Roeck April 16, 2023, 2:42 p.m. UTC | #2 
On Thu, Apr 13, 2023 at 08:26:26AM -0500, Lakshmi Yadlapati wrote:
> Add documentation changes for acbel-fsg032 psu
> 
> Signed-off-by: Lakshmi Yadlapati <lakshmiy@us.ibm.com>

Applied.

Thanks,
Guenter
Guenter Roeck April 16, 2023, 2:43 p.m. UTC | #3 
On Thu, Apr 13, 2023 at 08:26:27AM -0500, Lakshmi Yadlapati wrote:
> Bonnell system supports new ACBEL FSG032 power supply on
> I2C addresses 5A and 5B. Update the device tree with new
> power supply information and device addresses.
> 
> Signed-off-by: Lakshmi Yadlapati <lakshmiy@us.ibm.com>
> Reviewed-by: Eddie James <eajames@linux.ibm.com>

This patch will have to be applied through an ARM tree.

Acked-by: Guenter Roeck <linux@roeck-us.net>

Thanks,
Guenter

> ---
>  arch/arm/boot/dts/aspeed-bmc-ibm-bonnell.dts | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/aspeed-bmc-ibm-bonnell.dts b/arch/arm/boot/dts/aspeed-bmc-ibm-bonnell.dts
> index a5be0ee048ec..4f959a4f8b58 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-ibm-bonnell.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-ibm-bonnell.dts
> @@ -552,14 +552,14 @@ ucd90160@64 {
>  &i2c3 {
>  	status = "okay";
>  
> -	power-supply@58 {
> -		compatible = "ibm,cffps";
> -		reg = <0x58>;
> +	power-supply@5a {
> +		compatible = "acbel,fsg032";
> +		reg = <0x5a>;
>  	};
>  
> -	power-supply@59 {
> -		compatible = "ibm,cffps";
> -		reg = <0x59>;
> +	power-supply@5b {
> +		compatible = "acbel,fsg032";
> +		reg = <0x5b>;
>  	};
>  };
>
Joel Stanley April 17, 2023, 8:26 a.m. UTC | #4 
On Sun, 16 Apr 2023 at 14:43, Guenter Roeck <linux@roeck-us.net> wrote:
>
> On Thu, Apr 13, 2023 at 08:26:27AM -0500, Lakshmi Yadlapati wrote:
> > Bonnell system supports new ACBEL FSG032 power supply on
> > I2C addresses 5A and 5B. Update the device tree with new
> > power supply information and device addresses.
> >
> > Signed-off-by: Lakshmi Yadlapati <lakshmiy@us.ibm.com>
> > Reviewed-by: Eddie James <eajames@linux.ibm.com>
>
> This patch will have to be applied through an ARM tree.
>
> Acked-by: Guenter Roeck <linux@roeck-us.net>

Thanks, I sent it as part of the aspeed pull request.