mbox series

[v2,0/5] Add peripherals for J784S4

Message ID 20230414151553.339599-1-j-choudhary@ti.com
Headers show
Series Add peripherals for J784S4 | expand

Message

Jayesh Choudhary April 14, 2023, 3:15 p.m. UTC
This series adds support for:
- SERDES, WIZ DT nodes, Serdes lane control mux
- MAIN CPSW2G nodes
- DSS and DisplayPort-0 nodes

This series depends on DMA support patches for J784S4[1] which are
applied to linux-next.

DisplayPort has been tested on local J784S4 EVM. Test log:
<https://gist.github.com/Jayesh2000/3ba5a45b6e82f0c5c98d2e8fad56cb52>

Changelog v1->v2:
- Moved J784S4 EVM changes together to the last patch
  (Suggested by Andrew[2])

v1 patch link:
<https://lore.kernel.org/all/20230405111412.151192-1-j-choudhary@ti.com/>

[1]:
<https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=00e34c94987e4fe866f12ad8eac17268c936880c>
<https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=82e6051a48957a89066d15b17bb85d2f662f2bad>
<https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=436b288687176bf4d2c1cd25b86173e5a1649a60>

[2]:
<https://lore.kernel.org/all/e38ea0b2-5e51-05d6-50fc-c7ef3d4b8698@ti.com/>


Rahul T R (2):
  arm64: dts: ti: k3-j784s4-main: Add DSS and DP-bridge node
  arm64: dts: ti: k3-j784s4-evm: Enable DisplayPort-0

Siddharth Vadapalli (3):
  arm64: dts: ti: k3-j784s4-main: Add system controller and SERDES lane
    mux
  arm64: dts: ti: k3-j784s4: Add Main CPSW2G node
  arm64: dts: ti: k3-j784s4: Add WIZ and SERDES PHY nodes

 arch/arm64/boot/dts/ti/k3-j784s4-evm.dts   | 164 ++++++++++
 arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi | 338 +++++++++++++++++++++
 2 files changed, 502 insertions(+)

Comments

Vignesh Raghavendra April 17, 2023, 4:40 a.m. UTC | #1
On 14/04/23 20:45, Jayesh Choudhary wrote:
> diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
> index aef6f53ae8ac..b1445b7c2aa8 100644
> --- a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
> @@ -301,3 +301,7 @@ &main_cpsw1_port1 {
>  	phy-mode = "rgmii-rxid";
>  	phy-handle = <&main_phy0>;
>  };
> +
> +&serdes_refclk {
> +	clock-frequency = <100000000>;
> +};

Can we move this to 5/5 along with rest of -evm.dts changes?
Jayesh Choudhary April 17, 2023, 7:35 a.m. UTC | #2
Hi Vignesh,

On 17/04/23 10:07, Vignesh Raghavendra wrote:
> Hi Jayesh
> 
> On 14/04/23 20:45, Jayesh Choudhary wrote:
>> From: Siddharth Vadapalli <s-vadapalli@ti.com>
>>
>> The system controller node manages the CTRL_MMR0 region.
>> Add serdes_ln_ctrl node which is used for controlling the SERDES lane mux.
>>
>> Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
>> Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
>> ---
>>   arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi | 22 ++++++++++++++++++++++
>>   1 file changed, 22 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
>> index e9169eb358c1..344f4ffa0b82 100644
>> --- a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
>> +++ b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
>> @@ -5,6 +5,9 @@
>>    * Copyright (C) 2022 Texas Instruments Incorporated - https://www.ti.com/
>>    */
>>   
>> +#include <dt-bindings/mux/mux.h>
>> +#include <dt-bindings/mux/ti-serdes.h>
>> +
>>   &cbass_main {
>>   	msmc_ram: sram@70000000 {
>>   		compatible = "mmio-sram";
>> @@ -26,6 +29,25 @@ l3cache-sram@200000 {
>>   		};
>>   	};
>>   
>> +	scm_conf: scm-conf@100000 {
> 
> generic node name please: "syscon@"

Okay.

> 
>> +		compatible = "ti,j721e-system-controller", "syscon", "simple-mfd";
>> +		reg = <0x00 0x00100000 0x00 0x1c000>;
>> +		#address-cells = <1>;
>> +		#size-cells = <1>;
>> +		ranges = <0x00 0x00 0x00100000 0x1c000>;
>> +
>> +		serdes_ln_ctrl: mux-controller@4080 {
> 
> Either add reg property or replace @ with -

Will use '-'.

> 
> Run make with W=12 to catch such errors.

Okay. Will do.

Thanks.

[...]
Jayesh Choudhary April 17, 2023, 7:36 a.m. UTC | #3
On 17/04/23 10:10, Vignesh Raghavendra wrote:
> 
> 
> On 14/04/23 20:45, Jayesh Choudhary wrote:
>> diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
>> index aef6f53ae8ac..b1445b7c2aa8 100644
>> --- a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
>> +++ b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
>> @@ -301,3 +301,7 @@ &main_cpsw1_port1 {
>>   	phy-mode = "rgmii-rxid";
>>   	phy-handle = <&main_phy0>;
>>   };
>> +
>> +&serdes_refclk {
>> +	clock-frequency = <100000000>;
>> +};
> 
> Can we move this to 5/5 along with rest of -evm.dts changes?

Sure. Will move it to last patch in next revision.

Thanks.