mbox series

[v4,0/2] Add no-esim sku for sc7180-lazor family and new board version for audio codec ALC5682i-VS

Message ID 20230822094414.123162-1-sheng-liang.pan@quanta.corp-partner.google.com
Headers show
Series Add no-esim sku for sc7180-lazor family and new board version for audio codec ALC5682i-VS | expand

Message

Sheng-Liang Pan Aug. 22, 2023, 9:44 a.m. UTC 
Changes in v4:
- combine pathc2 and patch3

Changes in v3:
- correct corresponding of new board and new sku
- sort out the node order alphabetically

Changes in v2:
- add new entry rev9 with Parade bridge chip
- correct newly create dts files

Sheng-Liang Pan (2):
  dt-bindings: arm: qcom: add sc7180-lazor board bindings
  arm64: dts: qcom: sc7180: Add sku_id and board id for lazor/limozeen

 .../devicetree/bindings/arm/qcom.yaml         | 31 ++++++++++
 arch/arm64/boot/dts/qcom/Makefile             |  5 ++
 ...sc7180-trogdor-lazor-limozeen-nots-r10.dts | 40 +++++++++++++
 .../sc7180-trogdor-lazor-limozeen-nots-r9.dts |  4 +-
 .../sc7180-trogdor-lazor-limozeen-r10.dts     | 56 +++++++++++++++++++
 .../qcom/sc7180-trogdor-lazor-limozeen-r9.dts |  4 +-
 .../dts/qcom/sc7180-trogdor-lazor-r10-kb.dts  | 34 +++++++++++
 .../dts/qcom/sc7180-trogdor-lazor-r10-lte.dts | 38 +++++++++++++
 .../dts/qcom/sc7180-trogdor-lazor-r10.dts     | 30 ++++++++++
 .../dts/qcom/sc7180-trogdor-lazor-r9-kb.dts   |  4 +-
 .../dts/qcom/sc7180-trogdor-lazor-r9-lte.dts  |  4 +-
 .../boot/dts/qcom/sc7180-trogdor-lazor-r9.dts |  4 +-
 12 files changed, 244 insertions(+), 10 deletions(-)
 create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r10.dts
 create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-r10.dts
 create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r10-kb.dts
 create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r10-lte.dts
 create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r10.dts

Comments

Conor Dooley Aug. 23, 2023, 3:11 p.m. UTC | #1 
On Tue, Aug 22, 2023 at 05:44:13PM +0800, Sheng-Liang Pan wrote:
> Introduce more sc7180-lazor sku and board version configuration,
> add no-eSIM SKU 10 for Lazor, no-eSIM SKU 15 and 18 for Limozeen,
> add new board version 10 for audio codec ALC5682i-VS.
> 
> Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.
Doug Anderson Aug. 23, 2023, 5:17 p.m. UTC | #2 
Hi,

On Wed, Aug 23, 2023 at 8:11 AM Conor Dooley <conor@kernel.org> wrote:
>
> On Tue, Aug 22, 2023 at 05:44:13PM +0800, Sheng-Liang Pan wrote:
> > Introduce more sc7180-lazor sku and board version configuration,
> > add no-eSIM SKU 10 for Lazor, no-eSIM SKU 15 and 18 for Limozeen,
> > add new board version 10 for audio codec ALC5682i-VS.
> >
> > Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com>
> > Reviewed-by: Douglas Anderson <dianders@chromium.org>
>
> Acked-by: Conor Dooley <conor.dooley@microchip.com>

Conor: any chance you could reply to v6 (instead of v4) and add your Ack?

https://lore.kernel.org/all/20230823151005.v6.1.I26e017b00a341e7a5a2e94a83596923713408817@changeid/

I _think_ the v6 patch series is in good shape so I don't expect
Sheng-Liang to have to send a v7. I'm worried that your Ack will be
lost if it's not sent in response to the v6 patch.

Thanks!

-Doug
Conor Dooley Aug. 23, 2023, 6:32 p.m. UTC | #3 
On Wed, Aug 23, 2023 at 07:29:33PM +0100, Conor Dooley wrote:
> On Wed, Aug 23, 2023 at 10:17:17AM -0700, Doug Anderson wrote:
> > Hi,
> > 
> > On Wed, Aug 23, 2023 at 8:11 AM Conor Dooley <conor@kernel.org> wrote:
> > >
> > > On Tue, Aug 22, 2023 at 05:44:13PM +0800, Sheng-Liang Pan wrote:
> > > > Introduce more sc7180-lazor sku and board version configuration,
> > > > add no-eSIM SKU 10 for Lazor, no-eSIM SKU 15 and 18 for Limozeen,
> > > > add new board version 10 for audio codec ALC5682i-VS.
> > > >
> > > > Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com>
> > > > Reviewed-by: Douglas Anderson <dianders@chromium.org>
> > >
> > > Acked-by: Conor Dooley <conor.dooley@microchip.com>
> > 
> > Conor: any chance you could reply to v6 (instead of v4) and add your Ack?
> 
> People need to relax! This seems only to have been sent yesterday?!?
> 
> > https://lore.kernel.org/all/20230823151005.v6.1.I26e017b00a341e7a5a2e94a83596923713408817@changeid/
> > 
> > I _think_ the v6 patch series is in good shape so I don't expect
> > Sheng-Liang to have to send a v7. I'm worried that your Ack will be
> > lost if it's not sent in response to the v6 patch.

And I must have deleted the v6 w/o reading even really reading it as it
has an R-b from Krzysztof. My ack is therefore not needed anyway, so who
cares if it gets lost :)