| Message ID | 20231027-sc7280-remoteprocs-v1-0-05ce95d9315a@fairphone.com |
|---|---|
| Headers | show |
| Series | Remoteprocs (ADSP, CDSP, WPSS) for SC7280 | expand |
On 27/10/2023 16:20, Luca Weiss wrote: > Add the compatibles and constraints for the ADSP, CDSP and WPSS found on > the SC7280 SoC. > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> > --- > .../bindings/remoteproc/qcom,sc7180-pas.yaml | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 27/10/2023 16:20, Luca Weiss wrote: > Add the node for the ADSP found on the SC7280 SoC, using standard > Qualcomm firmware. > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> > --- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 27.10.2023 16:20, Luca Weiss wrote: > Enable the ADSP, CDSP, MPSS and WPSS that are found on the SoC. > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> > --- > arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts > index cc092735ce17..d65eef30091b 100644 > --- a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts > +++ b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts > @@ -490,6 +490,26 @@ &qupv3_id_1 { > status = "okay"; > }; > > +&remoteproc_adsp { > + firmware-name = "qcom/qcm6490/fairphone5/adsp.mdt"; > + status = "okay"; > +}; > + > +&remoteproc_cdsp { > + firmware-name = "qcom/qcm6490/fairphone5/cdsp.mdt"; > + status = "okay"; > +}; > + > +&remoteproc_mpss { > + firmware-name = "qcom/qcm6490/fairphone5/modem.mdt"; > + status = "okay"; > +}; > + > +&remoteproc_wpss { > + firmware-name = "qcom/qcm6490/fairphone5/wpss.mdt"; mbn? Konrad
On Mon Oct 30, 2023 at 8:26 PM CET, Konrad Dybcio wrote: > On 27.10.2023 16:20, Luca Weiss wrote: > > Enable the ADSP, CDSP, MPSS and WPSS that are found on the SoC. > > > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> > > --- > > arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts | 20 ++++++++++++++++++++ > > 1 file changed, 20 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts > > index cc092735ce17..d65eef30091b 100644 > > --- a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts > > +++ b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts > > @@ -490,6 +490,26 @@ &qupv3_id_1 { > > status = "okay"; > > }; > > > > +&remoteproc_adsp { > > + firmware-name = "qcom/qcm6490/fairphone5/adsp.mdt"; > > + status = "okay"; > > +}; > > + > > +&remoteproc_cdsp { > > + firmware-name = "qcom/qcm6490/fairphone5/cdsp.mdt"; > > + status = "okay"; > > +}; > > + > > +&remoteproc_mpss { > > + firmware-name = "qcom/qcm6490/fairphone5/modem.mdt"; > > + status = "okay"; > > +}; > > + > > +&remoteproc_wpss { > > + firmware-name = "qcom/qcm6490/fairphone5/wpss.mdt"; > mbn? Downstream ships mdt but if preferred I can change to .mbn and use pil-squasher. Not sure what's the correct thing nowadays :) Regards Luca > > Konrad
This series adds support for the ADSP, CDSP and WPSS remoteprocs found on SC7280. And finally enable them and WiFi on the QCM6490-based Fairphone 5 smartphone. The first two patches are fixes for the MPSS to fix some dt validation issues. They're included in this series to avoid conflicts with the later patches and keep it simpler. Please note, that the ChromeOS-based devices using SC7280 need different driver and dts support, similar to how there's already qcom,sc7280-mpss-pas for "standard" firmware and there's qcom,sc7280-mss-pil for ChromeOS firmware. I'm aware of the series also adding SC7280 ADSP support with the last revision sent in June this year. https://lore.kernel.org/linux-arm-msm/20230616103534.4031331-1-quic_mohs@quicinc.com/ However there's some differences since that series added the "pil" variant for ChromeOS, not "pas" for standard firmware. Also it seems on ChromeOS devices gpr+q6apm+q6prm is used. On my device it appears to be instead apr+q6afe+q6asm+q6adm but I don't add either in this series to keep it a bit simpler, and I couldn't test much of that yet. Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> --- Luca Weiss (9): dt-bindings: remoteproc: qcom: sc7180-pas: Fix SC7280 MPSS PD-names arm64: dts: qcom: sc7280: Remove unused second MPSS reg dt-bindings: remoteproc: qcom: sc7180-pas: Add SC7280 compatibles remoteproc: qcom_q6v5_pas: Add SC7280 ADSP, CDSP & WPSS arm64: dts: qcom: sc7280: Use WPSS PAS instead of PIL arm64: dts: qcom: sc7280: Add ADSP node arm64: dts: qcom: sc7280: Add CDSP node arm64: dts: qcom: qcm6490-fairphone-fp5: Enable various remoteprocs arm64: dts: qcom: qcm6490-fairphone-fp5: Enable WiFi .../bindings/remoteproc/qcom,sc7180-pas.yaml | 21 ++ arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts | 24 +++ arch/arm64/boot/dts/qcom/sc7280-chrome-common.dtsi | 24 ++- .../boot/dts/qcom/sc7280-herobrine-lte-sku.dtsi | 2 + arch/arm64/boot/dts/qcom/sc7280.dtsi | 225 +++++++++++++++++++-- drivers/remoteproc/qcom_q6v5_pas.c | 19 ++ 6 files changed, 300 insertions(+), 15 deletions(-) --- base-commit: 6a0dad42244c987e3c12bfae728199e360acf079 change-id: 20231027-sc7280-remoteprocs-048208cc1e13 Best regards,