| Message ID | 20231105-b4-camss-sc8280xp-v3-0-4b3c372ff0f4@linaro.org |
|---|---|
| Headers | show |
| Series | media: qcom: camss: Add sc8280xp support | expand |
On 11/5/23 18:45, Bryan O'Donoghue wrote: > Add in functional logic throughout the code to support the sc8280xp. > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > --- IMHO this should be squashed with patch 2 anyway: Acked-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad
On 11/5/23 18:45, Bryan O'Donoghue wrote: > Add a PHY configuration sequence for the sc8280xp which uses a Qualcomm > Gen 2 version 1.1 CSI-2 PHY. > > The PHY can be configured as two phase or three phase in C-PHY or D-PHY > mode. This configuration supports two-phase D-PHY mode. > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > --- Makes it sound like the current 2ph/3ph split is rather nonsensical? Perhaps we should restructure it to match hw revision? Especially since one can get it from the hardware itself.. Konrad
On 07/11/2023 21:43, Konrad Dybcio wrote: > > > On 11/5/23 18:45, Bryan O'Donoghue wrote: >> Add a PHY configuration sequence for the sc8280xp which uses a Qualcomm >> Gen 2 version 1.1 CSI-2 PHY. >> >> The PHY can be configured as two phase or three phase in C-PHY or D-PHY >> mode. This configuration supports two-phase D-PHY mode. >> >> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> >> --- > Makes it sound like the current 2ph/3ph split is rather nonsensical? > > Perhaps we should restructure it to match hw revision? Especially since > one can get it from the hardware itself.. > > Konrad For the C-PHY though we have to either add or remove caps - I forget which on ~ all of our reference platforms. "The PHY can do it" but I'd be surprised to find there's a single real implementation of it outside of a silicon test bench. --- bod
V3: - Strip pointer to dependencies from yaml patch I was hoping the robot would understand the links but it doesn't - Krzysztof Link to v2: https://lore.kernel.org/r/20231103-b4-camss-sc8280xp-v2-0-b7af4d253a20@linaro.org b4 base: https://git.codelinaro.org/bryan.odonoghue/kernel/-/tree/b4/camss-sc8280xp-v3 V2: - Rebase to capture is_lite flag from named power-domain series - Amends commit log of final patch to give more detail on rename - Konrad - Opted not to change switch() statements with returns. - bod/Konrad Requires CAMCC for sc8280xp which applies to qcom/clk-for-6.7: https://lore.kernel.org/linux-arm-msm/20231026105345.3376-1-bryan.odonoghue@linaro.org/ b4 shazam 20231026105345.3376-1-bryan.odonoghue@linaro.org Requires the named power-domain patches which apply to media-tree/*: https://lore.kernel.org/linux-arm-msm/20231103-b4-camss-named-power-domains-v4-0-33a905359dbc@linaro.org/ b4 shazam e700133b-58f7-4a4d-8e5c-0d04441b789b@linaro.org Link to v1: https://lore.kernel.org/r/20231102-b4-camss-sc8280xp-v1-0-9996f4bcb8f4@linaro.org b4 base: https://git.codelinaro.org/bryan.odonoghue/kernel/-/tree/b4/camss-sc8280xp-v2 V1: sc8280xp is the SoC found in the Lenovo X13s. This series adds support to bring up the CSIPHY, CSID, VFE/RDI interfaces. A number of precursor patches make this series smaller overall than previous series. sc8280xp provides - 4 x VFE, 4 RDI per VFE - 4 x VFE Lite, 4 RDI per VFE - 4 x CSID - 4 x CSID Lite - 4 x CSI PHY I've taken the yaml from a dtsi series and included it here since 1) I sent the yaml to the wrong person and 2) it already has RB from Krzysztof. Requires CAMCC for sc8280xp which applies to qcom/clk-for-6.7: https://lore.kernel.org/linux-arm-msm/20231026105345.3376-1-bryan.odonoghue@linaro.org/ b4 shazam 20231026105345.3376-1-bryan.odonoghue@linaro.org Requires the named power-domain patches which apply to media-tree/* : https://lore.kernel.org/linux-arm-msm/20231101-b4-camss-named-power-domains-v3-5-bbdf5f22462a@linaro.org/ b4 shazam 20231101-b4-camss-named-power-domains-v3-5-bbdf5f22462a@linaro.org To use the camera on x13s with say Google Hangouts or Microsoft Teams you will need to 1. Run Firefox 2. Update about:config to enable pipewire 3. Use this WIP version of libcamera https://gitlab.freedesktop.org/camera/libcamera-softisp A working bootable tree can be found here: Link: https://git.codelinaro.org/bryan.odonoghue/kernel/-/tree/lenovo-x13s-linux-6.5.y b4 base: https://git.codelinaro.org/bryan.odonoghue/kernel/-/tree/b4/camss-sc8280xp Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> --- Bryan O'Donoghue (6): media: dt-bindings: media: camss: Add qcom,sc8280xp-camss binding media: qcom: camss: Add CAMSS_SC8280XP enum media: qcom: camss: csiphy-3ph: Add Gen2 v1.1 two-phase MIPI CSI-2 DPHY init media: qcom: camss: Add sc8280xp resource details media: qcom: camss: Add sc8280xp support media: qcom: camss: vfe-17x: Rename camss-vfe-170 to camss-vfe-17x .../bindings/media/qcom,sc8280xp-camss.yaml | 581 +++++++++++++++++++++ drivers/media/platform/qcom/camss/Makefile | 2 +- .../platform/qcom/camss/camss-csiphy-3ph-1-0.c | 108 +++- drivers/media/platform/qcom/camss/camss-csiphy.c | 1 + .../camss/{camss-vfe-170.c => camss-vfe-17x.c} | 0 drivers/media/platform/qcom/camss/camss-vfe.c | 25 +- drivers/media/platform/qcom/camss/camss-video.c | 1 + drivers/media/platform/qcom/camss/camss.c | 383 ++++++++++++++ drivers/media/platform/qcom/camss/camss.h | 1 + 9 files changed, 1093 insertions(+), 9 deletions(-) --- base-commit: 89e965e1a58f58cd359472b14c0cc25587bcf264 change-id: 20231101-b4-camss-sc8280xp-0e1b91eb21bf Best regards,