Message ID | 20231113221528.749481-1-dmitry.baryshkov@linaro.org |
---|---|
Headers | show |
Series | dt-bindings: connector: usb: provide bindings for altmodes | expand |
On 11/13/23 23:13, Dmitry Baryshkov wrote: > Follow the bindings and use 16-bit value for AltMode SVID instead of > using the full u32. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- Fixes: b3dea914127e ("arm64: dts: qcom: qrb5165-rb5: enable DP altmode") (because it was previously not compliant with bindings) Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad
On Thu, 16 Nov 2023 at 20:36, Rob Herring <robh@kernel.org> wrote: > > On Tue, Nov 14, 2023 at 12:13:26AM +0200, Dmitry Baryshkov wrote: > > In some cases we need a way to specify USB-C AltModes that can be > > supportd on the particular USB-C connector. For example, x86 INT33FE > > driver does this by populating fwnode properties internally. For the > > Qualcomm Robotics RB5 platform (and several similar devices which use > > Qualcomm PMIC TCPM) we have to put this information to the DT. > > > > Provide the DT bindings for this kind of information and while we are at > > it, change svid property to be 16-bit unsigned integer instead of a > > simple u32. > > > > NOTE: usage of u16 is not compatible with the recenty extended > > qcom/qrb5165-rb5.dts DT file. I'm looking for the guidance from DT and > > USB maintainers whether to retain u32 usage or it's better to switch to > > u16. > > Depends if you are fine with the ABI break on this platform... As much as I hate it, yes, we are.