mbox series

[0/4] ARM: dts: qcom: msm8974: Add Samsung Galaxy S5 China support

Message ID 20240121154010.168440-1-i@rong.moe
Headers show
Series ARM: dts: qcom: msm8974: Add Samsung Galaxy S5 China support | expand

Message

Rong Zhang Jan. 21, 2024, 3:39 p.m. UTC 
Samsung Galaxy S5 has some variants, currently, the only supported one
is klte. Samsung Galaxy S5 China (kltechn) is the China edition of
klte, and it has minor difference compared to klte. It can mostly work
with klte device tree, with only LEDs and WiFi not working.

This patchset adds support for kltechn by fixing up the GPIO pins for
the /i2c-gpio-led node (a corresponding label, "i2c_led_gpio", is also
added), and adding the brcm,board-type property in the wifi@1 node of
the klte device tree to allow loading the same firmware on all klte*
variants.

Rong Zhang (4):
  ARM: dts: qcom: msm8974-samsung-klte: Add label on /i2c-gpio-led
  ARM: dts: qcom: msm8974-samsung-klte: Pin brcm,board-type in wifi
  dt-bindings: arm: qcom: add Samsung Galaxy S5 China (kltechn)
  ARM: dts: qcom: msm8974: Add device tree for Samsung Galaxy S5 China

 Documentation/devicetree/bindings/arm/qcom.yaml  |  1 +
 arch/arm/boot/dts/qcom/Makefile                  |  1 +
 .../dts/qcom/qcom-msm8974pro-samsung-klte.dts    |  8 +++++++-
 .../dts/qcom/qcom-msm8974pro-samsung-kltechn.dts | 16 ++++++++++++++++
 4 files changed, 25 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-kltechn.dts


base-commit: 7a396820222d6d4c02057f41658b162bdcdadd0e

Comments

Rong Zhang Jan. 22, 2024, 2:54 p.m. UTC | #1 
On Mon, 2024-01-22 at 10:48 +0100, Krzysztof Kozlowski wrote:
> On 21/01/2024 16:39, Rong Zhang wrote:
> > Some variants of klte, e.g., the China edition (kltechn), have minor
> > differences to differentiate them from klte. This includes the GPIO pins
> > connected to /i2c-gpio-led.
> > 
> > A label is added on /i2c-gpio-led to allow DT of other variants to
> > reference it conveniently. Considering both LEDs and a GPIO expander are
> > connected to the node, it is named "i2c_led_gpio".
> > 
> > Signed-off-by: Rong Zhang <i@rong.moe>
> > ---
> >  arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte.dts | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte.dts b/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte.dts
> > index b93539e2b87e..013946ccda0f 100644
> > --- a/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte.dts
> > +++ b/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte.dts
> > @@ -77,7 +77,7 @@ touchkey@20 {
> >  		};
> >  	};
> >  
> > -	i2c-gpio-led {
> > +	i2c_led_gpio: i2c-gpio-led {
> 
> This does not make much sense on its own. 6 commit msg lines just to add
> a label. Squash it.

Will squash it into "[PATCH 4/4] ARM: dts: qcom: msm8974: Add device
tree for Samsung Galaxy S5 China".

Thanks,
Rong


> Best regards,
> Krzysztof
>