| Message ID | 20240129-ufs-core-reset-fix-v1-0-7ac628aa735f@linaro.org |
|---|---|
| Headers | show |
| Series | ufs: qcom: Mark "core_reset" as required property | expand |
On Mon, Jan 29, 2024 at 02:57:20PM -0600, Andrew Halaney wrote: > On Mon, Jan 29, 2024 at 01:22:05PM +0530, Manivannan Sadhasivam wrote: > > core_reset is not an optional property for the platforms supported in > > upstream. Only for the non-upstreamed legacy platforms it is optional. > > But somehow a few of the upstreamed platforms do not pass this property > > by mistake. > > > > So clarify the comment to make it clear that even though core_reset is > > required, it is kept as optional to support the DTs that do not pass this > > property. > > > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > > --- > > drivers/ufs/host/ufs-qcom.c | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c > > index 39eef470f8fa..32760506dfeb 100644 > > --- a/drivers/ufs/host/ufs-qcom.c > > +++ b/drivers/ufs/host/ufs-qcom.c > > @@ -1027,7 +1027,11 @@ static int ufs_qcom_init(struct ufs_hba *hba) > > host->hba = hba; > > ufshcd_set_variant(hba, host); > > > > - /* Setup the optional reset control of HCI */ > > + /* > > + * Even though core_reset is required on all platforms, some DTs never > > + * passed this property. So we have to keep it optional for supporting > > + * them. > > + */ > > Any desire to print a warning if !host->core_reset? I'll defer to > Qualcomm to review since they can confirm the accuracy past Can's > comment, but this looks good to me for what its worth. > My only worry is that the existing users of the legacy DTs will get annoyed by the warning. And I'm not sure if we can do that. - Mani
As concluded in [1], mark the "core_reset" (UFS host controller reset from GCC) as required in the binding and also add the missing property in MSM8996 DT. However, to keep backwards compatibility with old DT, the driver cannot make it required. So it is still an optional property for the driver, but a comment has been added to clarify this. - Mani [1] https://lore.kernel.org/linux-scsi/190651ad-6aeb-69eb-89c5-ed18221b5a7a@quicinc.com/ Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> --- Manivannan Sadhasivam (3): dt-bindings: ufs: qcom: Make reset properties as required scsi: ufs: qcom: Clarify the comment of core_reset property arm64: dts: qcom: msm8996: Add missing UFS host controller reset Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 2 ++ arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 ++ drivers/ufs/host/ufs-qcom.c | 6 +++++- 3 files changed, 9 insertions(+), 1 deletion(-) --- base-commit: 6613476e225e090cc9aad49be7fa504e290dd33d change-id: 20240129-ufs-core-reset-fix-1bd4ab266f64 Best regards,