| Message ID | cover.1606917949.git.michal.simek@xilinx.com |
|---|---|
| Headers | show |
| Series | arm64: dts: zynqmp: DT updates to match latest drivers | expand |
Hi Michal, Thank you for the patch. On Wed, Dec 02, 2020 at 03:06:03PM +0100, Michal Simek wrote: > Enable reset controller for several IPs. > > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > --- > > arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 29 ++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > index 68923fbd0e89..4fa820f78d76 100644 > --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > @@ -187,6 +187,11 @@ zynqmp_pcap: pcap { > xlnx_aes: zynqmp-aes { > compatible = "xlnx,zynqmp-aes"; > }; > + > + zynqmp_reset: reset-controller { > + compatible = "xlnx,zynqmp-reset"; > + #reset-cells = <1>; > + }; > }; > }; > > @@ -466,6 +471,8 @@ gem0: ethernet@ff0b0000 { > #address-cells = <1>; > #size-cells = <0>; > power-domains = <&zynqmp_firmware PD_ETH_0>; > + resets = <&zynqmp_reset ZYNQMP_RESET_GEM0>; > + reset-names = "gem0_rst"; I don't see any of the reset-names used in this patch defined in DT bindings (or used in drivers). For all devices but the USB controllers it seems they can be dropped. For the USB controllers, the bindings need to be updated first. > }; > > gem1: ethernet@ff0c0000 { > @@ -478,6 +485,8 @@ gem1: ethernet@ff0c0000 { > #address-cells = <1>; > #size-cells = <0>; > power-domains = <&zynqmp_firmware PD_ETH_1>; > + resets = <&zynqmp_reset ZYNQMP_RESET_GEM1>; > + reset-names = "gem1_rst"; > }; > > gem2: ethernet@ff0d0000 { > @@ -490,6 +499,8 @@ gem2: ethernet@ff0d0000 { > #address-cells = <1>; > #size-cells = <0>; > power-domains = <&zynqmp_firmware PD_ETH_2>; > + resets = <&zynqmp_reset ZYNQMP_RESET_GEM2>; > + reset-names = "gem2_rst"; > }; > > gem3: ethernet@ff0e0000 { > @@ -502,6 +513,8 @@ gem3: ethernet@ff0e0000 { > #address-cells = <1>; > #size-cells = <0>; > power-domains = <&zynqmp_firmware PD_ETH_3>; > + resets = <&zynqmp_reset ZYNQMP_RESET_GEM3>; > + reset-names = "gem3_rst"; > }; > > gpio: gpio@ff0a0000 { > @@ -515,6 +528,8 @@ gpio: gpio@ff0a0000 { > #interrupt-cells = <2>; > reg = <0x0 0xff0a0000 0x0 0x1000>; > power-domains = <&zynqmp_firmware PD_GPIO>; > + resets = <&zynqmp_reset ZYNQMP_RESET_GPIO>; > + reset-names = "gpio_rst"; > }; > > i2c0: i2c@ff020000 { > @@ -526,6 +541,8 @@ i2c0: i2c@ff020000 { > #address-cells = <1>; > #size-cells = <0>; > power-domains = <&zynqmp_firmware PD_I2C_0>; > + resets = <&zynqmp_reset ZYNQMP_RESET_I2C0>; > + reset-names = "i2c0_rst"; > }; > > i2c1: i2c@ff030000 { > @@ -537,6 +554,8 @@ i2c1: i2c@ff030000 { > #address-cells = <1>; > #size-cells = <0>; > power-domains = <&zynqmp_firmware PD_I2C_1>; > + resets = <&zynqmp_reset ZYNQMP_RESET_I2C1>; > + reset-names = "i2c1_rst"; > }; > > pcie: pcie@fd0e0000 { > @@ -602,6 +621,8 @@ sata: ahci@fd0c0000 { > interrupt-parent = <&gic>; > interrupts = <0 133 4>; > power-domains = <&zynqmp_firmware PD_SATA>; > + resets = <&zynqmp_reset ZYNQMP_RESET_SATA>; > + reset-names = "sata_rst"; > }; > > sdhci0: mmc@ff160000 { > @@ -733,6 +754,10 @@ usb0: usb@fe200000 { > reg = <0x0 0xfe200000 0x0 0x40000>; > clock-names = "clk_xin", "clk_ahb"; > power-domains = <&zynqmp_firmware PD_USB_0>; > + resets = <&zynqmp_reset ZYNQMP_RESET_USB0_CORERESET>, > + <&zynqmp_reset ZYNQMP_RESET_USB0_HIBERRESET>, > + <&zynqmp_reset ZYNQMP_RESET_USB0_APB>; > + reset-names = "usb0_crst", "usb0_hibrst", "usb0_apbrst"; > }; > > usb1: usb@fe300000 { > @@ -743,6 +768,10 @@ usb1: usb@fe300000 { > reg = <0x0 0xfe300000 0x0 0x40000>; > clock-names = "clk_xin", "clk_ahb"; > power-domains = <&zynqmp_firmware PD_USB_1>; > + resets = <&zynqmp_reset ZYNQMP_RESET_USB1_CORERESET>, > + <&zynqmp_reset ZYNQMP_RESET_USB1_HIBERRESET>, > + <&zynqmp_reset ZYNQMP_RESET_USB1_APB>; > + reset-names = "usb1_crst", "usb1_hibrst", "usb1_apbrst"; > }; > > watchdog0: watchdog@fd4d0000 { -- Regards, Laurent Pinchart
On 06. 12. 20 23:38, Laurent Pinchart wrote: > Hi Michal, > > Thank you for the patch. > > On Wed, Dec 02, 2020 at 03:06:03PM +0100, Michal Simek wrote: >> Enable reset controller for several IPs. >> >> Signed-off-by: Michal Simek <michal.simek@xilinx.com> >> --- >> >> arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 29 ++++++++++++++++++++++++++ >> 1 file changed, 29 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi >> index 68923fbd0e89..4fa820f78d76 100644 >> --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi >> +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi >> @@ -187,6 +187,11 @@ zynqmp_pcap: pcap { >> xlnx_aes: zynqmp-aes { >> compatible = "xlnx,zynqmp-aes"; >> }; >> + >> + zynqmp_reset: reset-controller { >> + compatible = "xlnx,zynqmp-reset"; >> + #reset-cells = <1>; >> + }; >> }; >> }; >> >> @@ -466,6 +471,8 @@ gem0: ethernet@ff0b0000 { >> #address-cells = <1>; >> #size-cells = <0>; >> power-domains = <&zynqmp_firmware PD_ETH_0>; >> + resets = <&zynqmp_reset ZYNQMP_RESET_GEM0>; >> + reset-names = "gem0_rst"; > > I don't see any of the reset-names used in this patch defined in DT > bindings (or used in drivers). For all devices but the USB controllers > it seems they can be dropped. For the USB controllers, the bindings need > to be updated first. Let me double check it. IIRC if there is just one there is likely no need to list the name but if there are more then one names should be also there. But you are right it should be the part of dt binding. Thanks, Michal
Hi, On 12/7/20 10:32 AM, Michal Simek wrote: > > > On 06. 12. 20 23:38, Laurent Pinchart wrote: >> Hi Michal, >> >> Thank you for the patch. >> >> On Wed, Dec 02, 2020 at 03:06:03PM +0100, Michal Simek wrote: >>> Enable reset controller for several IPs. >>> >>> Signed-off-by: Michal Simek <michal.simek@xilinx.com> >>> --- >>> >>> arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 29 ++++++++++++++++++++++++++ >>> 1 file changed, 29 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi >>> index 68923fbd0e89..4fa820f78d76 100644 >>> --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi >>> +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi >>> @@ -187,6 +187,11 @@ zynqmp_pcap: pcap { >>> xlnx_aes: zynqmp-aes { >>> compatible = "xlnx,zynqmp-aes"; >>> }; >>> + >>> + zynqmp_reset: reset-controller { >>> + compatible = "xlnx,zynqmp-reset"; >>> + #reset-cells = <1>; >>> + }; >>> }; >>> }; >>> >>> @@ -466,6 +471,8 @@ gem0: ethernet@ff0b0000 { >>> #address-cells = <1>; >>> #size-cells = <0>; >>> power-domains = <&zynqmp_firmware PD_ETH_0>; >>> + resets = <&zynqmp_reset ZYNQMP_RESET_GEM0>; >>> + reset-names = "gem0_rst"; >> >> I don't see any of the reset-names used in this patch defined in DT >> bindings (or used in drivers). For all devices but the USB controllers >> it seems they can be dropped. For the USB controllers, the bindings need >> to be updated first. > > Let me double check it. IIRC if there is just one there is likely no > need to list the name but if there are more then one names should be > also there. But you are right it should be the part of dt binding. I will skip this patch. Thanks, Michal