From patchwork Tue Mar 30 17:48:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sander Vanheule X-Patchwork-Id: 411840 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C687C433C1 for ; Tue, 30 Mar 2021 17:50:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CE7C1619D2 for ; Tue, 30 Mar 2021 17:50:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232519AbhC3Rt2 (ORCPT ); Tue, 30 Mar 2021 13:49:28 -0400 Received: from polaris.svanheule.net ([84.16.241.116]:49802 "EHLO polaris.svanheule.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232459AbhC3RtE (ORCPT ); Tue, 30 Mar 2021 13:49:04 -0400 Received: from terra.local.svanheule.net (47.118-244-81.adsl-dyn.isp.belgacom.be [81.244.118.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: sander@svanheule.net) by polaris.svanheule.net (Postfix) with ESMTPSA id 638021E7EA0; Tue, 30 Mar 2021 19:48:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=svanheule.net; s=mail1707; t=1617126537; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nCFGQouq1/RHGcmybWwvVFLi0aJCyfwl4mdLTH6VcuI=; b=KYX0qnZpNcuMZqAegQ7XvtrXLfVIa7L3FDUxaqVq41ZZGvZ4sMLwOvNMnikTiMZxKO/lIR qCmX7GvRGZ7TE7ljUoxu2jVIx+e1utteWPMLIuvj9nF3/s6EG24Nb1HGhsvKrh+GQYB1DK u2rGxCHymbSwA1c194tOrr4hMztCAkNdWQY+b1GyqaxMx7fHRKmNwIMHbmTymCj6w3iEvs 9vPDbA3IBTJboD0nzCSwvmtJUai4l8JXxvxf0WSUkGIz3fkvHakP9dtELGf9EXb/LxHoQ5 1t4PvtCAXsEN17OKUKV6Qt5j1D4GFmYPqWVZhsvwOwyedmhrrmokbhNiBsxxNQ== From: Sander Vanheule To: devicetree@vger.kernel.org, linux-gpio@vger.kernel.org Cc: andy.shevchenko@gmail.com, bert@biot.com, bgolaszewski@baylibre.com, linus.walleij@linaro.org, linux-kernel@vger.kernel.org, maz@kernel.org, robh+dt@kernel.org, Sander Vanheule Subject: [PATCH v6 0/2] Add Realtek Otto GPIO support Date: Tue, 30 Mar 2021 19:48:41 +0200 Message-Id: X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210315082339.9787-1-sander@svanheule.net> References: <20210315082339.9787-1-sander@svanheule.net> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Add support for the GPIO controller employed by Realtek in multiple series of MIPS SoCs. These include the supported RTL838x and RTL839x. The register layout also matches the one found in the GPIO controller of other (Lexra-based) SoCs such as RTL8196E, RTL8197D, and RTL8197F. For the platform name 'otto', I am not aware of any official resources as to what hardware this specifically applies to. However, in all of the GPL archives we've received, from vendors using compatible SoCs in their design, the platform under the MIPS architecture is referred to by this name. The GPIO ports have been tested on a Zyxel GS1900-8 (RTL8380), and Zyxel GS1900-48 (RTL8393). Furthermore, the GPIO ports and interrupt controller have been tested on a Netgear GS110TPPv1 (RTL8381). Changes in v6: - Use devm_gpiochip_add_data() - Code style for reading ngpios, header order - Add Andy's Reviewed-by tag Changes in v5: - Edited code comments - Fold functions that were used only once or twice (ISR/IMR accessors) - Drop trivial functions for line to port/pin calculations - Use gpio_irq_chip->init_hw() to initialise IRQ registers - Invert GPIO_INTERRUPTS flag to GPIO_INTERRUPTS_DISABLED - Support building as module - Add Rob's Reviewed-by tag Changes in v4: - Fix pointer notation style - Drop unused read_u16_reg() function - Drop 'inline' specifier from functions Changes in v3: - Remove OF dependencies in driver probe - Don't accept IRQ_TYPE_NONE as a valid interrupt type - Remove (now unused) dev property from control structure - Use u8/u16 port registers, instead of raw u32 registers - Use 'line' name for gpiochip, 'port' and 'pin' names for hardware - Renamed DT bindings file - Dropped fallback-only DT compatible - Various code style clean-ups Changes in v2: - Clarify structure and usage of IMR registers - Added Linus' Reviewed-by tags Sander Vanheule (2): dt-bindings: gpio: Binding for Realtek Otto GPIO gpio: Add Realtek Otto GPIO support .../bindings/gpio/realtek,otto-gpio.yaml | 78 +++++ drivers/gpio/Kconfig | 13 + drivers/gpio/Makefile | 1 + drivers/gpio/gpio-realtek-otto.c | 325 ++++++++++++++++++ 4 files changed, 417 insertions(+) create mode 100644 Documentation/devicetree/bindings/gpio/realtek,otto-gpio.yaml create mode 100644 drivers/gpio/gpio-realtek-otto.c