From patchwork Fri Nov 13 20:18:35 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 56554 Delivered-To: patch@linaro.org Received: by 10.112.155.196 with SMTP id vy4csp1257349lbb; Fri, 13 Nov 2015 12:18:43 -0800 (PST) X-Received: by 10.66.101.2 with SMTP id fc2mr35167194pab.139.1447445923524; Fri, 13 Nov 2015 12:18:43 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id iu1si29368380pbb.48.2015.11.13.12.18.43; Fri, 13 Nov 2015 12:18:43 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dkim=neutral (body hash did not verify) header.i=@linaro_org.20150623.gappssmtp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754772AbbKMUSm (ORCPT + 6 others); Fri, 13 Nov 2015 15:18:42 -0500 Received: from mail-lb0-f172.google.com ([209.85.217.172]:36254 "EHLO mail-lb0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754714AbbKMUSl (ORCPT ); Fri, 13 Nov 2015 15:18:41 -0500 Received: by lbblt2 with SMTP id lt2so60533039lbb.3 for ; Fri, 13 Nov 2015 12:18:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro_org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=NUrgCfAxkAiY3+nqch7XUEHBQNOR7RVif1zvlMjOdQY=; b=e8AaUnWwJBKvRO0c//O0w9pKu/KrXGEbnVaSbe6qL6L5sMV7whcZx0HLJhz7nPD3sZ Z6K4Udb0X4fMhOB7QVQJly50UcgrNF9wqFNisImatvlb3jw3obTu/XK9+/Iu6ZT3KrYU 4zotFuD1kkiKKY+9Xjhld3T2+bgHYlajwkimMA5RpYAqWTGRpGxMMKpP4Nbb+ylbEuVM 7AjjEQ7XdRfm1H1/oFqen1Sp8xl0wcZKP+6cNkTtYkvuMwNu2Vpr+8CpeeLkCMKawR+A SW7kMoS7H9YvF/BPE5SXfXIIzMHVsB6jX1t9XZUmyqX3xXNNYhhz1nHdI7Qw534Nm8s8 C17A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=NUrgCfAxkAiY3+nqch7XUEHBQNOR7RVif1zvlMjOdQY=; b=k/c8mjvx4ZmIwU+BrMb8bdqro5B74RMnbtXTXp4pebTUjZoSQ4Q3FS8i/222it51W2 PA4hcTEFdbTaaWbiOc2XA5MS89VspEagVX55IZMR4qGsSNjwQPfPcAU9cDAMm2VM7lme b6bVRCCE+ty7MevEFyFcs0cmogbc9J3Rx0v2LJIK/yfN1+5uOo1sgx1jdcyDd70b1tlZ 9OOtM9AAsBGpIZg8PJnws5xaxrJ8ob4zsqz2NHwcmaOAoaWuWMTg1888gBxTRD2HKvMe FepxgeewzzlJIP0khe6C9M5MSkkR7xWSciKDG86+q8f5pGAjjYIXtONco7l7z5PASBVi KcaA== X-Gm-Message-State: ALoCoQnTubyzsC8N/HArkKbfCqBMdcOVlynkg7Vk7uCQGaN514+Lw8ojDAgdzaKRthNLzdVI+YQ3 X-Received: by 10.112.144.225 with SMTP id sp1mr11057854lbb.97.1447445919717; Fri, 13 Nov 2015 12:18:39 -0800 (PST) Received: from localhost.localdomain.localdomain (c-297471d5.01-192-6c756e10.cust.bredbandsbolaget.se. [213.113.116.41]) by smtp.gmail.com with ESMTPSA id pd9sm586737lbc.48.2015.11.13.12.18.38 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Nov 2015 12:18:39 -0800 (PST) From: Linus Walleij To: Jonathan Cameron , linux-iio@vger.kernel.org Cc: Linus Walleij , devicetree@vger.kernel.org, Giuseppe Barba , Denis Ciocca Subject: [PATCH 2/2] iio: st_sensors: support open drain mode Date: Fri, 13 Nov 2015 21:18:35 +0100 Message-Id: <1447445915-12704-1-git-send-email-linus.walleij@linaro.org> X-Mailer: git-send-email 2.4.3 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Some types of ST Sensors can be connected to the same IRQ line as other peripherals using open drain. Add a device tree binding and a sensor data property to flip the right bit in the interrupt control register to enable open drain mode on the INT line. If the line is set to be open drain, also tag on IRQF_SHARED to the IRQ flags when requesting the interrupt, as the whole point of using open drain interrupt lines is to share them with more than one peripheral (wire-or). Cc: devicetree@vger.kernel.org Cc: Giuseppe Barba Cc: Denis Ciocca Signed-off-by: Linus Walleij --- Documentation/devicetree/bindings/iio/st-sensors.txt | 3 +++ drivers/iio/accel/st_accel_core.c | 8 ++++++++ drivers/iio/common/st_sensors/st_sensors_core.c | 20 ++++++++++++++++++++ drivers/iio/common/st_sensors/st_sensors_trigger.c | 9 +++++++++ drivers/iio/gyro/st_gyro_core.c | 12 ++++++++++++ drivers/iio/pressure/st_pressure_core.c | 8 ++++++++ include/linux/iio/common/st_sensors.h | 6 ++++++ include/linux/platform_data/st_sensors_pdata.h | 2 ++ 8 files changed, 68 insertions(+) -- 2.4.3 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Acked-by: Rob Herring diff --git a/Documentation/devicetree/bindings/iio/st-sensors.txt b/Documentation/devicetree/bindings/iio/st-sensors.txt index d3ccdb190c53..4ac20cb2ae8d 100644 --- a/Documentation/devicetree/bindings/iio/st-sensors.txt +++ b/Documentation/devicetree/bindings/iio/st-sensors.txt @@ -16,6 +16,9 @@ Optional properties: - st,drdy-int-pin: the pin on the package that will be used to signal "data ready" (valid values: 1 or 2). This property is not configurable on all sensors. +- st,int-pin-open-drain: the interrupt/data ready line will be configured + as open drain, which is useful if several sensors share the same + interrupt line. Sensors may also have applicable pin control settings, those use the standard bindings from pinctrl/pinctrl-bindings.txt. diff --git a/drivers/iio/accel/st_accel_core.c b/drivers/iio/accel/st_accel_core.c index 1132224cbc10..888682b95693 100644 --- a/drivers/iio/accel/st_accel_core.c +++ b/drivers/iio/accel/st_accel_core.c @@ -96,6 +96,8 @@ #define ST_ACCEL_2_DRDY_IRQ_INT2_MASK 0x10 #define ST_ACCEL_2_IHL_IRQ_ADDR 0x22 #define ST_ACCEL_2_IHL_IRQ_MASK 0x80 +#define ST_ACCEL_2_OD_IRQ_ADDR 0x22 +#define ST_ACCEL_2_OD_IRQ_MASK 0x40 #define ST_ACCEL_2_MULTIREAD_BIT true /* CUSTOM VALUES FOR SENSOR 3 */ @@ -177,6 +179,8 @@ #define ST_ACCEL_5_DRDY_IRQ_INT2_MASK 0x20 #define ST_ACCEL_5_IHL_IRQ_ADDR 0x22 #define ST_ACCEL_5_IHL_IRQ_MASK 0x80 +#define ST_ACCEL_5_OD_IRQ_ADDR 0x22 +#define ST_ACCEL_5_OD_IRQ_MASK 0x40 #define ST_ACCEL_5_IG1_EN_ADDR 0x21 #define ST_ACCEL_5_IG1_EN_MASK 0x08 #define ST_ACCEL_5_MULTIREAD_BIT false @@ -366,6 +370,8 @@ static const struct st_sensor_settings st_accel_sensors_settings[] = { .mask_int2 = ST_ACCEL_2_DRDY_IRQ_INT2_MASK, .addr_ihl = ST_ACCEL_2_IHL_IRQ_ADDR, .mask_ihl = ST_ACCEL_2_IHL_IRQ_MASK, + .addr_od = ST_ACCEL_2_OD_IRQ_ADDR, + .mask_od = ST_ACCEL_2_OD_IRQ_MASK, }, .multi_read_bit = ST_ACCEL_2_MULTIREAD_BIT, .bootime = 2, @@ -552,6 +558,8 @@ static const struct st_sensor_settings st_accel_sensors_settings[] = { .mask_int2 = ST_ACCEL_5_DRDY_IRQ_INT2_MASK, .addr_ihl = ST_ACCEL_5_IHL_IRQ_ADDR, .mask_ihl = ST_ACCEL_5_IHL_IRQ_MASK, + .addr_od = ST_ACCEL_5_OD_IRQ_ADDR, + .mask_od = ST_ACCEL_5_OD_IRQ_MASK, }, .multi_read_bit = ST_ACCEL_5_MULTIREAD_BIT, .bootime = 2, /* guess */ diff --git a/drivers/iio/common/st_sensors/st_sensors_core.c b/drivers/iio/common/st_sensors/st_sensors_core.c index ed6f54d5c932..bff469dd9583 100644 --- a/drivers/iio/common/st_sensors/st_sensors_core.c +++ b/drivers/iio/common/st_sensors/st_sensors_core.c @@ -302,6 +302,14 @@ static int st_sensors_set_drdy_int_pin(struct iio_dev *indio_dev, return -EINVAL; } + if (pdata->open_drain) { + if (!sdata->sensor_settings->drdy_irq.addr_od) + dev_err(&indio_dev->dev, + "open drain requested but unsupported.\n"); + else + sdata->int_pin_open_drain = true; + } + return 0; } @@ -322,6 +330,8 @@ static struct st_sensors_platform_data *st_sensors_of_probe(struct device *dev, else pdata->drdy_int_pin = defdata ? defdata->drdy_int_pin : 0; + pdata->open_drain = of_property_read_bool(np, "st,int-pin-open-drain"); + return pdata; } #else @@ -375,6 +385,16 @@ int st_sensors_init_sensor(struct iio_dev *indio_dev, return err; } + if (sdata->int_pin_open_drain) { + dev_info(&indio_dev->dev, + "set interrupt line to open drain mode\n"); + err = st_sensors_write_data_with_mask(indio_dev, + sdata->sensor_settings->drdy_irq.addr_od, + sdata->sensor_settings->drdy_irq.mask_od, 1); + if (err < 0) + return err; + } + err = st_sensors_set_axis_enable(indio_dev, ST_SENSORS_ENABLE_ALL_AXIS); return err; diff --git a/drivers/iio/common/st_sensors/st_sensors_trigger.c b/drivers/iio/common/st_sensors/st_sensors_trigger.c index cb53d14aca94..4283468fd502 100644 --- a/drivers/iio/common/st_sensors/st_sensors_trigger.c +++ b/drivers/iio/common/st_sensors/st_sensors_trigger.c @@ -67,6 +67,15 @@ int st_sensors_allocate_trigger(struct iio_dev *indio_dev, "rising edge\n", irq_trig); irq_trig = IRQF_TRIGGER_RISING; } + + /* + * If the interrupt pin is Open Drain, by definition this + * means that the interrupt line may be shared with other + * peripherals. + */ + if (sdata->int_pin_open_drain) + irq_trig |= IRQF_SHARED; + err = request_any_context_irq(irq, iio_trigger_generic_data_rdy_poll, irq_trig, diff --git a/drivers/iio/gyro/st_gyro_core.c b/drivers/iio/gyro/st_gyro_core.c index 260bfe021904..d53622b0e430 100644 --- a/drivers/iio/gyro/st_gyro_core.c +++ b/drivers/iio/gyro/st_gyro_core.c @@ -63,6 +63,8 @@ #define ST_GYRO_1_DRDY_IRQ_INT2_MASK 0x08 #define ST_GYRO_1_IHL_IRQ_ADDR 0x22 #define ST_GYRO_1_IHL_IRQ_MASK 0x20 +#define ST_GYRO_1_OD_IRQ_ADDR 0x22 +#define ST_GYRO_1_OD_IRQ_MASK 0x10 #define ST_GYRO_1_MULTIREAD_BIT true /* CUSTOM VALUES FOR SENSOR 2 */ @@ -89,6 +91,8 @@ #define ST_GYRO_2_DRDY_IRQ_INT2_MASK 0x08 #define ST_GYRO_2_IHL_IRQ_ADDR 0x22 #define ST_GYRO_2_IHL_IRQ_MASK 0x20 +#define ST_GYRO_2_OD_IRQ_ADDR 0x22 +#define ST_GYRO_2_OD_IRQ_MASK 0x10 #define ST_GYRO_2_MULTIREAD_BIT true /* CUSTOM VALUES FOR SENSOR 3 */ @@ -115,6 +119,8 @@ #define ST_GYRO_3_DRDY_IRQ_INT2_MASK 0x08 #define ST_GYRO_3_IHL_IRQ_ADDR 0x22 #define ST_GYRO_3_IHL_IRQ_MASK 0x20 +#define ST_GYRO_3_OD_IRQ_ADDR 0x22 +#define ST_GYRO_3_OD_IRQ_MASK 0x10 #define ST_GYRO_3_MULTIREAD_BIT true @@ -193,6 +199,8 @@ static const struct st_sensor_settings st_gyro_sensors_settings[] = { .mask_int2 = ST_GYRO_1_DRDY_IRQ_INT2_MASK, .addr_ihl = ST_GYRO_1_IHL_IRQ_ADDR, .mask_ihl = ST_GYRO_1_IHL_IRQ_MASK, + .addr_od = ST_GYRO_1_OD_IRQ_ADDR, + .mask_od = ST_GYRO_1_OD_IRQ_MASK, }, .multi_read_bit = ST_GYRO_1_MULTIREAD_BIT, .bootime = 2, @@ -258,6 +266,8 @@ static const struct st_sensor_settings st_gyro_sensors_settings[] = { .mask_int2 = ST_GYRO_2_DRDY_IRQ_INT2_MASK, .addr_ihl = ST_GYRO_2_IHL_IRQ_ADDR, .mask_ihl = ST_GYRO_2_IHL_IRQ_MASK, + .addr_od = ST_GYRO_2_OD_IRQ_ADDR, + .mask_od = ST_GYRO_2_OD_IRQ_MASK, }, .multi_read_bit = ST_GYRO_2_MULTIREAD_BIT, .bootime = 2, @@ -319,6 +329,8 @@ static const struct st_sensor_settings st_gyro_sensors_settings[] = { .mask_int2 = ST_GYRO_3_DRDY_IRQ_INT2_MASK, .addr_ihl = ST_GYRO_3_IHL_IRQ_ADDR, .mask_ihl = ST_GYRO_3_IHL_IRQ_MASK, + .addr_od = ST_GYRO_3_OD_IRQ_ADDR, + .mask_od = ST_GYRO_3_OD_IRQ_MASK, }, .multi_read_bit = ST_GYRO_3_MULTIREAD_BIT, .bootime = 2, diff --git a/drivers/iio/pressure/st_pressure_core.c b/drivers/iio/pressure/st_pressure_core.c index 172393ad34af..38186288f79c 100644 --- a/drivers/iio/pressure/st_pressure_core.c +++ b/drivers/iio/pressure/st_pressure_core.c @@ -64,6 +64,8 @@ #define ST_PRESS_LPS331AP_DRDY_IRQ_INT2_MASK 0x20 #define ST_PRESS_LPS331AP_IHL_IRQ_ADDR 0x22 #define ST_PRESS_LPS331AP_IHL_IRQ_MASK 0x80 +#define ST_PRESS_LPS331AP_OD_IRQ_ADDR 0x22 +#define ST_PRESS_LPS331AP_OD_IRQ_MASK 0x40 #define ST_PRESS_LPS331AP_MULTIREAD_BIT true #define ST_PRESS_LPS331AP_TEMP_OFFSET 42500 @@ -104,6 +106,8 @@ #define ST_PRESS_LPS25H_DRDY_IRQ_INT2_MASK 0x10 #define ST_PRESS_LPS25H_IHL_IRQ_ADDR 0x22 #define ST_PRESS_LPS25H_IHL_IRQ_MASK 0x80 +#define ST_PRESS_LPS25H_OD_IRQ_ADDR 0x22 +#define ST_PRESS_LPS25H_OD_IRQ_MASK 0x40 #define ST_PRESS_LPS25H_MULTIREAD_BIT true #define ST_PRESS_LPS25H_TEMP_OFFSET 42500 #define ST_PRESS_LPS25H_OUT_XL_ADDR 0x28 @@ -226,6 +230,8 @@ static const struct st_sensor_settings st_press_sensors_settings[] = { .mask_int2 = ST_PRESS_LPS331AP_DRDY_IRQ_INT2_MASK, .addr_ihl = ST_PRESS_LPS331AP_IHL_IRQ_ADDR, .mask_ihl = ST_PRESS_LPS331AP_IHL_IRQ_MASK, + .addr_od = ST_PRESS_LPS331AP_OD_IRQ_ADDR, + .mask_od = ST_PRESS_LPS331AP_OD_IRQ_MASK, }, .multi_read_bit = ST_PRESS_LPS331AP_MULTIREAD_BIT, .bootime = 2, @@ -312,6 +318,8 @@ static const struct st_sensor_settings st_press_sensors_settings[] = { .mask_int2 = ST_PRESS_LPS25H_DRDY_IRQ_INT2_MASK, .addr_ihl = ST_PRESS_LPS25H_IHL_IRQ_ADDR, .mask_ihl = ST_PRESS_LPS25H_IHL_IRQ_MASK, + .addr_od = ST_PRESS_LPS25H_OD_IRQ_ADDR, + .mask_od = ST_PRESS_LPS25H_OD_IRQ_MASK, }, .multi_read_bit = ST_PRESS_LPS25H_MULTIREAD_BIT, .bootime = 2, diff --git a/include/linux/iio/common/st_sensors.h b/include/linux/iio/common/st_sensors.h index 6670c3d25c58..8972101224d9 100644 --- a/include/linux/iio/common/st_sensors.h +++ b/include/linux/iio/common/st_sensors.h @@ -121,6 +121,8 @@ struct st_sensor_bdu { * @mask_int2: mask to enable/disable IRQ on INT2 pin. * @addr_ihl: address to enable/disable active low on the INT lines. * @mask_ihl: mask to enable/disable active low on the INT lines. + * @addr_od: address to enable/disable Open Drain on the INT lines. + * @mask_od: mask to enable/disable Open Drain on the INT lines. * struct ig1 - represents the Interrupt Generator 1 of sensors. * @en_addr: address of the enable ig1 register. * @en_mask: mask to write the on/off value for enable. @@ -131,6 +133,8 @@ struct st_sensor_data_ready_irq { u8 mask_int2; u8 addr_ihl; u8 mask_ihl; + u8 addr_od; + u8 mask_od; struct { u8 en_addr; u8 en_mask; @@ -212,6 +216,7 @@ struct st_sensor_settings { * @odr: Output data rate of the sensor [Hz]. * num_data_channels: Number of data channels used in buffer. * @drdy_int_pin: Redirect DRDY on pin 1 (1) or pin 2 (2). + * @int_pin_open_drain: Set the interrupt/DRDY to open drain. * @get_irq_data_ready: Function to get the IRQ used for data ready signal. * @tf: Transfer function structure used by I/O operations. * @tb: Transfer buffers and mutex used by I/O operations. @@ -233,6 +238,7 @@ struct st_sensor_data { unsigned int num_data_channels; u8 drdy_int_pin; + bool int_pin_open_drain; unsigned int (*get_irq_data_ready) (struct iio_dev *indio_dev); diff --git a/include/linux/platform_data/st_sensors_pdata.h b/include/linux/platform_data/st_sensors_pdata.h index 753839187ba0..79b0e4cdb814 100644 --- a/include/linux/platform_data/st_sensors_pdata.h +++ b/include/linux/platform_data/st_sensors_pdata.h @@ -16,9 +16,11 @@ * @drdy_int_pin: Redirect DRDY on pin 1 (1) or pin 2 (2). * Available only for accelerometer and pressure sensors. * Accelerometer DRDY on LSM330 available only on pin 1 (see datasheet). + * @open_drain: set the interrupt line to be open drain if possible. */ struct st_sensors_platform_data { u8 drdy_int_pin; + bool open_drain; }; #endif /* ST_SENSORS_PDATA_H */