From patchwork Tue May 2 08:30:02 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leo Yan X-Patchwork-Id: 98426 Delivered-To: patch@linaro.org Received: by 10.140.109.52 with SMTP id k49csp1764895qgf; Tue, 2 May 2017 01:33:13 -0700 (PDT) X-Received: by 10.84.131.1 with SMTP id 1mr39463786pld.40.1493713993091; Tue, 02 May 2017 01:33:13 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n7si16246649pfb.146.2017.05.02.01.33.12; Tue, 02 May 2017 01:33:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751361AbdEBIbn (ORCPT + 7 others); Tue, 2 May 2017 04:31:43 -0400 Received: from mail-pg0-f47.google.com ([74.125.83.47]:34100 "EHLO mail-pg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751152AbdEBIbe (ORCPT ); Tue, 2 May 2017 04:31:34 -0400 Received: by mail-pg0-f47.google.com with SMTP id v1so57547354pgv.1 for ; Tue, 02 May 2017 01:31:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=m9+q8JDelOVj/ZckmVQTO6fonsB9djpN0ZzNAARA5j4=; b=B2sXS/OQRulXH7ENhsRp3rlNPaOmyR22JEbhny9XKq/PZ6qGNaEC+u8iRQbXDNMN5O x9vEOfMX3K5gIH4mCa3E62Sos/AB2/Bu87fXP5LOwRF3U4WuD2fpq+W4XlqkDvW71dSQ nTJ+TSsliGFd0IoPji5A66Xv9tr5TT7IpBg/M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=m9+q8JDelOVj/ZckmVQTO6fonsB9djpN0ZzNAARA5j4=; b=e1T1+C295MJ98iqTCYRQtkK2gjgVnPRiwtN/dyMEo0OYdB+/u6H9eJDVWkBdFeBHfl B1nCFV9Krq5PDFO9wFA+WGerQOGNtlAZDQdup5dTkuLBdRnk4XMeujJLs5/Oz4kMnndg AbiiQLDjyY92Jd2Q1wYm+jrnT/Y8RzH4qAd+2PjBtk/WGxxtbgU5p1Nh50GznoYjb0HW 2la3eGspJnkG5sn70k9X5G7UBaA0QAB6kMVngrH+TVJHHXwY8u+m4al3Eui5CpWmW5Nx C0mw5OWl2ccbBYgoNzBXRtiAluFGV0Kd5F7sfy2TfsSUcKDVYyESUwu+346vnQSTw5Bj A+EA== X-Gm-Message-State: AN3rC/7Nr7LL5LRPdWjkBD2gdvaFlienGT64jeu0CbKI93ht3A7C84xr WF/q/igPB43E2Tnu X-Received: by 10.98.223.5 with SMTP id u5mr31225884pfg.147.1493713888881; Tue, 02 May 2017 01:31:28 -0700 (PDT) Received: from localhost.localdomain (45-125-195-13.ip4.readyserver.sg. [45.125.195.13]) by smtp.gmail.com with ESMTPSA id g89sm29047829pfk.25.2017.05.02.01.31.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 02 May 2017 01:31:27 -0700 (PDT) From: Leo Yan To: Jonathan Corbet , Rob Herring , Mark Rutland , Wei Xu , Catalin Marinas , Will Deacon , Andy Gross , David Brown , Mathieu Poirier , Greg Kroah-Hartman , Suzuki K Poulose , Stephen Boyd , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, Mike Leach , Sudeep Holla Cc: Leo Yan Subject: [PATCH v7 4/7] coresight: refactor with function of_coresight_get_cpu Date: Tue, 2 May 2017 16:30:02 +0800 Message-Id: <1493713805-26920-5-git-send-email-leo.yan@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1493713805-26920-1-git-send-email-leo.yan@linaro.org> References: <1493713805-26920-1-git-send-email-leo.yan@linaro.org> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org This is refactor to add function of_coresight_get_cpu(), so it's used to retrieve CPU id for coresight component. Finally can use it as a common function for multiple places. Suggested-by: Mathieu Poirier Reviewed-by: Suzuki K Poulose Signed-off-by: Leo Yan --- drivers/hwtracing/coresight/of_coresight.c | 43 +++++++++++++++++++----------- include/linux/coresight.h | 2 ++ 2 files changed, 30 insertions(+), 15 deletions(-) -- 2.7.4 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/hwtracing/coresight/of_coresight.c b/drivers/hwtracing/coresight/of_coresight.c index de7e8ce..46eec0f 100644 --- a/drivers/hwtracing/coresight/of_coresight.c +++ b/drivers/hwtracing/coresight/of_coresight.c @@ -101,15 +101,39 @@ static int of_coresight_alloc_memory(struct device *dev, return 0; } +int of_coresight_get_cpu(const struct device_node *node) +{ + int cpu; + bool found; + struct device_node *dn, *np; + + dn = of_parse_phandle(node, "cpu", 0); + + /* Affinity defaults to CPU0 */ + if (!dn) + return 0; + + for_each_possible_cpu(cpu) { + np = of_cpu_device_node_get(cpu); + found = (dn == np); + of_node_put(np); + if (found) + break; + } + of_node_put(dn); + + /* Affinity to CPU0 if no cpu nodes are found */ + return found ? cpu : 0; +} +EXPORT_SYMBOL_GPL(of_coresight_get_cpu); + struct coresight_platform_data *of_get_coresight_platform_data( struct device *dev, const struct device_node *node) { - int i = 0, ret = 0, cpu; + int i = 0, ret = 0; struct coresight_platform_data *pdata; struct of_endpoint endpoint, rendpoint; struct device *rdev; - bool found; - struct device_node *dn, *np; struct device_node *ep = NULL; struct device_node *rparent = NULL; struct device_node *rport = NULL; @@ -176,18 +200,7 @@ struct coresight_platform_data *of_get_coresight_platform_data( } while (ep); } - dn = of_parse_phandle(node, "cpu", 0); - for_each_possible_cpu(cpu) { - np = of_cpu_device_node_get(cpu); - found = (dn == np); - of_node_put(np); - if (found) - break; - } - of_node_put(dn); - - /* Affinity to CPU0 if no cpu nodes are found */ - pdata->cpu = found ? cpu : 0; + pdata->cpu = of_coresight_get_cpu(node); return pdata; } diff --git a/include/linux/coresight.h b/include/linux/coresight.h index 769f2c8..4915254 100644 --- a/include/linux/coresight.h +++ b/include/linux/coresight.h @@ -263,9 +263,11 @@ static inline int coresight_timeout(void __iomem *addr, u32 offset, #endif #ifdef CONFIG_OF +extern int of_coresight_get_cpu(const struct device_node *node); extern struct coresight_platform_data *of_get_coresight_platform_data( struct device *dev, const struct device_node *node); #else +static inline int of_coresight_get_cpu(const struct device_node *node) { return 0; } static inline struct coresight_platform_data *of_get_coresight_platform_data( struct device *dev, const struct device_node *node) { return NULL; } #endif