From patchwork Tue Oct 16 14:00:20 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Lezcano X-Patchwork-Id: 148943 Delivered-To: patch@linaro.org Received: by 2002:a2e:8595:0:0:0:0:0 with SMTP id b21-v6csp5129340lji; Tue, 16 Oct 2018 07:01:28 -0700 (PDT) X-Google-Smtp-Source: ACcGV63U1sSuB0J4Rxc+2AgP97uh3xPvXTlOiApQyntRF0x7F1w3uT6KkllQduc1g9GcWEyq04sq X-Received: by 2002:a62:5698:: with SMTP id h24-v6mr22769486pfj.42.1539698488313; Tue, 16 Oct 2018 07:01:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539698488; cv=none; d=google.com; s=arc-20160816; b=KiGGS6GbECmHz9p0i74rz2VQfSb2UoEY9PmnL4ciF0fGry/C9agN509MZKRT8Pj+5M dedtFccIPq6QlDltfNR/NjxbiOxeXUA+o2bW51suJCJItq4qAmzz4rhU+y54TGl5+fDJ MuRUhk/YKpmqwR0CT0hOmG44V90wBJgaoXRmBbRx8I2vbF9VLW1vywknLfQ/isWaz/Sd kM5+gHhKVh0l+h9yF1BDOZQI16L2offRe1Kzl6tOnJCXaqE8K9BAFtI//MpPQlJnN19q kIXJFE60nP56wV9X93J4IAG2fjq8CdzjOZbzhjBIcZ5AusuROd0AQrkOcBj/dq/kFPn2 08jA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=AyjUgKMFmAFThaK4GvWsdrdl4JZ3kTa6zVPrOmGMjOA=; b=d3rW1Ij+uRJS7vo739HBnYVJF/fh/Hjzt5AJNb+EeTQDJ3MTtftpVequ5pSQEiZAbe xOWeJExgtYqi9jtcn0JMqiyq+teAH2Nl+lclGJgNAY9oKx2veaZMnwPQvMLU9rqMko9J Q8d6p4H69cHqBpCRPp7CqxjJaFPwACdGtAIKdv+cJaTPKRVuuRoYpc2HtaIz4q00qJSV DF/oIDlPL3/AsifG4ZRN6HHv85amOBCKJMAJmcYnty8sBk9jhiq0nGHsp2OMCTigL0Yk /9dH52y4N82hYO/78Hu7ehDEcpA0Yta0VE0olNw93Wxplv301nsIUzi0Qd9AIqew59yv DR4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=OwrJnI6D; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 207-v6si14441772pfu.273.2018.10.16.07.01.27; Tue, 16 Oct 2018 07:01:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=OwrJnI6D; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727155AbeJPVv6 (ORCPT + 6 others); Tue, 16 Oct 2018 17:51:58 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:40721 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727124AbeJPVv6 (ORCPT ); Tue, 16 Oct 2018 17:51:58 -0400 Received: by mail-wr1-f65.google.com with SMTP id d2-v6so25691296wro.7 for ; Tue, 16 Oct 2018 07:01:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=AyjUgKMFmAFThaK4GvWsdrdl4JZ3kTa6zVPrOmGMjOA=; b=OwrJnI6D/huHRM5jiagiGiKBxUHFUlMvwe1t2GexoIKOTqtFGY3vwPCkrAUWdnT5+f n+wvqEq+enR14QpmLTY3VNYAsxMcDtJOZ2R2Cw0rRdiHypMeUGRanfszUimV9omTlSGH ApMgMERT+Pim+X1tp/uH775sDaVLHsJDyJb2Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=AyjUgKMFmAFThaK4GvWsdrdl4JZ3kTa6zVPrOmGMjOA=; b=iE3oKz7AoP26BhTGzcqh/SLoppNXtS3VxI8tPbi8YwtwDd91ZW4QNCp515Y16y+fH1 RFKorTi4A6oOdqb6/NylbMAB6jM8i4jYo9MTHuMbZWhLE6WOVME4BYtR4VNvhhHylyvF +5aquFcyrGmx1CMYHdnJE4IXBrZtlva18+Krc0+ZG1aHP3m5OJCH+cW8dhcJaj3U0Ivn tCx0Z4q/KjvEBt2Eq7SKCB+rAF9mdQW9Ytzt0TaHcSnpriP2zaKwBqBpTqTejgpMGmre sRJiVfBCpj1xCK7+2ziQIvY+rK9TXSKgAzfvtC6dehd2gy5xHo34+rkGp4yfPa6Osx9c VOlQ== X-Gm-Message-State: ABuFfog9P0FV3R6cxWfYZ5WD2tGhM7lyoAxG39mD7qh9joTBNZI77ArH JKj/g8NPnx87M8T1zElhRwl1+A== X-Received: by 2002:adf:cd0c:: with SMTP id w12-v6mr19534363wrm.67.1539698480294; Tue, 16 Oct 2018 07:01:20 -0700 (PDT) Received: from localhost.localdomain (221.56.88.92.rev.sfr.net. [92.88.56.221]) by smtp.gmail.com with ESMTPSA id b81-v6sm10195012wmh.47.2018.10.16.07.01.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 16 Oct 2018 07:01:19 -0700 (PDT) From: Daniel Lezcano To: heiko@sntech.de Cc: linux-kernel@vger.kernel.org, Rob Herring , Mark Rutland , Vicente Bergas , Shawn Lin , Ezequiel Garcia , Enric Balletbo i Serra , Manivannan Sadhasivam , devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS), linux-arm-kernel@lists.infradead.org (moderated list:ARM/Rockchip SoC support), linux-rockchip@lists.infradead.org (open list:ARM/Rockchip SoC support) Subject: [PATCH] DT: rockchip: Fix stability issues with the 'performance' governor on rock960 Date: Tue, 16 Oct 2018 16:00:20 +0200 Message-Id: <1539698431-12616-1-git-send-email-daniel.lezcano@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org When the performance governor is set as default, the rock960 hangs around one minute after booting, whatever the activity is (idle, key pressed, loaded, ...). Based on the commit log found at https://patchwork.kernel.org/patch/10092377/ "vdd_log has no consumer and therefore will not be set to a specific voltage. Still the PWM output pin gets configured and thence the vdd_log output voltage will changed from it's default. Depending on the idle state of the PWM this will slightly over or undervoltage the logic supply of the RK3399 and cause instability with GbE (undervoltage) and PCIe (overvoltage). Since the default value set by a voltage divider is the correct supply voltage and we don't need to change it during runtime we remove the rail from the devicetree completely so the PWM pin will not be configured." After removing the vdd-log from the rock960's specific DT, the board does no longer hang and shows a stable behavior. Apply the same change for the rock960 by removing the vdd-log from the DT. Signed-off-by: Daniel Lezcano --- arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi | 12 ------------ 1 file changed, 12 deletions(-) -- 2.7.4 Tested-by: Manivannan Sadhasivam diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi index 6c8c4ab..56abbb0 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi @@ -57,18 +57,6 @@ regulator-always-on; vin-supply = <&vcc_sys>; }; - - vdd_log: vdd-log { - compatible = "pwm-regulator"; - pwms = <&pwm2 0 25000 0>; - regulator-name = "vdd_log"; - regulator-min-microvolt = <800000>; - regulator-max-microvolt = <1400000>; - regulator-always-on; - regulator-boot-on; - vin-supply = <&vcc_sys>; - }; - }; &cpu_l0 {