| Message ID | 1621318822-29332-4-git-send-email-skakit@codeaurora.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | None | expand |
On 18-05-21, 11:50, satya priya wrote: > Add base DTS file for pm7325 along with GPIOs and temp-alarm nodes. > > Signed-off-by: satya priya <skakit@codeaurora.org> > Reviewed-by: Matthias Kaehlcke <mka@chromium.org> > --- > Changes in RESEND V4: > - No Changes. > > arch/arm64/boot/dts/qcom/pm7325.dtsi | 53 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 53 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/pm7325.dtsi > > diff --git a/arch/arm64/boot/dts/qcom/pm7325.dtsi b/arch/arm64/boot/dts/qcom/pm7325.dtsi > new file mode 100644 > index 0000000..e7f64a9 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/pm7325.dtsi > @@ -0,0 +1,53 @@ > +// SPDX-License-Identifier: BSD-3-Clause > +// Copyright (c) 2021, The Linux Foundation. All rights reserved. > + > +#include <dt-bindings/interrupt-controller/irq.h> > +#include <dt-bindings/spmi/spmi.h> > + > +&spmi_bus { > + pm7325: pmic@1 { > + compatible = "qcom,pm7325", "qcom,spmi-pmic"; where is qcom,pm7325 documented? > + reg = <0x1 SPMI_USID>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + pm7325_temp_alarm: temp-alarm@a00 { > + compatible = "qcom,spmi-temp-alarm"; > + reg = <0xa00>; > + interrupts = <0x1 0xa 0x0 IRQ_TYPE_EDGE_BOTH>; > + #thermal-sensor-cells = <0>; > + }; > + > + pm7325_gpios: gpios@8800 { > + compatible = "qcom,pm7325-gpio", "qcom,spmi-gpio"; where is qcom,pm7325-gpio documented? > + reg = <0x8800>; > + gpio-controller; > + gpio-ranges = <&pm7325_gpios 0 0 10>; > + #gpio-cells = <2>; > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + }; > +};
On 2021-05-18 22:12, Matthias Kaehlcke wrote: > On Tue, May 18, 2021 at 05:16:27PM +0530, Vinod Koul wrote: >> On 18-05-21, 11:50, satya priya wrote: >> > Add base DTS file for pm7325 along with GPIOs and temp-alarm nodes. >> > >> > Signed-off-by: satya priya <skakit@codeaurora.org> >> > Reviewed-by: Matthias Kaehlcke <mka@chromium.org> >> > --- >> > Changes in RESEND V4: >> > - No Changes. >> > >> > arch/arm64/boot/dts/qcom/pm7325.dtsi | 53 ++++++++++++++++++++++++++++++++++++ >> > 1 file changed, 53 insertions(+) >> > create mode 100644 arch/arm64/boot/dts/qcom/pm7325.dtsi >> > >> > diff --git a/arch/arm64/boot/dts/qcom/pm7325.dtsi b/arch/arm64/boot/dts/qcom/pm7325.dtsi >> > new file mode 100644 >> > index 0000000..e7f64a9 >> > --- /dev/null >> > +++ b/arch/arm64/boot/dts/qcom/pm7325.dtsi >> > @@ -0,0 +1,53 @@ >> > +// SPDX-License-Identifier: BSD-3-Clause >> > +// Copyright (c) 2021, The Linux Foundation. All rights reserved. >> > + >> > +#include <dt-bindings/interrupt-controller/irq.h> >> > +#include <dt-bindings/spmi/spmi.h> >> > + >> > +&spmi_bus { >> > + pm7325: pmic@1 { >> > + compatible = "qcom,pm7325", "qcom,spmi-pmic"; >> >> where is qcom,pm7325 documented? > > good point, I missed that one. > Actually this point was discussed during V2( https://lore.kernel.org/patchwork/patch/1406186/#1607321 ). As far as I understand it is not mandatory to add "qcom,pm7325" as we are adding "qcom,spmi-pmic". It is just a good to have change. I could not find the documentation for pm8350c, pmk8350 and pmr735a as well. >> > + reg = <0x1 SPMI_USID>; >> > + #address-cells = <1>; >> > + #size-cells = <0>; >> > + >> > + pm7325_temp_alarm: temp-alarm@a00 { >> > + compatible = "qcom,spmi-temp-alarm"; >> > + reg = <0xa00>; >> > + interrupts = <0x1 0xa 0x0 IRQ_TYPE_EDGE_BOTH>; >> > + #thermal-sensor-cells = <0>; >> > + }; >> > + >> > + pm7325_gpios: gpios@8800 { >> > + compatible = "qcom,pm7325-gpio", "qcom,spmi-gpio"; >> >> where is qcom,pm7325-gpio documented? > > It's added by the 'Add GPIO support for PM7325' series > (https://patchwork.kernel.org/project/linux-arm-msm/list/?series=481133) > > The binding change was acked by Rob and the code by Bjorn, so it can be > expected to land, but it would still be good to mention the dependency > explicitly. The binding patch is applied now. Thanks, Satya Priya
On 20-05-21, 12:02, skakit@codeaurora.org wrote: > On 2021-05-18 22:12, Matthias Kaehlcke wrote: > > On Tue, May 18, 2021 at 05:16:27PM +0530, Vinod Koul wrote: > > > On 18-05-21, 11:50, satya priya wrote: > > > > Add base DTS file for pm7325 along with GPIOs and temp-alarm nodes. > > > > > > > > Signed-off-by: satya priya <skakit@codeaurora.org> > > > > Reviewed-by: Matthias Kaehlcke <mka@chromium.org> > > > > --- > > > > Changes in RESEND V4: > > > > - No Changes. > > > > > > > > arch/arm64/boot/dts/qcom/pm7325.dtsi | 53 ++++++++++++++++++++++++++++++++++++ > > > > 1 file changed, 53 insertions(+) > > > > create mode 100644 arch/arm64/boot/dts/qcom/pm7325.dtsi > > > > > > > > diff --git a/arch/arm64/boot/dts/qcom/pm7325.dtsi b/arch/arm64/boot/dts/qcom/pm7325.dtsi > > > > new file mode 100644 > > > > index 0000000..e7f64a9 > > > > --- /dev/null > > > > +++ b/arch/arm64/boot/dts/qcom/pm7325.dtsi > > > > @@ -0,0 +1,53 @@ > > > > +// SPDX-License-Identifier: BSD-3-Clause > > > > +// Copyright (c) 2021, The Linux Foundation. All rights reserved. > > > > + > > > > +#include <dt-bindings/interrupt-controller/irq.h> > > > > +#include <dt-bindings/spmi/spmi.h> > > > > + > > > > +&spmi_bus { > > > > + pm7325: pmic@1 { > > > > + compatible = "qcom,pm7325", "qcom,spmi-pmic"; > > > > > > where is qcom,pm7325 documented? > > > > > good point, I missed that one. > > > > Actually this point was discussed during V2( > https://lore.kernel.org/patchwork/patch/1406186/#1607321 ). > As far as I understand it is not mandatory to add "qcom,pm7325" as we are > adding "qcom,spmi-pmic". It is just a good to have change. > I could not find the documentation for pm8350c, pmk8350 and pmr735a as well. Yes that is a miss too, IMO all of these should be added to Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt or the yaml file replacing this Thanks
On 2021-05-20 12:50, Vinod Koul wrote: > On 20-05-21, 12:02, skakit@codeaurora.org wrote: >> On 2021-05-18 22:12, Matthias Kaehlcke wrote: >> > On Tue, May 18, 2021 at 05:16:27PM +0530, Vinod Koul wrote: >> > > On 18-05-21, 11:50, satya priya wrote: >> > > > Add base DTS file for pm7325 along with GPIOs and temp-alarm nodes. >> > > > >> > > > Signed-off-by: satya priya <skakit@codeaurora.org> >> > > > Reviewed-by: Matthias Kaehlcke <mka@chromium.org> >> > > > --- >> > > > Changes in RESEND V4: >> > > > - No Changes. >> > > > >> > > > arch/arm64/boot/dts/qcom/pm7325.dtsi | 53 ++++++++++++++++++++++++++++++++++++ >> > > > 1 file changed, 53 insertions(+) >> > > > create mode 100644 arch/arm64/boot/dts/qcom/pm7325.dtsi >> > > > >> > > > diff --git a/arch/arm64/boot/dts/qcom/pm7325.dtsi b/arch/arm64/boot/dts/qcom/pm7325.dtsi >> > > > new file mode 100644 >> > > > index 0000000..e7f64a9 >> > > > --- /dev/null >> > > > +++ b/arch/arm64/boot/dts/qcom/pm7325.dtsi >> > > > @@ -0,0 +1,53 @@ >> > > > +// SPDX-License-Identifier: BSD-3-Clause >> > > > +// Copyright (c) 2021, The Linux Foundation. All rights reserved. >> > > > + >> > > > +#include <dt-bindings/interrupt-controller/irq.h> >> > > > +#include <dt-bindings/spmi/spmi.h> >> > > > + >> > > > +&spmi_bus { >> > > > + pm7325: pmic@1 { >> > > > + compatible = "qcom,pm7325", "qcom,spmi-pmic"; >> > > >> > > where is qcom,pm7325 documented? >> >> > >> > good point, I missed that one. >> > >> >> Actually this point was discussed during V2( >> https://lore.kernel.org/patchwork/patch/1406186/#1607321 ). >> As far as I understand it is not mandatory to add "qcom,pm7325" as we >> are >> adding "qcom,spmi-pmic". It is just a good to have change. >> I could not find the documentation for pm8350c, pmk8350 and pmr735a as >> well. > > Yes that is a miss too, IMO all of these should be added to > Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt or the yaml > file replacing this > Okay, will add those four pmics to qcom,spmi-pmic.txt. > Thanks
diff --git a/arch/arm64/boot/dts/qcom/pm7325.dtsi b/arch/arm64/boot/dts/qcom/pm7325.dtsi new file mode 100644 index 0000000..e7f64a9 --- /dev/null +++ b/arch/arm64/boot/dts/qcom/pm7325.dtsi @@ -0,0 +1,53 @@ +// SPDX-License-Identifier: BSD-3-Clause +// Copyright (c) 2021, The Linux Foundation. All rights reserved. + +#include <dt-bindings/interrupt-controller/irq.h> +#include <dt-bindings/spmi/spmi.h> + +&spmi_bus { + pm7325: pmic@1 { + compatible = "qcom,pm7325", "qcom,spmi-pmic"; + reg = <0x1 SPMI_USID>; + #address-cells = <1>; + #size-cells = <0>; + + pm7325_temp_alarm: temp-alarm@a00 { + compatible = "qcom,spmi-temp-alarm"; + reg = <0xa00>; + interrupts = <0x1 0xa 0x0 IRQ_TYPE_EDGE_BOTH>; + #thermal-sensor-cells = <0>; + }; + + pm7325_gpios: gpios@8800 { + compatible = "qcom,pm7325-gpio", "qcom,spmi-gpio"; + reg = <0x8800>; + gpio-controller; + gpio-ranges = <&pm7325_gpios 0 0 10>; + #gpio-cells = <2>; + interrupt-controller; + #interrupt-cells = <2>; + }; + }; +}; + +&thermal_zones { + pm7325_thermal: pm7325-thermal { + polling-delay-passive = <100>; + polling-delay = <0>; + thermal-sensors = <&pm7325_temp_alarm>; + + trips { + pm7325_trip0: trip0 { + temperature = <95000>; + hysteresis = <0>; + type = "passive"; + }; + + pm7325_crit: pm7325-crit { + temperature = <115000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; +};