From patchwork Wed Jan 10 16:22:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 124107 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp5472509qgn; Wed, 10 Jan 2018 08:22:48 -0800 (PST) X-Google-Smtp-Source: ACJfBouTa2LoI0EIxTc6PbB5uVbu3rpfSt+1qpYP0uK70bM/joKNCXem+rYEFHPKSwq/jsEznMfL X-Received: by 10.84.128.36 with SMTP id 33mr19082981pla.75.1515601368331; Wed, 10 Jan 2018 08:22:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1515601368; cv=none; d=google.com; s=arc-20160816; b=KkUU1G2k5g9PY8Vn1YJpvBCnaBwMClF1urjrPNO2V1/vMgzJvgx8Daup3JOGPJ84T3 2QX3RiU4a+9/GqocZZpNWgLay99HwHentHx254y16AgfPBC9SKDHYKJwqoFbmo3gpp+4 qr8DLZ+jh+SUltAxS28itay7mRechHKSl6kea/R1MoT3RamvjuBLlP59GzhN/0yFevLY 8BSGG3PS5Vt+hpouL0oKzbHrTNuNh7Gy55G/1FMzbNG4K9ZDYRSSSSRLVMzhCALe1doe ub3CKTXSoHuvi5rkVxGwr8ijhLFGjYXVVrPIyvoMxwFF6uaOU1CgggNPD4QSgefD2f0E JDwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=yapWHn19AT8BIg4L4W7U9zDrcJ/NnErNMcrSZFDUiLM=; b=HSvufGBuiEpo2gJK3hFGZZA5aaEXkkrTu1RgVQ0b74qI7P00fSMS1zOU9wyc+tT08K 2eRRhaXQfk9ELCoqy3hNgVV0c3OHI2CFhbI/PBB7qdVBMv+ifImdxRPsBLZWWRl94fG7 KBf0xbM7YnR+ywHSmYv2Wwv3/IC99qbUookeQ+J2TsHuymE6kVLp1izmtS21w5SPlDmL JtVHXWdcwZQmc5MmRsBEU4A4+nZmVr2aQQoRZclKQ3ujCo7TF8S6Vd/PnjuLIiql/Mi/ LisBt35Fns5UbWlx03tcp+DZBT2lW4VaKiKreG76siBpoK2eShR9UN3C3GMXoWSXP61f s1Pw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i1si12173928plt.35.2018.01.10.08.22.47; Wed, 10 Jan 2018 08:22:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965944AbeAJQWq (ORCPT + 6 others); Wed, 10 Jan 2018 11:22:46 -0500 Received: from mout.kundenserver.de ([212.227.126.134]:57232 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965909AbeAJQWp (ORCPT ); Wed, 10 Jan 2018 11:22:45 -0500 Received: from wuerfel.lan ([95.208.111.237]) by mrelayeu.kundenserver.de (mreue007 [212.227.15.129]) with ESMTPA (Nemesis) id 0LrDwG-1f0xrW2zro-0136HM; Wed, 10 Jan 2018 17:22:22 +0100 From: Arnd Bergmann To: Vladimir Zapolskiy , Sylvain Lemieux Cc: Arnd Bergmann , Rob Herring , Mark Rutland , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] ARM: lpc3250: fix uda1380 gpio numbers Date: Wed, 10 Jan 2018 17:22:00 +0100 Message-Id: <20180110162220.224945-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:XL6nn3E9bLVTcjoo67Q6rfPUECqoWqnR+0pPXOieuFZLOe0F+/P bQP8EkNKrQqEPAEo/F5AAcvDC3UcjSDbetuP56GM5JPRUIwwFt6xndVLkHt8qoTbYFlXXgk IHr3Sbc4JkDgk1wPwRjajUDYNmSyeUCBFThBN3Y2MqtFrM11B6n4rjjw1/lWIO4QZhvXotu RSynj5k2fh/NRVKxZfV+w== X-UI-Out-Filterresults: notjunk:1; V01:K0:0QfRX3aqUNE=:PDlFcW1eEYmLfyUP+aoFYj np5i75SdYPh9i9te7JX5SoLI7mSHJBc5NdL2MXBWl5e5slOEz/gSZTwnX8Z2sbSSUvAo8dY9z 2U8Fz9cHOgMC5HjvREyGtKthUj4dLQ8eEkvEDPX+cxg/qo4LCjT8wZMUPT7gxYQxqmwTEyMkS jMmxHpmCf65vCA2tMmVYUYtV6YJ93qU7UuAC/Ze2PCF2besN+e5GDfTDc4BxVgebnNZPl2sVO Se8iTaIN/LkPKJwmdJePhqAHC4ltFvRxjUA0bA9kbMDhE9oU/JZQNiAVvA4CF8GdWt5hesONF yODAx5PfCpkkeNDg6Xg2FP3RrEcluC8xQEe+s6hj4o24WfTIKpShb3totJFtfyA2CDiH+t25h 4ma+WAPRTUolsK89107aaA79++/6L1sVMFoq2XPZLJ+xESH8GTsEh8u/uDXAeXh1cj88nR0EM VK1unJo5BR0fNO8i+lMFtPyxiZJPmgNfMpyOmGWjCDi+HFT1qvHYwgJ52MeuVe54SoPG/W2mt VRVHZDp19oposJTAZG1VQu9IVgxAUplId1+e1o+nRS3c/DHDkvTVCIg845aOXmN7NuNn/6s53 SFyHAV/PfwU0RVtQUs0nbY2ST7tU/ppo+7pNBt+o7BMWWsXYfFNnHWBrX0Qij+nt7FNPZlCrG 3l2oyeL5Irmm3d8VdoLxHufvO0Wt5sTA9ke48aGE0dX1UAT8B/YoV74aTstEfPzXs5Rgn4GZf a6RLe1RCsdcQtYCSpzvIFbq8BVP44CijVuiUlA== Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org dtc warns about obviously incorrect GPIO numbers for the audio codec on both lpc32xx boards: arch/arm/boot/dts/lpc3250-phy3250.dtb: Warning (gpios_property): reset-gpio property size (12) too small for cell size 3 in /ahb/apb/i2c@400A0000/uda1380@18 arch/arm/boot/dts/lpc3250-phy3250.dtb: Warning (gpios_property): power-gpio property size (12) too small for cell size 3 in /ahb/apb/i2c@400A0000/uda1380@18 arch/arm/boot/dts/lpc3250-ea3250.dtb: Warning (gpios_property): reset-gpio property size (12) too small for cell size 3 in /ahb/apb/i2c@400A0000/uda1380@18 arch/arm/boot/dts/lpc3250-ea3250.dtb: Warning (gpios_property): power-gpio property size (12) too small for cell size 3 in /ahb/apb/i2c@400A0000/uda1380@18 It looks like the nodes are written for a different binding that combines the GPIO number into a single number rather than a bank/number pair. I found the right numbers on stackexchange.com, so this patch fixes the warning and has a reasonable chance of getting things to actually work. Link: https://unix.stackexchange.com/questions/59497/alsa-asoc-how-to-correctly-load-devices-drivers/62217#62217 Signed-off-by: Arnd Bergmann --- arch/arm/boot/dts/lpc3250-ea3250.dts | 4 ++-- arch/arm/boot/dts/lpc3250-phy3250.dts | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) -- 2.9.0 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/arm/boot/dts/lpc3250-ea3250.dts b/arch/arm/boot/dts/lpc3250-ea3250.dts index c43adb7b4d7c..58ea0a4e7afa 100644 --- a/arch/arm/boot/dts/lpc3250-ea3250.dts +++ b/arch/arm/boot/dts/lpc3250-ea3250.dts @@ -156,8 +156,8 @@ uda1380: uda1380@18 { compatible = "nxp,uda1380"; reg = <0x18>; - power-gpio = <&gpio 0x59 0>; - reset-gpio = <&gpio 0x51 0>; + power-gpio = <&gpio 3 10 0>; + reset-gpio = <&gpio 3 2 0>; dac-clk = "wspll"; }; diff --git a/arch/arm/boot/dts/lpc3250-phy3250.dts b/arch/arm/boot/dts/lpc3250-phy3250.dts index c72eb9845603..1e1c2f517a82 100644 --- a/arch/arm/boot/dts/lpc3250-phy3250.dts +++ b/arch/arm/boot/dts/lpc3250-phy3250.dts @@ -81,8 +81,8 @@ uda1380: uda1380@18 { compatible = "nxp,uda1380"; reg = <0x18>; - power-gpio = <&gpio 0x59 0>; - reset-gpio = <&gpio 0x51 0>; + power-gpio = <&gpio 3 10 0>; + reset-gpio = <&gpio 3 2 0>; dac-clk = "wspll"; };